21

Last week I designed the front page of a construction company website for getting the internship....
After showing my sample to the HR ..he mailed me asking
--->
"Do you know how to code?"
--->
Now I don't know is it sarcastic or I really don't know how to code.

Comments
  • 1
  • 1
    @Vaibhav111 link to site?
  • 8
    Even HR knows that HTML is not a programming language.
  • 0
  • 2
    @C0D4 https://codepen.io/Vaibhav119/full/...
    Is it really that bad for a newbie
  • 0
  • 8
    @Vaibhav111 codepen and mobile don’t go well.

    The design looks alright, I can’t seem to navigate between sections, but that could just be codepen being a pain.

    The .html output seems messy.
    No doctype, head, body or nice structure.

    Avoid using google fonts directly, they tend to break or timeout just save the Roboto font to the project and serve it (follow the import URL and download the fonts and css)

    As for the css if your trying to do responsive don’t used fixed pixel widths/heights use percentages instead.

    Otherwise it looks reasonable for a beginner, just need to do that little bit extra to get a decent structured code base.
  • 2
    @C0D4 Thank you very much...I'll definitely take these points into account
  • 2
    @Vaibhav111
    Ah I see how you do the nav now using JS, god damn codepen is bad on mobile 😂

    You’ll need to keep the nav in view or at least give the user a means to show it again, to allow users to change “page / view”

    No problem, always happy to lend a hand.
  • 1
    @rEaL-jAsE iPhone 6s

    I think it’s just the iframe not accepting scroll input - I get it every time with codepen.

    I’ll have a better look later on pc.
  • 2
    @Vaibhav111, @C0D4 has a rather outdated opinion on making something responsive.
    Use flexbox to make it responsive.
    Sure, you can use %, but it will not always be responsive.
  • 4
    @-ANGRY-CLIENT- outdated?
    I would have said viewport width/height but he’s only new so let’s get it to actually be responsive instead of hard coding PX per media query before throwing flex at him.

    Also flex is in no ways backwards compatible (I personally deal with those older browsers still) so I’ll always suggest something more compatible over something trendy.
  • 0
    @rEaL-jAsE Thanks for ur support
  • 2
    @Vaibhav111 Looks impressive! Just a personal peeve, as a user of JavaScript blocking extensions I was uncomfortable with being required to unblock unpkg.io in order to render the site somewhat properly. Without its JS enabled, the whole thing breaks and most of the actual content isn't loaded. Add a fallback in <noscript></noscript> that doesn't load the animations but does display the text with its appropriate styling in CSS.
  • 1
    The answer is always yes
  • 0
    @M1sf3t Not working on it... currently
  • 0
    @M1sf3t yeah true....same here..
Add Comment