13

After learning programming for about 6 months I made an URL-shortener app.

The tech-stack includes React, Node.js and PostgreSQL.

I would like to hear you guys' opinion

https://github.com/larapollehn/...

Comments
  • 0
    Of course the live version can be viewed at Https://tinylink.larapollehn.de 😄
  • 2
    dunno much about js/ts, I'm not a web dev, but I like the elephants
  • 2
    Nice! Just wondering why you have to sign up?
  • 10
    @ScriptCoded
    Elephants don't like anonymoose.
  • 0
    poor tuffi 😢
  • 3
    @SortOfTested I hate that I smirked at that one
  • 1
    @ScriptCoded I wanted to practice user auth and a main feature is that users can see a statistic of how often a link was clicked in the last week.
  • 0
  • 3
    Few observations

    1. Token missing in the header should return 401 instead of 403
    2. Do you also same original URL to be tinified multiple times? Otherwise, you could set a constraint
    3. The minifier takes a slice of the sha2 output of your input and it may cause collisions
  • 3
    So quick look at your repo (specifically the ci file), and it looks like you have your servers private key in this repo.

    Plus if understand your deployment code. Your prod databases credentials are just the default Postgres ones?

    Be careful, someone else with this info can cost you lots of money.

    Otherwise looks really top notch! Good work :)
  • 3
    @python3 That is actually a good mention. My RSA private key is encrypted with AES. But I still should not let it be in the git repo...

    And for the production database password. I will note it for my next project... I never though the app will get so much attention at all
  • 0
    Congrats! You've earnt the privilege to call yourself Senior Full-stack Devops Engineer on Linkedin.

    (but srsly, well done)
Add Comment