30
rutee07
58d

My colleague's merge request is three months old now with over a hundred review points and counting. The reviewer still wouldn't let it pass - misspellings, hardcoded keys, broken pipelines, etc. Meanwhile, I shipped similar-sized components, more than I could count and most of them have zero review points.

I'm telling you this because that same colleague used to pass a lot of work to me but now that I'm busy working on our new thing, he had to work on the things I used to work on. I still remember when he would ask me if I can do something "faster". Dude, if I got pregnant the first time you sent this MR, you'll be racing against the development of a human life inside me then maybe when it's born, it will merge your code.

Comments
  • 5
    Shoot a cannon too fast and it will explode.

    Release too fast and it will explode.

    If it's crap. It's crap. Doesn't matter how fast you can shit.
  • 5
    At least everyone is now finding out the true nature of said colleague, if they didn't know already :-) Is this the arse you were complaining about on your last team? Good riddance if so.

    Months is crazy for a PR in any case. Anything that goes on longer than a few days here gets special attention, as either it's causing arguments, it's too crap to sort out sensibly, or people have missed it. Very rare that happens (at least from within the team, occasionally external parties try to poke their nose in - see other rant) but even in that case I think our record is two weeks.
  • 5
    @AlmondSauce Different guy. This one is not that much of an asshole, he's just not very detail-oriented and it's worsened by the fact that the project used to have very little code review and even then, it wasn't taken seriously. One of the many reasons they don't want to keep the old codebase anymore, it's patched up buggy shit that's too big worked on by too many people with the same mindset, and takes too much effort to refactor and even then it's not very performant either.

    Until now he's questioning the point of unit tests and why we can't use real data in the tests. I'm just glad we have another senior engineer who is very strict on this matter, otherwise it would be crappy codebase version 2.
  • 3
    @rutee07 Yeah, he sounds kinda clueless. People with that mindset can definitely change in fairness, but they need the humility to do so and a strong, senior lead to be able to take the reigns and take no bs. Sounds like that's what's happening which is no bad thing.
  • 2
    this one?
  • 1
  • 1
    @IntrusionCM This is my view too. If even someone like me, totally green, understands this, everyone else should too.
  • 1
    @IntrusionCM This is my view too. If even someone like me, totally green, understands this, everyone else should too.
  • 0
    Merge request? Gitlab? Why do github named it pull request? Most people like PR but I like MR.

    PR = purchase request
  • 0
    @Devnergy i needed to laugh very hard
Add Comment