Blowing up the PR scope waaayy beyond the ticket scope by applying the "oh, lemme fix this as well..." mantra.

  • 2
    Well, cleaning up a little isn't so bad in my opinion.

    A colleague once mentioned the "boyscout rule", and I kinda support it unless the cleaning up takes too long.

    And generally, if underlying architecture is changed I would make it it's own issue.
  • 0
    I’m fine with that as long as the code relevant to the PR is not totally drowned out by the refactored/fixed code. Otherwise may as well create a separate PR just for refactoring
Add Comment