Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Search - "didn't get em"
-
My code review nightmare part 3
Performed a review on/against a workplace 'nemesis'. I didn't follow the department standards document (cause I could care less about spacing, sorted usings, etc) and identified over 80 bugs, logic errors, n+1 patterns, memory leaks (yes, even in .net devs can cause em'), and general bad behavior (ex.'eating' exceptions that should be handled or at least logged)
Because 'Jeff' was considered a golden child (that's another long TL;DR), his boss and others took a major offense and demanded I justify my review, item by item.
About 2 hours into the meeting, our department mgr realized embarrassing Jeff any further wasn't doing anyone any good and decided to take matters into his own hands. Thinking 'well, its about time he did his job', I go back to my desk. About an hour later..
Mgr: "I need you in the conference room, RIGHT NOW!"
<oh crap>
Mgr: "I spoke to Jeff and I think I know what the problem is. Did you ever train him on any of the problems you identified in the review?"
Me: "Um, no. Why would I?"
Mgr: "Ha!..I was right. So lets agree the problems are partially your fault, OK?"
Me: "Finding the bugs in his code is somehow my fault?"
Mgr: "Yes! For example, the n+1 problem in using the WCF service, you never trained him on how to use the service. You wrote the service, correct?"
Me: "Yes, but it's not my job to teach him how to write C#. I documented the process and have examples in the document to avoid n+1. All he had to do was copy/paste."
Mgr: "But you never sat with Jeff and talked to him like a human being? You sit over there in your silo and are oblivious to the problems you cause. This ends today!"
Me: "What the...I have no idea what you are talking about. What in the world did Jeff tell you?"
Mgr: "He told me enough and I'm putting an end to it. I want a compressive training class developed on how to use your service. I'll give you a month to get your act together and properly train these developers."
3 days later, I submit the power-point presentation and accompanying docs. It was only one WCF with a handful of methods. Mgr approved the training, etc..etc. execute the 'training', and Jeff submits a code review a couple of weeks later. From over 80 issues to around 50. The poop hits the fan again.
Mgr: "What's your problem? When are you going to take your responsibility seriously?"
Me: "Its pretty clear I don't have the problem. All the review items were also verified by other devs. Its not me trying to be an asshole."
Mgr: "Enough with the excuses. If you think you can do a better job *you* make the code changes and submit them for Jeff for review. No More Excuses!"
Couple of days later, I make the changes, submit them for review, and Jeff really couldn't say too much other than "I don't see this as an improvement"
TL;DR, I had been tracking the errors generated by the site due to the bugs prior to my changes. After deployment, # of errors went from thousands per hour to maybe hundreds per day (that's another story) and the site saw significant performance increases, fewer customer complaints, etc..etc.
At a company event, the department VP hands out special recognition awards:
VP: "This award is especially well earned. Not only does this individual exemplify the company's focus on teamwork, he also went above and beyond the call of duty to serve our customers. Jeff, come on up and get this well deserved award."19 -
In my current work, I have two systems to work on (let's name em Systems A and B). Both basically do the same thing; both allow users to book facilities available to them.
System A is already in production. My job is to fix any bugs that come up on said system. System B is an improved version that they wanted me to develop. This would follow a different framework etc. I am already halfway through this system.
Now, here's the fucked up part. The code for system A is a massive clusterfuck. It has unused commented code dated back to ancient times where men had the brain of an ape.
And don't get me started on the fucking logic. One part of the code was to retrieve and display the timeslots available for a chosen facility. The code to do that alone takes up 500++ fucking lines, filled with ajax commands, html manipulation and commented, unused codes..AND THAT'S JUST THE FRONTEND!
The fucking backend was not a problem of smelly code anymore. Nope. It was like a programmer had code diarrhea and shat his backend code all over the project. If I had a pin board, I would have made a crazy wall just to understand what some fucknut was trying to achieve.
Anyway, my supervisor told me to fix some bugs on System A. Knowing how the code was, I told her that I could refactor the code. Since I've already achieved that function on System B, with a shorter and cleaner code, I could just copy that and use on System A. But nope. She SPECIFICALLY told me to just "do whatever to fix the bugs. I don't want to waste time on System A." Okay. Makes sense to me. Whatever. I didn't wanna fuck my head up looking through that mess of a cesspool. So, I came up with a few hacks, not thinking of clean code and fixed whatever bugs there was. I then just pushed to the repo (after testing of course).
This bloody morning, supervisor came in and gave me more bugs to fix. When I thought she was done, she said "Hey. I saw the fix you made to the system. The bugs are fixed but the retrieval of the timeslots is now pretty slow. Could you see what is the problem?"
Slow.. She said that it was slow. And asked if I could fix it. I already told her what the problem was and she did not want me to waste time on it. But she wants me to fix it. WHAT THE FUCK IS WRONG IN HER BLOODY HEAD! I SWEAR TO GOD... UGHHHHH I swear I was already waterboarding her in my head. YOU WANT FAST?? How bout fucking allowing me to refactor the code?? Fucking shit head. I think I should take up yoga.1 -
Worst code review experience?
Hard to pick just one, but most were in a big meeting room with 4+ other developers not related to the project and with some playing Monday-Morning-Quarterback instead of offering productive feedback.
In one code review, the department mgr reviewed the code from a third party component library.
<brings up the code on the big screen>
Mgr: "I can't read any of this, its a mix of English and something else."
Me: "Its German."
Mgr: "Then why is 'Button' in English? This code is a mess."
Me: "I'm not exactly sure how I should respond, I mean, I didn't write any of this code."
Mgr: "Yes, but you are using it, so it's fair game for a code review."
Me: "Its not really open source, but we can make requests if you found something that needs to be addressed."
Mgr: "Oh yes, all this...whatever this is..<pointing again to the German>"
Me: "I don't think they will change their code to English just so you can read it."
Mgr: "We paid good money, you bet your ass they'll change it!"
Me: "I think the components were like $30 for the unlimited license. They'll tell us to go to hell first. Is there something about my code you want to talk about?"
Mgr: "<Ugggh>...I guess not, I couldn't get past all that German. Why didn't we go with an American company? Hell, why didn't we just write these components ourselves!?"
Me: "Because you gave a directive that if we found components that saved us time, to put in a request, and you approved the request. The company is American, they probably outsourced or hired German developers. I don't know and not sure why we care."
Mgr: "Security! What if they are sending keystrokes back to their servers!"
Me: "Did you see any http or any network access?"
Mgr: "How could I? The code is in German!"
Monday-Morning-Quarterback1: "If it were me, I would have written the components myself and moved on"
Me: "No, I don't think you could for less than $30"
Monday-Morning-Quarterback2: "Meh...we get paid anyway. Just add the time to the estimate."
Mgr: "Exactly! Why do we even have developers who can't read this mess."
Me: "Oh good Lord! Did anyone review or even look at my code for this review!?"
<silence>
Mgr: "Oh...ok...I guess we're done here. Thanks everyone."
<everyone starts to leave>
Me: "Whoa!...wait a sec..am I supposed to do something?"
Mgr: "Get that company to write their code in English so we can read it. You have their number, call em'...no...wait...give me their number. You keep working, I'll take care of this personally"
In they nicest way possible, the company did tell him to go to hell.18 -
After returning back from the company we were purchasing a new phone system (hardware+software, $100K+, kind of a big deal)
VP: “I need the new phone system software integration for our CRM by next week. I need to demo the system for the other VPs”
Me: “No problem. Were you able to get their API like I asked?”
VP: “Salesman didn’t know for sure what that was, but he said all the developer software documentation is on their site.”
Me: “Did he give you a URL? Their main site is all marketing mumbo-jumbo. I assume there is another one specific for developers.”
VP: “Yea, he might have said something, but I don’t understand why you need it. The salesman said the integration would be seamless. He showed me several demos.”
Me: “No, I mean I need to know, is the API a full client install? a simple dll? is this going to be a web service integration? How will I know what to program against?”
VP: “I think I heard him say something about COM? Does that sound like an API?”
Me: “It’s a start. Did he provide you anything, a disk, a flash drive, anything with the software?”
VP: “No, only thing he told me was our CRM integration would be seamless and our development team would have no problems.”
Me: “OK..OK…I get it…he’s a salesman. Is there an 1-800 number I can call? A technical support email address? Anyone technical I can reach out to?”
VP: “Probably, but I don’t understand what the problem is. I need the CRM integrated by next week. I gave the other VPs a promise we would get it done. I do not break promises.”
Me: “Wait…when are we installing the new system?”
VP: “Well, the purchase order will be cut at the end of the month’s billing cycle, the company has about a two month turnaround time to deliver and install the hardware, so maybe 3 months from now? Are you going to be able to have the integration ready for next week?”
Me: “If we won’t see any of the hardware for 3 months, what exactly am I integrating with?”
VP: “That API you wanted or whatever it is. COM…yea, it’s COM. I was told the integration would be seamless and our developers would have no problem. I don’t understand why you can’t simply write the code to make it work. Getting the hardware installed is going to be the hardest part.”
Me: “OK, so I have no documentation, we have no hardware, no software, and no idea what this ‘seamless integration’ means. I’m afraid there isn’t anything I can do right now. ”
VP: “Fine!...I’ll just have to tell the other VPs you were not able to execute the seamless integration with the CRM.”
Which he did. When the hardware+software was finally installed, they hired consultants (because I “failed”). I think the bill was in the $50K range to perform the ‘integration’ which consisted of Excel spreadsheets (no kidding). When approached with the primary CRM integration, the team needed our API documentation, a year’s development time and $300K. I was pissed off enough, and I had the API documentation, I was able to get the basic CRM integration within 3 days. When an agent receives a call, I look up the # in our database, auto-fill the form with the customer info, etc. Easy stuff when you have the documentation.
The basics worked and the VP was congratulated by ‘saving’ the company $300K. May or may not have been bonuses involved, rumors still out on that one, but I didn't see em'. Later my manager told me the VP was really ticked that I performed the integration ‘behind his back’, but because it was a success, he couldn’t fire me.10 -
Recently started at a new job. Things were going fine, getting along with everyone, everything seems good and running smoothly, a few odd things here and there but for the most part fine.
Then I decided to take a look at our (public facing) website... What's this? Outdated plugins from 2013? Okay, that's an easy fix I guess? All of these are free and the way we're using them wouldn't require a lot of refactoring...
Apparently not. Apparently, we can't even update them ourselves, we have to request that an external company does it (which we pay, by the way, SHITELOADS of money to). A week goes past, and we finally get a response.
No, we won't update it, you'll have to pay for it. Doesn't matter that there's a CVE list a bloody mile long and straight up no input validation in several areas, doesn't matter that tens of thousands of users are at risk, pay us or it stays broken. Boggles the fuckin' mind.
I dug into it a bit more than I probably should have (didn't break no laws though I'm not a complete dumbass, I just work for em) and it turns out it's not just us getting fucked over, it's literally EVERYONE using their service which is the vast majority of people within the industry in my country. It also turns out that the entirety of our region is running off a single bloody IP which if you do a quick search on shodan for, you guessed it, also has a CVE list pop up a fuckin' mile long. Don't get me started on password security (there is none). I hate this, there's fucking nothing I can do and everyone else is just fine sitting on their hands because "nobody would target us because we're not a bank!!", as if it bloody matters and as if peoples names, addresses, phone numbers and assuming someone got into our actual database, which wouldn't be a fuckin' stretch of the imagination let me tell you, far more personal details, that these aren't enticing to anyone.
What would you do in my situation?
What can I even do?
I don't want to piss anyone senior off but honestly, I'm thinkin' they might deserve it. I mean yeah there's nothing we can do but at least make a fuss 'cause they ain't gunna listen to my green ass.10 -
>work on multi million dollar company
>last year "we were doing fine" until we got told "well, turns out we didn't, no bonus this year"
>people leave
>You'll get a bonus next year for sure
>Company cuts expenses such as training budgets and freezes raises and promotions
>People still leave
>There are whole teams that are now left with 1-3 people, lol
>Turns out we will not get any bonuses this year either, except for "the high achievers", but they have not announced it yet
>high achievers include the evp of engineering who single handedly destroyed the company's DevOps department last year and an EM/engineer who is completely incompetent as both an engineer as well as a manager, so much so that the company has made him his own 1-person-department so that he doesn't have to work with other people
>Upper management keeps telling us everything is going fine and they suck each other's d**k
This is like watching a trainwreck in slow motion lmao.
I'll stay till they announce this year's bonuses to watch the shit show and then I'll leave17 -
Had an internet/network outage and the web site started logging thousands of errors and I see they purposely created a custom exception class just to avoid/get around our standard logging+data gathering (on SqlExceptions, we gather+log all the necessary details to Splunk so our DBAs can troubleshoot the problem).
If we didn't already know what the problem was, WTF would anyone do with 'There was a SQL exception, Query'? OK, what was the exception? A timeout? A syntax error? Value out of range? What was the target server? Which database? Our web developers live in a different world. I don't understand em.1 -
!dev
Through life, I've heard some people say horror movies are bad, that they promote violence (usually religious people).
Of course I think that's pure bs, but I think I could provide one argument that is hard to deny, so here it goes, although I might go off rails at the end.
I'll preface with this: life itself is violent. Violence, the word, is mostly used to describe immoral inflictions of harm on other beings.
But you can also say that some deaths are violent by themselves too, event those that weren't caused by humans, like a disease or a natural disaster.
This would be the "visual" meaning of the word, "the way it looks", the shock of humans when observing something gruesome/violent.
That described, it's not hard to also think that technological advancements in modern western life has made such observations of violence very unfrequent for people.
And naturally, modern people get accustomed to the lack of these observations. So accustomed that when they happen they become traumatic.
Because of this, people react weirdly to death. One reaction is censoring the topic. Another reaction is trivializing it, as if it doesn't really matter.
Sometimes they can't even accept old people dying at 90, an awfully stupid reaction in my opinion.
Another interesting reaction is personifying diseases as if they were villains ruining lives intentionally.
Or at least that's what it feels until you look at them through a microscope and realize that diseases aren't more evil than bread changing flavour after toasting.
All of these irrationality and cowardice comes from low exposure to violence, and that's where horror movies balance things out.
Some diseases in the real life can put some of the worst horror movies to shame.
The human body itself is pending violence. Why? Because when you die all sort of worms eat your fucking flesh. And sometimes that happens even before you die.
We bury humans because of the diseases corpses transmit, but also because we don't like the spectacle and the aesthetics of the rotting process.
Just picture for a second bad things happening to your body, and if you feel that is making you too uncomfortable, then maybe you got too used to this too.
I think horror movies help us to remember the reality of our inminent and intrinsic violence.
In ancient times, you would live outdoors, stepping on dirt, and be very used to "bad" things happening to humans.
Nowadays, most homes are sterile clean, and it's unlikely to observe violence.
Oh, some family member is pucking blood and dying from something? Send em to a hospital, or an elderly care center. Don't need to witness that!
I understand and accept grief. What I don't understand or accept is the vilification of death, describing it as something wrong that shouldn't happen.
it almost feels like a burden, like you shouldn't die when you're young, that it's an unforgivable thing to happen.
Well thanks, society, you can't even fucking die in peace.
I would love to die (no suicide) in a mildly celebratory way, watching people around me smile. I think that would be a good ending for me.
But no. Most of my relatives would be fucking crying like the chickenshits they are, ruining it for me.
And that scares the shit out me: people usually say the scary part of dying is that they die alone.
Well that's what dying alone would mean to me: watching people cry instead of smiling at me.
When my grandma died at 80, with all the achievements she made, I considered her death a success, also considering how quick it was. And because of that I didn't mourn for too long.
In fact, I don't even consider her dead, and not because of some religious mumbo jumbo. I guess the memories are still alive in me, I don't know.
Some famous chunk of coal said once that he felt people don't believe they're gonna die. And I agree with him.
Another upside of horror movies is that they hurt nobody, which is why you can enjoy it and not get ptsd, unlink watching a snuff film.
I will also be fair and add that this might a be a cultural thing, but deep down desire for survival is a genetic thing could play a big part in this too.4 -
https://microsoft.com/store/apps/...
the pet project I thought would take 2 weeks but took waaayy longer -.-
critique it?
Known issues:
tries to get dimensions from the width, works half the time, will make a setup process in the beginning eventually and allow people to change the values.
Background download, lockscreen and wallpaper all use different methods, trying to see which one works better, doesn't use a separate background process by itself hence easier on the system resources.
the "dismiss" is there just so the notifs carry images in phone. Somehow, notifs with just images and no buttons didn't show the images on phone, hence a temporary workaround, will be replaced with actual buttons later :p
Search and sketch don't work the way I want em to, are there but not accessible, will be there eventually.
tips? things I should change? anything?
And not the final logo, took it from a sample package to submit it, will tinker with the logo thing later :p
//first UWP6 -
I went to do the "transport-tracker" Google Codelabs that uses JS/Firebase/Maps, and I didn't pick up on how really outdated it was lol... it took me about an hour of ehat seemed like an endless climb out of a shit factory....but I passed my NPM "massive errors" trial by fire with flying colors, got everything working mint, and managed to get most of everything (minus the docs) updated/cleaned up. Holy fuck that was crazy, it's amazing how many things change in such little time!!!
Anyways, the main reason I'm here is.... should I push the used-to-be-old-and-fucked-up codelabs I fixed up and made current to Google?? They are pretty important concepts that cover a lot of ground, so I feel like labs/tutorials should be refreshed by up and comers every so often but I don't know if there's a reason why we leave em to just rot and die haha