Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
Nevoic2613ySounds like it could be a him problem or a you problem, depending on what he's actually doing.
All the illusory stuff though, like claiming he's going to act on a story and then not doing it but just refactoring, that's shitty. He should allot time for refactoring and argue for that and then refactor.
He also shouldn't be removing unit tests unless he's replacing them with other unit tests.
But "adding layers" isn't innately bad. I have co-workers that are fine with our Active Record models being hundreds of lines long. Approaching a thousand. Without the want to separate the domain entity embedded in the AR object from the data object that an AR object should be.
Adding that layer (the domain layer) adds more clarity, allows for quicker unit tests, and removes tightly coupled dependencies on AR, allowing your business logic to be free and allowing you to change implementations if you want.
That all being said, priorities. If it's not a business priority, he shouldn't do it.
CWins51593yI think it's easier to ask for forgiveness than permission, so i understand why he just does it. In the daily business it's just unlikely that someone gets told to reduce software rot, and i think that it's important to keep reused components clean.
That however does not sound like he is doing work that benefits the overall development.