Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
"public static string CleanString(this String str)"
Why the redundant "String" in the extension name?
Why use the class name and not the alias IE string not String.
"if (str != "" && str != null)"
string.IsNullOrEmpty() - also, its an extension method so str will never be null.
"str = str.Replace("!", "");" Well, there are many different implementations, and this has to be the absolute worse.
when your code is a mess but everything work out in the end
When you keep getting +1s on a rant you posted a month ago.
Go big or go home.
Just found this little nugget... So much wrong with this.
public static class CleanString
{
public static string CleanString(this String str)
{
if (str != "" && str != null)
{
str = str.Replace("!", "");
str = str.Replace("£", "");
str = str.Replace("$", "");
str = str.Replace("%", "");
str = str.Replace("^", "");
str = str.Replace("&", "");
str = str.Replace("*", "");
str = str.Replace("(", "");
str = str.Replace(")", "");
str = str.Replace("-", "");
str = str.Replace("=", "");
str = str.Replace("{", "");
str = str.Replace("}", "");
str = str.Replace("[", "");
str = str.Replace("]", "");
.....
return str;
}
}
}
rant