12
wypaliz
16d

Working with a new team and I don't understand how this is normal or ok.

Me: Does anyone need help troubleshooting the broken build or can I revert this change that broke it so I can push my change out?

Dev: Stop build shaming me, I wouldn't leave the build in a failing state.

Me: Well, I wasn't sure how long to wait, before asking.... it's been broken for 4 hours.

Dev: It's the development environment, you should expect development to be going on.

Me: Yes and appears that this project architecture doesn't support any sort of isolation for development. So nobody can deploy anything except through the development branch.

Dev: That's what development is for IMO, so it doesn't bother me.

Comments
  • 4
    Dew it
  • 3
    Well, the dev is childish. He/she immediately felt attacked when you stated facts and only referenced things (the commit, the failing build) instead of people. And the excuses make it clear the dev knew he/she did something wrong.
    Is this normal or ok? Yes, it's somewhat prevalent in the industry. No, it's not okay.
  • 3
    Builds from development branches should NOT be failing. Make changes on your own branch, rebase from development branch, test if build works in CI (if that exists), merge with development branch (optionally: create a merge request that someone else merges for you)
  • 1
    @kescherRant yeah good point, I usually point feature branches to Dev env... But even that won't help at this point because of how jacked the architecture is. Or, the lack of an architecture plan might be the better explanation.
  • 1
    @VaderNT to be fair, I've been pointing out these types of things for the past two days and they are all tired of me. I called them out yesterday for making changes directly in the release branch and then merging them back down into develop. Among other things.
  • 2
    Normal or not, it's wrong.
  • 2
    Has that dev ever heard of git flow?
  • 2
    @wypaliz Of course they are. It took me way too long to understand one central thing about people:
    People never do anything wrong. From their point of view, that is, because otherwise they wouldn't be doing it.

    People react differently to being shown they're wrong. Some are thankful for the opportunity to improve themselves. Others get annoyed or, like that dev, throw a hissy fit.
  • 2
    @VaderNT I like if someone tells me I did something wrong, especially coming from another dev. We are humans, so we might make mistakes - and those mistakes will eventually be made without being noticed by the one who makes it - which is why I like constructive criticism a lot in this area.
  • 1
    Got some criticism on the refactoring merge request I made today, because I missed some stuff.
    Was glad that I got it.
  • 1
    @kescherRant I like your attitude. Keep being awesome!
Your Job Suck?
Get a Better Job
Add Comment