My first contribution to a GitHub project was finally merged to the master branch today! It was just a bug fix but it’s a start!!

Feels good, doesn't it!

I fixed a bug in the PHP code coverage package a while back. Merging multiple code coverage results did not yield same result as them same test cases being run in a single process. I was a little bit proud to contribute to a package which is installed so many times.

@Hel8y it feels really good, and it’ll teach me more about large scale projects and tests and being better overall

@Bubbles True! I even want to make some our companies packages open source. We've got some great packages for running async jobs and some other package for DNS stuff. Especially the async job packages work really well, they have been integrated in all of our own projects and I really couldn't live without it anymore.

@Hel8y wouldn’t that be illegal

@Bubbles not at all, I'm responsible for all things IT related at work. Publishing those packages is ultimately my decision, as long as I can explain why it is good for our company that I published them (will published them on a company github page though, not my personal account).

@Hel8y hm, interesting.

@Hel8y it's not that easy.

You must check with your legal department.

It's all snowflakes until your package crashes the production of a big company.

@Cultist well, we don't have a legal department. But doesn't an open source license cover those situations?

@Hel8y yes it does. But as you know, you still have to handle shitheads who don't care about licences and just want to throw back the responsibility to you.

Keep in mind you need to properly maintain, support and document your company open source packages. Otherwise it's not good for your image.

This is all doable, but it needs a framework (elect a champion for every repo, proper licencing, decide release cycles, etc ...)

@Cultist well, being sued by other companies happens from time to time, but we never had any real problems with in (we lack a legal department, but this doesn't mean we don't check anything at all :))

Maintaining, supporting and documenting shouldn't be a problem at all. All of our internal projects are properly maintained, supported and documented as well. Beside the documentation, all of the projects have strict guidelines on coding standards, test cases, code coverage and code quality. And this is just for the projects the world will never see. I think we will be fine :)

One of the motivations for releasing the project open source is our image. All packages are PHP libraries (not end user software). PHP can be written very well and very shitty. Those packages should show we are capable of writing good code.

@Hel8y I'd like to work in a place like that. 🤣