9
abbabon
2y

Writing a feature critical for production in 2 hours of solid focus during the morning.

6 hours later it's still not in the build because:
* tech lead wants the code to move to a partial class instead of an extension method, delaying the UX review. No guidelines for this ever existed.

* after seeing the result, the UX team wants some element to be dynamic. A line. A friggin horizontal line.

* after adding the dynamic shiny frigggggin line, I try to test the feature with the server. It is still not deployed because the server guy went home. "The PR was not merged so I assumed we'll add it tomorrow".

Another day at the meat grinder.

Comments
  • 2
    If it's a critical fix then the UX team shouldn't even get a look at it imho. I can understand code quality reviews still as it's easy for crap code to make it in there otherwise, but not just making up random code style preferences...
  • 1
    yep, sounds like 'critical' isn't really that critical. and speaking from 10+ years of experience, 99% of the time it never is.
  • 1
    I feel your pain bro, especially the first point. OOP has pushed many programmers to overly engineer their code adding pointless layers of abstraction. That wouldn’t be a problem in a solo project but when you spend more time discussing where to put a damn function than implementing it something’s wrong.
  • 1
    @DEVil666 - man, are you me? I worked on a small team and we basically ended up having to delay every project 6 months+ just to have super level abstraction and "clean code" - when ultimately it wasn't used by the end client anyway. sheesh what a waste
  • 1
    @fullstackchris it seems we’re the same person when on my last retrospective someone raised the point that we should follow “clean code” principles more (and it wasn’t the first time, in the meantime layers of abstraction piles up turning the project into “lasagna code”) I considered to hire an hitman to shoot “Uncle Bob”
  • 1
    @DEVil666 - to me clean code is secondary. it sounds weird almost for me to see myself typing that, but if customers / clients are dying for a feature, just implement it in the simplest and fastest way possible, even if you have not 100% perfect practices. they'll be way happier and you will too when you can clean it up on your own time. especially for one off features, clean code really only helps for a feature that may grow to higher complexity. that's what I've learned from taking the hard road one too many times
Add Comment