6
iiii
3y

How to get a fast MR approval 101:
Tell the reviewers that you've had a trivial merge conflict due to other colleague adding unit tests in the same file as yourself, which causes the approvals in Gitlab to vanish.
They assume they had given the approval previously and just push the button.

Comments
  • 0
    My favourite is to get them to approve a trivial change then hammer in sixteen more commits before clicking merge.
  • 0
    @irene won't work. Changes void the approval
  • 0
    @iiii Oh what? Not on our Gitlab instance. It stays approved unless someone revoked approval.
  • 0
    @irene if there was any change in commits except automatic gitlab rebase, the approvals are void 🤷‍♂️
Add Comment