Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
Hazarth95031yYou can only update comments within the first 5 minutes or so. Is that what you're talking about?
-
KDSBest7751yIMHO
A comment like:
// Compute Singular Value Decomposition
// This an inefficient way to do Pseudoinverse, but it is convenient since we need SVD anyway
Is awesome.
A comment like:
// Traverses Array
Is garbage.
I know one person, who develops everything by comments and fills in the code later really simple code most of the time like.
// check if flag is set
if(entry.Flag)
{
// unset Flag
entry.Flag = false;
}
I told him hundrets of times. This is fine if it helps him coding but for the love of god remove the obvious comments afterwards. -
Parzi88331ythe fun part is i can always reach into my personal project folder for examples of ancient, stupid comments made in anger, but for trivial programs and things i'm throwing together for convenience. for example, finding a try-except block in a python script that starts with
`#i forgot why this try/except block is here but i'm gonna assume "because Windows"`
is usually a bad sign.
i wonder how these line up with projects in companies. -
KDSBest7751y@Parzi a good PR culture asks about the try catch and since you had purpose you justify it with a comment. If the other PR Person asks for a comment, makes sense to add one even if it is obvious to you. Or blame on git and check what commit lead to this. If both don't help you are screwed on big projects which lead to untouchable or alot of testing involved scenarios.
We are not allowed to commit anything without a ticket and server hooks deny a none ticket number commit PRs. So you squash, rebase and then you do the PR.
If you hate my comments or u don’t want to update them, just fucking delete them - idgaf it’s not like I’m trying to help everyone have an easier time or anything
rant