1

I hate with a passion Code Review sessions in Pull Requests. It takes days to get approved especially when you have as Lead tech someone with 3 years of experience that rejects PR because doesn't like how I named the variable and also if that person is different time zone.

In my previous company we used to have 30 minutes session if we had PRs and we would go over it.

Comments
  • 1
    Reminds me of this
    I feel like some people have completely twisted priorities in code reviews

    https://morling.dev/blog/...
  • 0
    @LotsOfCaffeine On Code Review sessions we would review other devs Pull Request. We did not have every day PRs so if some developer wanted to discuss other stuffs such as code style docs etc we would. But meetings would not go over 30 mins.

    As per learning and docs, instead of “Happy Hour” BS meeting every Friday (which failed and no one attended), the Director of Engineering though to do “Lunch & Learn” for devs. We would learn new stuffs that are coming out in Python or other techs. Encryptions, etc. It went on for 5 months until i left.

    One of those sessions was code clarity and how to fix a project that ha spaghetti code while enhancing as well.
  • 2
    It’s annoying but names are important.
Add Comment