19
Synster
6y

Tried refactoring working legacy code :(

Comments
  • 0
    That's no sin. Lacking test coverage is.
  • 1
    Can be a good learning experience.
  • 0
    @CWin it was.
  • 0
    @k0pernikus did that at a bad time actually broke the code, had to delay timelines
  • 0
    @Synster So comming back to my question: how much was the test coverage? Did your breaking change also break any test?

    If not, I still don't hold you responsible.

    With hindsight, it's easy to say that "this refactoring was not needed", yet at the moment it made sense to you and might have been a good thing in the long run.

    And delaying and postponing timelines is one my favorite activities. People like to confuse wishful thinking with proper estimates.
  • 0
    @k0pernikus Agreed, Didn't break any test in the immediate application but one isolated use case in an another application not covered in test.

    But all that doesn't matter when you broke something that was already working as per PM.
Add Comment