Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
@g41j1n that's definitely not a "senior" level answer.
Commented code has nothing to do on the master branch. I can understand the value of Just commenting stuff out for Testing and development. It's very sligthly faster than reverting or looking for past git changes. It's even a bit more convenient than stashes. But realistically when I know merge is going to master I come down on that shit like a hammer. Delete it, it only serves to scare and confuse junior devs -_-
I think code should never be a personal "my baby" kind of thing. Reviews are a great thing and code should always evolve with the project :/ -
senior devs there are lazy and mad at your for forcing them to think.
you're going to have to either tow the line or leave. sometimes you can convince the team at large to devote time and effort to fixing and improving things but this can be difficult. it's going to require some finesse and patience on your end either way
Little bit of background I've been a front end developer for the past eight years not a good one but I get by. Last 4 working with consulting firms for fortune 500 clients. Big projects big plans big structure, following someone else's lead and just knowing the basics of code reviewing, git flow, code deployment and everything else... life happens and i end up as a front end developer for a big company not tech related that wants to depend less from consultants and do more in house dev. Seems a pretty straightforward project front in angular. Back on python doing queries to a database with sql server. I finish the on-boarding and after two weeks finally get access to the repos. Worst spaghetti code I've ever seen. Seems like someone took a vanilla script project from 10 years ago and push it into an angular tutorial project. Commented code, no comments for the code, deprecated functions still there, no use of typescript nested ifs hell. I try to do my job doing new features do comments clean up a bit. Senior developers get annoyed
rant