3
sjwsjwsjw
109d

- divide large refactoring and architecture changes into multiple small pull requests

How do you go about getting code reviews? Wait till you have all the pieces so people have the big picture?

Comments
  • 3
    Very hard to do right.
    Start with a small simple change - like adding an abstraction, or a few tests. Then refactor the logic, using the abstraction and tests.
    Work up from there.
  • 2
    Multiple small PRs are created for the reason that changes should be incremental, making sense, and reviewable. Waiting till the end to get the final shape only delays the disaster
Add Comment