Learn More
Resend Email
64
pez-dispenser
7y

It's disheartening to see a senior member of my team shitting on the code of less mature developers. Don't just say "this is unacceptable", elaborate, teach them. How are they going to action anything from that feedback?

Take the time to respond to their questions when they ask for clarification on what you're saying. Don't berate them.

Honestly some developers need to learn a thing or two about code etiquette.

There's no room for good cop / bad cop behaviour.

rant

code_review etiquette
Favorite
Ranter
Comments
  • 11
    7y
    Amen brother.
    In the long run this even costs productivity because the unexpierienced won't dare to ask a question. Hope you'll get out of this hostile environment sooner or later.
  • 6
    7y
    @Terrestrial That's what I'm worried about. We just had a grad join the team and if the comments I saw today were on her PR I'd have to say something.

    The rest of the team are great though and less "critical".
  • 4
    7y
    @1989 what you described is what I expect from a senior dev so good work! Would definitely want you on my team!

    Unfortunately in this case there was very little guidance and I don't believe the mistake was obvious (another developer had approved the PR).
  • 6
    7y
    @1989
    I have heard that it's good to let juniors read senior code. As a junior you see "more mature" way of getting things done -> you learn a lot. Also, if the junior doesn't understand something, it might be a good idea for the senior to rewrite it clearer as senior might develop some unhealthy tendencies over time (write working but obfuscated code as it might save a few lines).

    Would love to be a junior under your wings :D
  • 1
    7y
    So I had this junior dev who never delete but only comment unused code, leaving files with ugly large chunks of grey texts unable to read/maintain by any human being. I tried hint/talk/delete/rewrite, I think I’m about to bad cop then finally show the door.
  • 1
    7y
    I wish some devranters would understand this too -_-'
  • 1
    7y
    @cyanly I used to have this habit although I tried my best to hide it. I think it's the same as keeping back ups in their minds.

    Do they know about git ?
  • 1
    7y
    I personally really enjoy the mentoring aspect of working in a team, I think there’s a time and a place for the ‘sink or swim’ approach, but only if it’s constructive and help is readily available if it’s really needed.
  • 0
    7y
    @1989 well said
  • 1
    6y
    Exactly. I live by this shit every day man. Rather than pounce around like some untouchable cyber god/know it all it is better to make everyone in the team better. Less hassle in the long run.

    And what did 1989 say? I can't see his comment.
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment