11
Crost
6y

Story about my old boss:

I was doing a lot of work in an area that had a data property and a method to build an object. I noticed a reset method that iterated all that objects properties, found the matching data from the data object, passed that data through some logic to format it and then assigned that value to the object property.

As part of my PR I removed that method, since data wasn't changing, and simply called the create method again with data.

The result of tidying the code base and putting it up for review before a merge? I get told I have no respect for my boss's code, that I am undermining him, that I need to be more considerate and respectful of other people's work and that I am no longer allowed to change any code he has written in the code base (half the code base) without talking to him about it first, before it goes up for review. Also if he is working on an area I cannot change anything - not even 1 character (he is working on the core of the app).

Every day there I was so confused :D

Comments
  • 0
    Gotta love those insecure dickless morons. Good thing you moved away
  • 1
    @2lazy2debug about me leaving? Nothing as I left when he was away - dick move but he holds grudges so I'd totally given up on the job.
  • 0
    @2lazy2debug
    About me disagreeing? ended on me bringing up that he had broken the test suite compiling and that he wasn't checking in tests with his work - ofc worded like "you, myself and the whole team aren't doing that - not really talking about this instance at all - just wanted to get confirmation of what we are doing as it's what I would prefer but if you want to think about it I'll not bring it up again as I know it's not my decision".

    I don't really care who does what or blame anyone for anything - still maybe I'm to blame for how I talk.

    Anyway

    Boss: we have a problem
    Me: oh - sorry what is it?
    Boss: your too forceful about the tests
    Me: I didn't mean anything in a bad way
    Boss getting louder: youre being too forceful
    Me: but I didn't mean anything negative
    Boss almost yelling: I didn't add tests because I didn't want to or intend to so don't tell me that I should
    Me finally annoyed: why add tests at all then?
    Boss: I'm not having this conversation - storms out of the room
  • 0
    @2lazy2debug thing is he asked me to fix the tests he broke, I said ok, I found 30 tests failing because of a 5 character mistake in a constructor he had changed so I fixed that. We use git so a merge conflict will be easily resolved for something like that so it didn't dawn on me he wanted me to go that far.
  • 0
    Obviously I have a lot of salt in me ;) sorry
Add Comment