I tell him to submit a pull request, he just merges his code. I revert it and tell him to submit a pull request, he submits one then merges it himself immediately after...

Well, that's why you use protected branches...

@cgomezmendez how does that work if you're supposed to do peer review? I'm having a similar issue at work (guys are pushing straight to master and self merging because they don't want to go through the review process) but currently we all have commit access because they're supposed to review and merge my code and vice versa.

@HollowKitty Depending on what you use for versioning.

At my workplace we use a self-hosted version of Bitbucket (OneStash/ Verizon's Bitbucket) and what they do is they have it setted so nobody can push directly to master branch

https://blog.bitbucket.org/2013/09/...

Also to be able to merge a pull request we need at least two approvals from of code reviewers of the project, depending of the project.

https://confluence.atlassian.com/bi...

@cgomezmendez ahh 😍 I don't think we have the political capital to enforce something like this right now but I'll definitely keep it in mind for the future...

Why didn't you thought him the meaning of pull request when he merged for the first time??

Merge all you like if you can show me:
* 1 successful build by the CI system
* 1 approval / lgtm from a reviewer

Anything less than that is insane.