Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
Working with a team of interns, pointed out a bunch of unit tests are failing, they said they would take care of it.
10 mins later they opened a pull request to delete the tests that were failing.
fml, fml, fml, fml ... and ... oh yeah fml10 -
When you've been getting lots of comments on your pull request and have to keep asking for approval.
7 -
I just made my first pull request to an open source repo on github 😊
Just some tiny improvement but still I'm geeking out right now🤓5 -
Apparently this guy's pull request claims that his code is "very fast" (Official Linux github repository). I can't stop laughing looking at the file changes xD
File changes: https://github.com/torvalds/linux/...
Conversation: https://github.com/torvalds/linux/...
8 -
A guy who doesn't work on our project anymore, but still checks on us regularly just did this:
- reported a bug
- started explaining what's causing the issue
- realised the problem was in a piece of code written by him before
- fixed his own mistake, committed it and created a pull request
We all had a good laugh.6 -
Found a private api key on a github project. Created a pull request with key changed to “TH1S5HOULDB3SECR3T!iMBECIL5“ comment was “security fix“ i wonder if they accept3
-
that moment when your first pull request to a major deep learning library is merged and you have no friends who understand what that means and to share your happiness!😓
no problem, you've devRant! 😁9 -
Just received my very first pull request on GitHub. Pull request: "Remove jquery as dependency".
* Makes repo private *9 -
Developer creates pull request.
I hold suggesting changes.
Developer creates new branch and new pull request with exactly the same commit.
Another Senior developer approves pull request.
This will be discussed tomorrow morning!29 -
So my pull request got accepted from a minecraft mod on github, and I made it in to the changelogs.
Am I famous now?
11 -
Manager: "Pls deploy the changes ASAP."
Me: "Right away."
Me: *creates pull request*
... 5min later ...
GitHub: "Some checks haven't completed yet."
... 45min later ...
GitHub: "Some checks haven't completed yet."
Me: *looks into delay*
CircleCI: "Partial System Outage"
——
(╯°□°）╯︵ ┻━┻2 -
I sometimes wonder my English is that bad ...
I reviewed a pull request. I commented on this line of code
a = getA() * -1;
saying that
"I think this logic should be in setA method instead."
When the guy asked me for the review again, the change was
- a = getA() * -1;
+ a = setA() * -1;
...2 -
My computer science teacher won't stop developing on the production server 😭 he switches the branch on the production machine to dev all the time and merges broken code into master. Kill me4
-
That moment when u created a project and quite some folks forked it and continued their own versions, but then you realised that you've made a little mistake back then so now your dumb code propagated across humanity.
¯\_( ͡° ͜ʖ ͡°)_/¯2 -
Just did my first pull request for an open source project ever. And it actually increased test coverage for the whole project 😂2
-
Ahhhhhhhhhhhhh!!!!!!
A pull request I made to an actual open source project got merged. I might actually be a real dev now!
(It was just to remove a snippet config, but still!)7 -
I have a variable called 'stuff'. It's a test to see if my colleagues really read my pull requests.3
-
Since it is now the hot topic to talk about, here is my input.
The new python change is a terrible idea.
We should totally start a community python fork that stays 100% up to date with master, but removes that one pull request8 -
I tell him to submit a pull request, he just merges his code. I revert it and tell him to submit a pull request, he submits one then merges it himself immediately after...6
-
Indian web dev company (during the interview)::
We follow standards
Me:: Hey, can I get the project's github link so that I can fork it, do my tasks, run test cases, push and, make pull request that you can review, run integration test, and finally merge.
Indian web dev company:: What?? Here's the ftp credentials.
Me::
15 -
Oh no, oooooh nononono
they dont delete the branches after a pull request
232 branches? hhhhhhhhhhhhhhhhhhhno
and look at that naming
im intimidated, i dont want to work in this environment. No. NO!
8 -
Emotional roller coaster today.
+ Got first pull request! Hell yeah!
- oh, no, no no no nononono, they pushed all dependencies and temp folders...
fck sake isak, gather yourself
11 -
1. Put headphones
2. Put videogame OST (Chrono Trigger is the best)
3. Start Atom
4. Sacrifice a male virgin to my Code Muse to replenish her mana stock
5. Jerk off seeing a fat granny midget porn
6. Clorophorm and put my coworker to sleep so he doesn't interrupt me to show the FailArm best fails of 2016
7. Atom is still loading, so I curse all the GitHub fuckers
8. Give up and start my emulator to play Chrono Trigger
9. Receive a pull request and realise I need to work and be a productive member of society
10. Goto 110 -
WHY DON'T YOU FUCKING READ THE CHANGES IN YOUR FUCKING PULL REQUEST???
If you did, you would realize that 50% of the stuff is total fucking nonsense. I don't want to see that you changed "var a = 0" to "var a= 0" just because you can't type with your shitty fingers.
Also, if you did read the changes in your PR, you would have realized that you added a bunch of totally unrelated changes in totally unrelated files.
Fuck! Am I the only one who always tries to produce a clean changeset?? Damn5 -
I jump on an existing scala project.
git pull && sbt compile test
Tests are failing.
Me: "Hey team, the tests are failing."
Team member: "That cannot be. They were passing for the the last run."
Me: "Did you run them locally?"
Team member: "No, on Jenkins. It was fine."
I check Jenkins.
Me: "What do you mean it's fine. The last successful deployment was on the end of May."
Team member: "The Pull Request checker always went through successfully."
I check how our Jenkins tasks are configured. It's true that the Pull Request Checker runs successfully yet due to a "minor misconfiguration" (aka "major fuckup") the Pull Request Checker only tests a tiny subset of the entire test suite.
Team members were were fine if their Pull Request got the "Success" notification on bitbucket's pull request page. And reviewers trusted that icon as well.
They never checked the master run of the Jenkins task. Where the tests were also failing for over a month.
I'm also highely confused how they did TDD. You know, writing a test first, making it green. (I hope they were just one specific test at a time assuming the others were green. The cynic in me assumes they outsourced running the tests to the Jenkins.)
Gnarf!
Team member having run the tests locally finally realizes: "The tests are broken. Gonna fix them."
Wow. Please, dear fellow developers: It does not kill you to run the entire test suite locally. Just do it. Treat the external test runners as a safety net. Yet always run the test suite locally first.4 -
Right, you pesky type initialization bug, I'm gonna find you. Hiding by throwing your exception in an external library won't help you. I'll download the sources, library by library, and look for you there too.
I *will* track you down, bastard, and exterminate you locally. Then, I'll make a pull request and kick your sorry ass off GitHub, off the internet and off the bloody surface of the earth. Oh, you have no idea how dead you're going to be when I'm done here!2 -
Why would you submit a pull request with the addition of such a comment and expect me to approve? What the hell is wrong with you?
-
A badass pull request review comment: 'A wise man can learn more from a foolish question than a fool can learn from a wise answer.'2
-
[ Coworker walks up to my desk at 4:15 PM ]
Coworker: "Hey man. We had to make a few changes to the codebase because one of our unit tests were failing. Can you take a look at a pull request for me?"
Me: "Yeah sure, how many files?"
C: "About 600"
Me: [ thinking it might just be a ton of libraries or gradle shit] "...ooookaayyyy... that's a lot but doable... how many lines?"
C: “128,000 lines"
Me: "Fuck you"11 -
This one time I developed some useful plugins and a command line interface for the platform we built at work.
Then when it was done I thought it had some good value so I created a pull request to donate it to the platform. That same day I got 3 complaints that my pull request did not conform to conventions and that there was no ticket for it and they complained about the fact that it made their jobs harder.
It was in fact the last time I developed something for work in my spare time.1 -
Dear external developer dumbass from hell.
We bought your company under the assumption you had a borderline functioning product and/or dev team. Ideally both
For future reference expect "file path" arguments can contain backslashes and perhaps even the '.' character. It ain't that hard. Maybe try using the damn built in path parsing capabilities every halfway decent programming environment has had since before you figured out how to smash your head against the keyboard hard enough for your shitty excuse of a compiler stops arguing and gives in.
I am fixing your shit by completely removing it with one line of code calling the framework and you better not reject this.
This is not a pull request ITS A GOD DAMN PULL COMMAND.
- Is what i would _like_ to say right now... you know if i wouldn't be promptly fired for doing so :p
How's you guys friday going?8 -
Contributed to a open source project for the first time what hasn't been updated in 3 years and my pull request was just accepted!5
-
Today I had my first decent pull request accepted.
It wasn't the biggest problem, but it made a chrome extension not work, and the author and other users couldn't figure it out.
The author seems very chill and called me 'the man' and offered me a drink.
It felt nice.1 -
Submitted my last pull request, said farewell to my team today... *weeping*... haven't realized it would be so hard. Oh, well, best of luck my friends, and keep my code running ;)4
-
Sex feels good and all but have you ever felt the pride of submitting a bug fix to software you use on GitHub?4
-
Slack Boss: hey, could you check work of dev that is okey, we want this update fast.
Me: hey, just tell him to open PR and assign me, I will check and merge changes.
Slack notification: Dev: Hey, could you please merge Pull request on the project ?
Me thinking, hmm weird, I didn't get email.
Checking github, 0 pull request.
Me: hey, I don't see any pull request open, and when you make pr, just assign me I will merge it right away.
Dev: takes half a day
Dev: Makes pr and assign correctly me.
Dev on slack: HERE is PR open now @me.
I get 3 notification to see this PR, sure at least it is there.
I check this PR, 50 commits, X conflicts, cannot merge this.
Me: Hey, @dev please fix conflicts in your PR.
DEV: takes another 2 days to respond.
Boss in the meantime: hey, have you pushed those new changes ?
Me: I am waiting for conflicts to resolve.
Dev: I fixed the conflicts @me.
I check the PR conflicts are there.
Me: are you sure you pushed your changes @dev ? I don't see them resolved
Dev: takes another day and pushes changes to resolve conflicts.
Me: merges PR to master becaus he based it on master, I will sync the developer branch myself.
All good, everybody happy.
I write to dev: Next time base your changes on develop branch and resolve conflicts before making PR.
Two weeks later new PR From this dev.
Based on Master, conflicts everywhere.8 -
Everyone complains that a certain developer's code is not up to standard and when they have to take over his project the lack of code quality is really slowing them down.
I look at code, agree it is poor quality and put together a learning plan for said developer.
Also look at who approved every pull request which allowed bad code into our codebase. Same developers as those complaining it's no good. You had your chance to stop it!9 -
#prank
New guy on the team, learning WPF.
He forgot to lock his computer when fetching coffee. I added a transform group in the main window and checked it in to Git. Locked the computer.
He comes back, furious at his computer for turning the application upside down.
Next two hours he was rebooting, flipping the screen, stressing, googling until I finally had to confess.
He uttered a strange sound of short burst of laughter concealed in a relief of not going insane.
It was a good day.
His pull request was rejected.2 -
Top 10 Signs You're Approaching Dev Burnout (incomplete):
(?/10). You get these random silly urges to quit your job to go live on a farm and raise goats, never to look at another pull request/bug/network issue/DevOps dashboard again8 -
Let me make a small change to this file, a one-line pull request will probably be accepted right away
* saves *
Prettier runs...
EsLint runs...
StyleLint runs...
60 changes submitted for review11 -
Please, stop being afraid of git rebase.
Please stop merging master branch into feature branch just to fix pull request conflicts.2 -
If you're going to request CRITICAL changes to thousands of records in the database, and approve it through testing which is done on an exact replica of production, then tell me it was done incorrectly after the fact it has been implemented and you didn't actually review the changes made to the data or business logic that you requested then you are an idiot. Our staging environment is there to ensure all the changes are accurate you useless human. Its the data you provided, I didn't just magically pull it from thin air to make yours and my job a pain the ass.9
-
I started a new project with a backend guy and another frontend like me.
This other FE is 35 years old.
He told me he works as Technical leader before.
This was his first PR ...
8 -
Friend of mine: so I wonder how do you test your applications in the startup?
Me: testing? *grabs his coffee laughing*
Actually we have a complete build pipeline from commit/pull-request to dev and production environments. No tests. Really. We are in rapid product development / research state.
We change technologies and approaches like our underwear (and yeah, this is frequently). If we settled some day and understood the basic problems of the whole feature palette, we'll talk about tests again.3 -
It's 35 degrees. Reviewing pull requests or finding a beer garden was the easiest decision of my career.8
-
How the hell does PR containing production secrets and private keys gets 3 approvals and gets merged upstream? 😬 🥴6
-
I've been neglecting my 150 stars github library for the past month because I don't have time... Feel bad about it (9 open issues 1 nice pull request and one behind example library)2
-
Hello world!
I wrote my first own contribution, pushed, made a pull request and merged to master today all by myself at my trainee job!
Success!1 -
Today I found an error in how we handle credit on invoices in our software.
This is the first time my boss has ever made a legit pull request for me to review of his.
Damn I feel proud!1 -
Time to do a little bit of shaming:
I'm specialized in e-commerce applications, mostly based on Shopware, a german out-of-the-box online-shop. They essentially claim to be a better Magento. In December of last year I found a critical issue within the code. Products within the shop can be declared as digital wares. In that case the purchase of a product will unlock the possibility to download a designated file.
As a customer you can access your downloads within the account section. Now here's the problem: The query that fetches the unlocked downloads for a customer is hard-capped at 500 rows. So after your 500th purchase, you won't be able to access any further files you paid for. Essentially their developers thought that this limit would never be exceeded anyway and called it a day.
Personally I think this unacceptable. For the merchant this is a potential law-suit in the making. So I took the time to refactor the code and fix the issue. The corresponding pull-request was flagged as scheduled back in December. Since then there have been numerous releases and the issue is still present. Not only do I ask myself why I should ever put in time and effort to fix their code again, but I also can't believe that they just chose to ignore the issue completely. Also mind that this is not just a small or non-profit open-source project. The responsible company behind the software is a stock corporation that claims to be the market leader in Germany.
5 -
Looking through our gitlog today and see 3 PR's from our "lead developer". 2 of these were removing a single blank line from a class, and the 3rd was adding one back in. None of these had any title or commit messages on the PR's. This is a guy that talks down to everyone and deliberately makes other devs feel insignificant, saying he's too busy to write documentation and it's not needed because his uncommented code is self documenting. But hang on he's not too busy to waste time with pointless non-functional PR's that only remove a couple of blank lines? Scratching my head in disbelief that some devs think they can get away with shit like this. How about you drop the ego and actually try and work in collaboration with the other devs.2
-
FYI rambox users: My pull request got merged and as of version 0.6.0 devRant is now one of the pre-configured services 🎉2
-
When your devs comment their pull request "fixed" but fail to push the fix to the remote... For the 5th time in a row. 💩😒
5 -
Colleague: Hey could you review this diff?
Me: *opens Bitbucket*
Bitbucket: "Upgrade to Symfony 5", 19 files added, 732 modified, 14 removed
Me, 3 mouse scrolls and 20 seconds later: ✅3 -
CAN SOMEONE PLEASE TELL ME HOW TO TRANSLATE PULL REQUEST TO GERMAN?
According to one of my teachers I have to translate this in a coding guideline otherwise other devs might not be able to follow the procedure...
I asked him how he would translate it and he could not give me a proper answer... describe it he said...
How the fuck does it improve my guidelines if I describe PR!!!
And if your not capable of doing it better how should I know I have to do it!
Sorry I looked at an old exam and got triggered when I saw the correction21 -
Gonna make a pull request for Project!
"How to Project:
npm install
npm test
npm run start"
npm install: warning, warning, deprecation, warning
npm test: 30 tests, 15 failed
npm run start: error, C stack trace
Pull request status: on hold4 -
So I was told why a bash with Git isn't allowed in my company.
The people that built the development kit (IDEs, tools, etc) estimated that Git wasn't necessary since integrated in Visual Studio.
They clearly never tried to do a pull request or a rebase then. Good to know.
(a coworker gave me a way to have a bash anyway, so that made my day \o/ but rant needed anyway) -
Building a pull request on our Build Server takes 14 hours, it can do about 10 builds at a time and there are already 26 builds in the queue and it isn't even 10am.
I've been waiting for a build since I queued it on Friday - because the queue is actually a stack.
And management / senior developers are like...
7 -
I don't know if you are called the same on Github and DevRant, but thanks for giving me my first pull request @Paradoxis. I already learned a lot from it.6
-
Co-Worker laughed at me for taking a task on their side project and only them have worked at it. FYI i've never worked as a Dev before and I have a really low knowledge of web developing. Well i finished the task in time and sent the pull request to one of them. Got a 'well done dude, high five'. Feels good man :)
-
So, I got a ticket to make a page using a given wireframe that had submit buttons and other buttons to add more items in the wireframe.
So, I pull the html, hook up the abilty to submit the form and add items, and send it out for review.
One comment on the review.
"Remove the functionality, you'll handle it in the next ticket"
So I commented out the javascript. Guess what I'm doing on the next 10 minutes.1 -
Had a five hour long debate with one of our Senior Developers today about pull request etiquette.
His view was reviewers should always email or call him before adding comments to any of his requests and they should never block them as he should be allowed to code in "his own style" and should be able to approve his own pull requests.
I explained that we have code standards and an agreed PR workflow be needs to comply with.
He then started talking about meteors and plane crashes. Literally no helping some people.18 -
Damn it! today I learnt that GitHub has a tool called Hub - "an extension to command-line git that helps you do everyday GitHub tasks without ever leaving the terminal".
It's been around for 10 years.
And here I was clicking on the link that was sent by the remote after every push to open a pull request 🤦♂️
It even comes with vim syntax support for pull requests.
I'm never leaving the terminal to do things on the GitHub web interface anymore1 -
WOOO THE NEW YEAR IS GOING SO WELL!
I just published my first pull request to someone else’s repository WOOOO5 -
Scumbag BroCow
Uses github to store his family photos
Uses github as a media streaming server
Conceals the repository by a random name.
Ignores pull request and issues made by haters1 -
I was asked to fix a critical issue which had high visibility among the higher ups and were blocking QA from testing.
My dev lead (who was more like a dev manager) was having one of his insecure moments of “I need to get credit for helping fix this”, probably because he steals the oxygen from those who actually deserve to be alive and he knows he should be fired, slowly...over a BBQ.
For the next few days, I was bombarded with requests for status updates. Idea after idea of what I could do to fix the issue was hurled at me when all I needed was time to make the fix.
Dev Lead: “Dev X says he knows what the problem is and it’s a simple code fix and should be quick.” (Dev X is in the room as well)
Me: “Tell me, have you actually looked into the issue? Then you know that there are several race conditions causing this issue and the error only manifests itself during a Jenkins build and not locally. In order to know if you’ve fixed it, you have to run the Jenkins job each time which is a lengthy process.”
Dev X: “I don’t know how to access Jenkins.”
And so it continued. Just so you know, I’ve worked at controlling my anger over the years, usually triggered by asinine comments and decisions. I trained for many years with Buddhist monks atop remote mountain ranges, meditated for days under waterfalls, contemplated life in solitude as I crossed the desert, and spent many phone calls talking to Microsoft enterprise support while smiling.
But the next day, I lost my shit.
I had been working out quite a bit too so I could have probably flipped around ten large tables before I got tired. And I’m talking long tables you’d need two people to move.
For context, unresolved comments in our pull request process block the ability to merge. My code was ready and I had two other devs review and approve my code already, but my dev lead, who has never seen the code base, gave up trying to learn how to build the app, and hasn’t coded in years, decided to comment on my pull request that upper management has been waiting on and that he himself has been hounding me about.
Two stood out to me. I read them slowly.
“I think you should name this unit test better” (That unit test existed before my PR)
“This function was deleted and moved to this other file, just so people know”
A devil greeted me when I entered hell. He was quite understanding. It turns out he was also a dev.3 -
I made my very first pull request to a project of public interest.
It's just a paragraph in the React docs, but still.
I feel like a useful person.11 -
Most incompetent coworker of the week made a pull request, title: "Adding secrets.ini needed to run $app."
He just copied it from the server and removed the `*.ini` entry in the .gitignore. Luckily he only had access to the dev instance (to copy passwords from). -
I just received my first pull request today.
It wasn't what I wanted, expected, or hoped for.
It was a full-on codebase rewrite.4 -
All bugs in Linux kernel removed . for more info check pull request at https://github.com/torvalds/linux/...
3 -
Another pull request for Ressurection Remix fixing a huge issue with 1 character change.
It helped a lot of people.
I have the good feeling when you help people. Oh i love it.
Also IDK but apparently lot of people with lot of stars started following me for no fucking reason. WTF is going on ?
I didnt touch github in few months and 2 follows.3 -
Me: Is git male or female?
Friend: male.
Me: why?
Friend: it does all the pushing and pulling!
Me: Really? I think we push and pull into git.3 -
Submitting a pull request seems a good way to end the week. That's what I love about (some) projects on GitHub; instead of just ranting about bugs or out-of-sync documentation, you can fix the problem and send a pull request upstream. :-)2
-
New pull request rule:
If there are more comments than actual code... REJECTED
Nobody wants your novel on how you came to the conclusion that "_canHazStuff()" is the best possible name for the method.5 -
Why won't you just approve my PR???
Whats wrong with you?!
I don't understand your cryptic one-sentence feedback. I'm not even sure you understand what you're asking yourself.
What the hell does "make it a transaction" mean? Don't give me pseudo-code examples that don't even work fucking asshole!
Its a small change that does NOT need a canary build dammit. Don't go testing the ORM, its a goddamn standard library. Why does working with you make everything so complicated?!?!
The code fucking works! There is no need to make it comply to your specific tastes goddamn it. Working with you is like pulling teeth!
/endrant9 -
Git on Visual Studio is so dumb
I wanted to do a Pull Request, and when I checked the request, a conflict prevented from auto-merging and ask to resolve it in Visual Studio.
"What conflitct ?" I asked.
"You're on your own, fam" Visual Studio answered.
Real sweet.3 -
For a long time, I wanted to be a part of open source communities. I've been a dev for 6 years now.
I have the skills needed to help out but usually I'm fairly unexperienced on working with big teams, code reviews, and build-test systems they often use. So I'm scared as hell to even begin with. I feel unsecure to reach out and ask for helping or send a basic fix / pull-request.
What are your suggestions, how did you start working on open source projects?
Teach me senpai.3 -
Code review, intern style:
Intern: Here is my pull request ...
Colleague: I see a problem with x, y, z. Could cause memory leaks.
Intern: Oh yeah you are correct, i'll fix that in the next one.
Intern: *merged* -
I once made a pull request fully aware that 3 tests were failing. The PR was approved and merged.
In my defense, they were very complicated tests and I fixed them a few days after.2 -
Had a guy put in a pull request with an empty file diff. He comes by two weeks later and asks when am I going to have time to review it.
-
Today I had to teach a product manager how to use git. It took about 30 minutes to create a proper pull request. Then another 30 to update it when he fucked the change up.
It was a one line change...needless to say I was internally screaming after the first 10 minutes.2 -
>Be me
>Decide to contribute to an open source project for the first time
> Nothing big, just a simple compile error fix
>Make first ever pull request
>Over weekend pull request accepted
>feelsgoodman.jpg
>Take a look at recent commits
>Module I tweaked was finished in a commit 6 hours ago
>Fix no longer relevant
So close.. :(3 -
A dev joins the project. I help him set up, and he has everything up and running. I give him a task to fix a CSS issue, I even tell him what needs to be done. Almost 4 hours later I begin to wonder what's taking him so long and what is he up to. He finally sends me a pull request with just one line of code changed, and leaves for the day, over 45 mins earlier than supposed to.12
-
Reviewing the code of my then new CTO, who said "I can also code and have experience in Java" - 50 lines of code, I added over 30 comments to his Pull Request. In the end, I rewrote his complete code.2
-
Day 1. Push branch. Make pull request😀
Day 5. Got reply to fix some silly stuff🤡
Day 6. Apply changes. Ask for review again.😊
Day 7. Needed to work for another project for two weeks🤝
Day 25. Came back and pull request and branch were deleted from server 🧐🧐
Day 26. I merge my local branch copy into master and push it to server. So long bitches! 💅💅6 -
Today I solved the problem assigned to me by changing one character. Simplest fix ever. Except that this problem is not on my project, and I don't have control over this project, so I can't merge my pull request or deploy the code, and the dev that does hasn't answered email today, and he's not scheduled out, and he's not in his office. Whatever, I'm just gonna say it's fuck it Friday and call it a week.1
-
🐙/* Friendly reminder */ 🐙
Don't forget about Hacktoberfest, a great way of giving back to the open source community 👨👩👧👦. And remember, if you create at least 4 pull request you'll get a t-shirt! 👕👚4 -
I was thinking maybe I could learn Swift. Then I saw the accepted pull request about deleting i++ and i-- operators...
Seriously wtf, i mean OK setting them as deprecated, but deleting ? Dude no3 -
Every fucking day I'm asked some fucking stupid question that could have been easily figured if this fucker took 2 mins to look.
"Hey why isn't the issue closed with your commit message? Is it because the CI fail?"
No you dipshit. It's because it hasn't been merged into the master branch. And no the CI didn't fail. If you took 20 seconds to actually look into the pull request you'll see it passed.
God why? -
Yesterday
Me : Hey, I'd like to do a pull request, but there's something that might not help, you think you can help me solving it before I finish that task ?
Worker : *no response at all*
Today
Worker, by mail : Hey could you do a pull request ?
Me : ... 凸(⊙▂⊙✖ ) thanks for answering my question, edgy bitch1 -
!(isRant(thisPost));
Submitted my third pull request today in just a couple months as an intern, got told I'm doing a great job and already being considered to move to a more in depth dev team. Honestly a dream come true. Great company, great people, and I have a solid shot at a REAL full time dev position after college. I'm so happy man all that work finally paying off. -
Working for a company with solid procedures really makes me appreciate how important they are. Knowing someone will be scanning through my pull request made me *really think* about appropriate layout and commenting. Before I could submit any old code and the other programmer wouldn't give a monkeys.
I guess that's a poor reflection on my performance but, I'm working on it -
Do not, I repeat... DO NOT approve a pull request that you cannot adequately review. You're more to blame than the person who wrote the code in the first place when it fails.
-
Teacher in college:"Comment EVERYTHING"
Lead dev doing my pull request:"Why is there a comment in your commit!?"4 -
Trying to resolve merge conflicts and you cant remember which changes are the ones you want to keep. Lesson learned, make sure your pull requests dont sit waiting for weeks while master is happily being worked on.2
-
When it comes to nervewrecking situations, what I've encountered so far is a pull request for which the 2 reviewers had opposite opinions.
Something like this:
* opens pull request *
reviewer 1: "update using approach A"
* updates code *
reviewer 2: "this is wrong, change to approach B"
* updates code again *
reviewer 1: "this isn't what i asked for, i'm rejecting your PR"
Oh, also, each of them had their own set of coding standards.
What was your most challenging situation when writing code?1 -
That feeling of giving birth to a child, when the pull request on which we are working for a week is finally merged into master. 😂😂
-
PR used to mean public relations to me few months back. Now it just means pull requests to me.
The fuck happened. Anyone says we need to improve our PR, I'm like how do you improve a pull request and I end up face palming -
Finally pushed all review changes to that GitHub Pull Request of mine that had been open for months!
Hopefully it will get reviewed soon with possibly very minimal to 0 changes and then merged!!! :D
2 -
Achievement of the day: breaking GitHub doing a forced push.
(Apparently I was able to create a kind of ghost commit that randomly appeared and disappeared from a pull request, plus other random errors 🤪)
3 -
Not to burn professional bridges every time I have to review a pull request, not the biggest challenge but the one I face more often.
-
The last communication we had was me asking you if you would like a service for that, with no response? And now, ten days later, you’d like an update on when it will be available?
Well I raised a pull request on your side a week ago, your developers have just been ignoring it.
What? No, I don’t know when it will be merged and ready. -
I hate how most people here don't have their Github on their account profile. How am I supposed to push request a new file for your repositories saying "Gustash was here!"?3
-
Hi guys, I’m that good guy MIS who knows a little bit python and got “promoted” to write a warehouse management system in C#, which I have never use it before.
Just now I submit my first pull request to DevOps and got accepted.
Just a small EF core and barcode generators stuff but I’m so glad I made some progress 😬3 -
When you're trying to climb the commit leaderboard and the lead developeor squishes all the commits in your pull request into one :<4
-
Recently graduated and in a job. Had a pull request merged with no comments or changes asked for by the code reviewer today. It's the little victories.
-
When someone actually commented on my pull request, rather than just clicking approve without reading it.
-
That feeling when you're finally done with a pretty big PR and ready to go live. You excitedly send it out to a few of your peers, and then... 20 comments! The real work has just begun 😭1
-
Hardest thing for me as Team leader is to teach people in my team, that task is done, when unit tests are written, pull request is created, approved and merged.
Not when their code compiles for a first time.1 -
Another plug for my collection of free games.
https://github.com/kwilliams1987/...
If you see something you like it's yours for the low, low price of a pull request. -
"Sweet, I fixed story 1 and can commit! ...but issue 2 is pretty small, let me just work on that first so there's 1 pull request".
4 hours later, issue 2 not done yet, and I can't push push story 1 to QA until I finish it. I really need to stop doing that.4 -
Last year, this was in my news feed: https://lkml.org/lkml/2018/6/5/769
Will we ever see this Linus again after the COD bullshit?4 -
One thing I have truly learned from software development is DON'T REINVENT THE WHEEL. Someone out there may have already implemented such functionalities and if the library is missing something a PR is always welcomed! (Obviously taking about open source libraries)6
-
I worked as a freelance for a client and after working for more than a month, he owes me 1500$ and the payment was already due 15 days back
Today he even disconnected me on Skype which was the main source of communication
Now I want to undo my pull request which has already been merged in the master
I still have write access to the main repo, its on bitbucket
Is there any way i can destroy all my commits from the master branch or undo my merged pull so that he doesn't get any of the code
#helpwanted8 -
This is not a rant is more like a general question, first of all some background.
Some time ago I found this repo:
https://github.com/jwasham/...
A repo that list and link all the subjects you need to know with awesome resources to learn as a self-taught student. As the description says is a complete computer science study plan to become a software engineer.
I like the idea and I decided to help as I saw the Spanish translation was in progress.
Then I realized that it wasn't useful for real, as the resources still be in English so I made a propose that can be find as a link in the pull request of the project .
https://github.com/jwasham/...
But now the question :
Would it really be useful for some people to translate this?
I would greatly appreciate your opinion.
Meanwhile I'll continue with the missing with more coffee.4 -
I finally found something to rant about! So what happened is that I am participating in the Digital Ocean competition (I need to do 5PR's). So I find a report with a lot of scripts. I decide to contribute and write a discord webhook API (send messages through a webhook). The next day, the guy goes "No thanks :)" and closes the PR. Words cannot express how triggered I am. I ask him if I can make anything else out of exasperation (I did not intend to do anything for him anymore, I can't explain why I did that), he tells me no...
;(3 -
Contributing on github projects.
Especially when my pull-requests finally merged to the original master ^^ -
Issue about adding squash feature for git pull request merges on Bitbucket has been open for years...
Bonus level: you have to use Bitbucket
-
Pull Request Message -
Day 1: "Updates to the UI and the load performance of the page."
Day 127: "shdheiahwjak"6 -
How do you guys deal with reviewing garbage code?
Do you waste a ton of time, trying to understand the code, so you can write constructive feedback?
Today I wasted 4 hours reviewing something like that and I'm still not finished.10 -
So I fix a bug and I create a PR, someone reviews it and leaves a couple of comments, I address those comments and push up my updated code thinking “great I should be ok to move onto this big story waiting for me”
Then some Expletive.random(); from a totally different team who has no context of my change comes in and starts leaving petty comments. He literally pointed out 3 different things that could be made private/package-private.
Bugger off and focus on your own team’s work instead of leaving comments about relatively trivial things on my PRs.
Apparently he is well known for this. I can tell we are gonna have some fun encounters...1 -
That awkward feel when I ran into an issue on one of Azures SDKs and find the pull request is open and not merged for a few months...
The even better feeling when I realise that particular product SME is _literally_ in the room behind me.
Chocolate is an alternative form if bribery right? -
dev: ugh we need to set and implement coding standards
same dev: no I don't need to follow what you just said, it's already clean and readable (it's not) -
When you keep on refreshing the tab to see if your pull request got merged but it still says
”Pull requests 1”
3 -
This is how we managed to crash GitHub a couple of days ago. Get ready for 2 more crashes in the coming days 😂
3 -
when github autocorrects my pull request message that contains the word splunk.
(or when devrant also decides to) -
GitHub has launched Codespaces : A feature that lets you code directly on the web {as a virtual Integrated Development Environment (IDE) on the cloud}.
According to the Github Blog: Earlier, to contribute to a project you would need to make a pull request and set up the environment on your local machine according to the requirements of a project. With Codespaces, you don't need to do that anymore. As soon as you click on the code button, the website sets up the environment in seconds.
In addition to Codespaces, GitHub is also launching Discussions : A forum-like feature that lives under your project that allows others to engage with you and other contributors.
Code scanning : With code scanning enabled, every git push is scanned for new potential security vulnerabilities, and results are displayed directly in your pull request.19 -
Remember this : https://devrant.com/rants/1547095/... ?
FINALLY some updates.
Just to say they deleted the branch I was trying to merge on during the month, so I need to redo the pull request and rebase.
(ﾉ｀□´)ﾉ⌒┻━┻5 -
Created a merge request for a big issue last week. Some dumbass co-workers merged several other stuff for tiny shit issues that lead to many merge conflicts now because they didn't pull before..
Nevermind.. will be merging develop into my branch for the third time now.. Got already 20h of extra work because no one minds to merge my request because it's so big and someone might have to check the commit messages what really happened..
Conflicts suck! Co-Workers suck! -
After giving up on multiple attempts to contribute to opensource projects, came to know about 'yourfirstpr' on one of the comments here.
Long story short, a week later and I've made my first pull request to libgit which has been merged :)
Thanks DevRant community 😊2 -
Love it when the maintainer of an open source project you contribute to runs a linter over the whole codebase and force pushes the changes to origin master so now all the Pull Requests in the queue have to be rewritten and have tons of merge conflicts to resolve. Awesome! 😠2
-
ME IRL:
-submits pull request-
-goes to close some windows .... er ... naw-
-creates new virtual desktop to work in and leaves the old desktop / code open in case there are some bugs that pop up in production...-2 -
Question about git: What do you do when you have a massive pull request? This guy I work with made a PR with 13k files out of which 11-12k is basically HTML's that should have been added as an initial commit, and remaining ones are actual files that we worked on. Should I ask him to somehow split his work in two parts?8
-
When you use Git for the first time and your project from 29 commit jump to 62 for continous error with Pull Request.
Of this new 33 commit, only 3 are REAL commit.
Four hour for reset and fix all The master branch.
But finally all is fixed and i've learned more on Git... (?)2 -
One of my very first PR's didn't even get a comment and I worked hard on it...
Feels bad man, all I need is some kind of yes, thanks for this, or no, this doesn't fit the project goals.
After patiently waiting, went ahead and created my own gem! No response sucks.
Why does this happen?1 -
Our Risk team is making us enforce having an approved change record before teams can merge to master.
As in, people will get in trouble if they complete a merge of a pull request outside of an approved change window.
This, of course, is completely separate from the change record they'll need before they deploy the code anywhere...8 -
So to keep me going through the day I sometimes entertain myself by adding funny comments to my pull requests. I sit there giggling to myself like some sort of lunatic and the rest of the office probably think I'm a nutcase.
Todays gem was:
Added timeout to prevent hanging. Bet they wish they'd had this feature in the 16th century
Honestly I think my talents are wasted here...1 -
So I made a pull request on a PHP public repo fixing line lengths and adding some spacing for readability. All in the hopes of improving it to follow PSR-2 standards which they specifically say they follow.
Pull request got rejected, reason: "No thanks, the code is good enough."
Lol! 😐Time to move on to others who appreciate help. -
7th approved pull request in a few months as an intern :) I'm not sure if that's actually good but it feels good so fuck yeah
-
When Monday comes round and all you can think about traveling to work is the giant pull request you were asked to review on Friday 🙈
-
Just submitted my first ever pull request on GitHub. Here I am frantically waiting for it to get rejected or take my first step towards the Hacktoberfest shirt 😁1
-
So today I was having this discussion with my colleague regarding a messed up pull request.
Me: are you done merging the remaining branches into master?
Colleague: no, I'm still merging the changes manually.
Me: but why?
Colleague: because the changes will overwrite the changes in master.
Me: but how? It will just conflict and you can keep whichever changes YOU WANT. You can even edit before committing the merge.
Colleague: I'm just redoing the changes manually anyway.
Me: -_- -
Just thought of a solution to a problem I'm having with an open source library. Now I can't sleep until I have made a pull request! It's 00:17 and I've just found out my Macbook is dead.
-
Yeeehaw,
i finally get rid off that over-the-top dependency on Zend\Config in upwork/phystrix
The Pull-Request is on it's way:
https://github.com/upwork/phystrix/...
After 4 years of "this will take minutes to refactor" and "yeah. I totally agree. Replace Zend\Config with Array Interfaces", someone (in this case me) took finally care of this easy to solve issue :)
I hope it will be merged soon into the master branch -
So my day's going pretty well, successfully managed to create a pull request for broken code that breaks more code and run into errors trying to fix it, then spill tea all over my desk/self spazzing trying to fix one child problem like 3 levels deep
Pretty sure I'm the office dunce at this point1 -
I've never rejected a pull request, I just out in loads of comments with constructive criticism.
When shoukd you reject and when should you just sdd in comments?7 -
How my friends work day goes, I worked at the same firm and on the same project, I dont pity him.
70% debugging
25% refactoring - after his pull request was denied a few times, and had to rewrite that code in question a few time. I think most people go mad
3% test writing
2% code writing -
Get ready to launch a feature. Just about to make a pull request. Business be like, oh wait. Something came up, we need to wait a week. Fuuuuuuuuuuuck.
-
The hardest part in my job these days is thinking commit and PR messages :/
I believe my code and commits and PRs are always self explanatory, the company doesn't agree apparently.2 -
Pull request of the week: (In simplified version)
a = getVariable()
...
getVariable() {
[Some logic]
a = thisValue
.. or ..
a = thatValue
return a
}
🤦♂️🤦♂️
Tried my best to write a polite comment -
Dude i asked you to review my pull request because i thought we were cool. The code change is about a simple rename, SO FUCK OFF WITH THE REFACTOR SUGGESTIONS. STOP DOING THAT TO MY CODE REVIEWS
2 -
Wtf looking at a Pull Request today for styling 4 buttons...
750 lines of of CSS and not even able to style an anchor!!
How the hell is that even possible!!!1 -
@dfox Feature request: could you add the "pull down to refresh" feature to the notifs and rant windows please? xox2
-
Made a pull request..review tonight... Deployment tomorrow night.. or morning according to new york time... Hope I don't wake up to pissed off comments in the request.
-
My first ever pull request on a public repo on github just got merged. The suspense is killing me. Three more to go for the free shirt...4
-
*click 'create pull request'*
*satisfied*
*pat on shoulder*
Will get comments surely, but I'm happy that I could make a PR -
Commented on a hacky pull request that the junior dev called the same method twice for no reason.
Junior dev didn't get it and asked me to explain in person.
I went over and traced the code, finally he understood my comment. Then he said "Yes, I call it twice"in a tone that as if there's nothing wrong in that statement.
🤦♂️2 -
Draft Pull Requests : With draft pull requests, you can clearly tag when you’re coding a work in progress. Next to the “Create pull request” button. Toggle the dropdown arrow whenever you want to create a draft instead.1
-
REBASE BEFORE CREATING A PULL REQUEST
Especially if you've had to pull from main 7 times. No one has pulled from your branch, you have no excuse!7 -
I guess this won't be new to any person here, specially this being a community of well-versed devs. But here it goes:
Its hacktoberfest time!! Make 5 contributions to public repositories and stand chance to win awesome swags and t-shirts from digitalocean.com !! 🎉🎊🎉
I have created a simple repo for beginners . Make a pull request now! https://github.com/root-ansh/...
Do share this message with other awesome devs! Let's make this October awesome🔥💯7 -
pull request that made my day - a colleague of mine wants to make the open world subject to some master. of course I rejected this attempt ;)
4 -
So I'm working on this codebase that has about 50k lines of code and I built a feature in it today. Spent 3hours on the feature + writing tests. Then I raised a pull request and that bastard codeclimate calculated the test coverage had dropped by 0.3%.
For 6hours now I'm still looking for a way to increase the test coverage by 0.2%. FML4 -
Vague requirement for feature A received from client
Business consultant refines
Example mapping done
Acceptance criteria defined
Scheduled in sprint
Development done
Unit tests passed
Pull request reviewed
Code merged and deployed to system test
Functional testing successful
Deployed to UAT
Client asked to sign off
Client: "Actually I don't want that feature." -
So while reviewing a pull request a see that a co-worker named a variable "em" which stands for employee manager. So I asked him to rename it from "em" to "employeeManager" but he replies - Thats how all variables referencing that class are named in the rest of the app so he is being consistent with the app. What do you think should be done? Do I approve his PR?4
-
Pull request got declined by a peer because crc32 is apparently not "secure enough". It was used for integrity check of a small binary payload designed to be exchanged millions of times per minute between networked services.
Vetoed the living hell out of that.
-
I submitted my first pull request 2 days ago and guess what maintainer closed the issue without accepting and merging my request even 1 day ago I have commented on the issue comment box that I have a pull request please accept.
Not feeling good, I was thinking the hardest task is to find an issue we can contribute to, but the hardest task is, which we can't have control in and that is merging the pull request. -
I'm about to create a pull request for adding devRant as one of the default services in Rambox. Anybody dig it?1
-
When it's holiday season and your teammates are on leave, so you have to open a pull request and approve it on your own.
-
First pull request to an open source project :D
Well, a small project, without contribution guidelines. -
This team mate of mine always finds a way to escape my suggestions in his pull requests.
Today he told me that what I'm asking him is just my personal preference and that it's not a thing just because our formatter isn't powerful enough to do it automatically.3 -
It really irritates me when other engineers of various levels get hung up on pedantic, low hanging fruit bullshit in my merge requests. Like really, why keep a thread going just to force me to explain why I chose to make a particular magic string a constant that you don't see a use for? What about all the infrastructure setup code I spent 3 days on? Did you even read any of that to make sure it was sound and that my dumb/drunk/tired ass didn't make an obvious mistake, or could have done it better?2
-
So, a new coworker started here about two months ago. He's all about talking but the actions aren't very fast.
I looked at my Pull Request and this guy is writing comments for 5. Where the hell did he get the balls from? Seriously!
Please stand next to the designer so i can slap both of you bitches. -
Question about git. I worked on dev branch and made 10 commits.
Then I squash merged 10 commits from develop to master and made a release build.
Now problem is if I make a pull request from develop to master bitbucket will still show that master is behind (because develop has fixes in 10 commits while master has all of them squashed in 1 commit).
Now my question is whats the best way to make sure master and develop are synced (basically that master would have everything what develop has) ?
should I just merge master into develop back after the release?9 -
I swear to god I feel like I'm getting paid to just watch my boss code. My job is more debugging and submitting the pull request for whatever the boss throws together over team viewer.2
-
bitbucket you slow fucking sack of shit, we've confirmed with our remote team members that other people on other networks have it slow as shit too
I really wish we could convince our team to migrate to gitlab or github instead
can't tell if it failed to find the pull request associated with certain commits because it's slow a shit, shit (because it's atlassian bitbucket) or both
there is the small chance that maybe it's just the shit telecom industry in this country too on top of it, but things were acceptable before -
I hate Pull request system!
Plot twist: I just put it in place in my organization because I see the benefit.
Just spent 4 hours (Note : delay was because git refuses to write to stdout and writes everything in sdterr. And couple other things) developing a helper “powershell” script for “small tasks”. It sits directly in the project and as of 30 mins ago available to all devs.
Let’s say you need to change a typo.
Normal process:
• Create a branch
• Fix problem
• Commit/push
• Create pull request (This one was NOT easy. I’ll explain why if someone is interested)
• Switch back to master to fix second bug
Script does exactly that now. ./CreatePullRequest.ps1 <tmpbranchname> <Comment>. (The target for pull request will be the original branch, not limited to master)
Now I’m trying to find what I missed. Because I missed something, 100% guarantied.14 -
For Ramda (functional JavaScript) enthusiasts -
Anybody, who wishes to collaborate on writing Ramda solutions for SQL like queries, I have created the project (SQL queries, SQLite database, json data files) here - Ramda-SQL-Equivalent GitHub project (https://github.com/ajit555/...).
Please post the questions in "Issues" section and hopefully would get some solutions via pull request.
If not sending pull request, please post the solutions as issues referencing the file name.
Thanks. -
People that approve pull requests without looking at them!
No tests or so bad they would do more use by not existing, typos, the code follows none of the design practices and the code obviously will not compile and thereby breaks builds in trunk for everyone.
Because of course they only asked one person to review it and then merged it immediately. -
Can you imagine this scary moment while resolving conflict after a pull request that might break your code ?
That's the scariest moment1 -
Some background:
About 2 months ago, my company wanted to build a micro service that will be used to integrate 3 of our products with external ticketing systems.
So, I was asked to take on this task. Design the service, ensure extendability and universality between our products (all have very different use cases, data models and their own sets of services).
Two weeks of meetings with multiple stakeholders and tech leads. Got the okay by 4-6 people. Built the thing with one other guy in a manner of a week. Stress tested it against one ticketing service that is used in a product my team is developing.
Everyone is happy.
Fast forward to last Thursday night.
“Email from human X”: hey, I extended the shared micro service for ticketing to add support for one of clients ghetto ticketing systems. Review my PR please. P.S. release date is Monday and I am on a personal day on Friday.
I’m thinking. Cool I know this guy. He helped me design this API. He must’ve done good. . . *looks at code* . . . work..... it’s due... Monday? Huh? Personal day? Huh?
So not to shit on the day. He did add much needed support for bear tokens and generalized some of the environment variables. Cleaned up some code. But.... big no no no...
The original code was written with a factory pattern in mind. The solution is supposed to handle communication to multiple 3rd parties, but using the same interfaces.
What did this guy do wrong? Well other than the fact that he basically put me in a spot where if I reject his code, it will look like I’m blocking progress on his code...
His “implementation” is literally copy-paste the entire class. Add 3 be urls to his specific implementation of the API.
Now we have
POST /ticket
PUT /ticket
POST /ticket-scripted
PUT /ticket-scripted
POST /callback
The latter 3 are his additions... only the last one should have been added in reality... why not just add a type to the payload of the post/put? Is he expecting us to write new endpoints for every damn integration? At this rate we might as well not have this component...
But seriously this cheeses me... especially since Monday is my day off! So not only do I have to reject this code. I also have to have a call now with him on my fucking day off!!!!
Arghhhhhh1 -
Don't you just hate it when a git pull request assigned to you doesn't have a descriptive title and no description at all? I think I'm having a migraine! #%!%^*#1
-
I'm at the moment..... after a 100 commits in one single pull request, days of torturous effort and grappling with a stupid bloated piece of crap software, when, I realise, I COULD HAVE JUST TOLD THE CLIENT TO BUZZ OFF!!!
-
Finish the story and all tests pass
*notification another merge request been approved
Pull changes build, all tests faill
-
The cringeworthy moment when you approve a pull request and a teammate starts suggesting a ton of changes :/1
-
Is there a way to create pull request on git using CLI? I have tried request-pull option but quiet lost over there.9
-
Me: 'here we go, code working completely as intended, tested and without bugs.'
Senior after reviewing code: 'apart from the formatting errors, I'd also do this piece of coding in a different manners'
*Comments exchange in pull request*
Me: 'well this seems more like a change the whole logic request rather than a small improvement, I'll keep it like this and resolve it like suggested on a future opportunity'
Still in prod. -
Checker checks my pull request in git... says there's an error but in my laptop my codes are working fine... something must have been wrong there...
-
Is this a justified code review comment or a bully?
Code reviews are weakness of this industry which has the potential to attract bullies. Abuse of the comment box in a pull request and bombarding the employee with hundreds of comments can cause stress, frustration, burnout and finally resignation and costs of fulfillment for the organization. While companies should find and stop bullying in the work place, what kind of code review comment is considered a bully and why? Any of below traits can mean you are dealing with a bully:
1. Claims the code needs to be changed but doesn't say how. So no matter how many times you change your code, he can repeat the same comment: "Your code is still bad due to blah blah and it needs to be changed".
2. Provides how the code should be changed, but the change doesn't add up to quality, security, performance, readability, etc. i.e. "Why did you use a for loop here? Use a while loop instead". Or "Why did you write it using three classes A, B and C? Instead write it using 4 classes D, E, F and G which does blah blah". In the later case, not following the review comment, you won't get approval. Following the comment means you need to rewrite your whole code. After which, you might again receive more comments to change other parts of your code!
3. Claims the requested change is due to standards but claimed standard does exist anywhere. Internet, company wiki, university course books, anywhere. In more severe cases of psychopathy, the bullying person refers you to a link which hours later turned out to be written by himself! Have fun describing what has happened to your manager or team leader... .
4. Asks the code to be changed in a way that supposedly is closer to standard or of better quality, security, performance, etc. But the proposed way will not work and is the main reason you didn't do that in the first place. So you start arguing forever in the comment box over why his method won't work!
If you cannot see any of the above traits, then keep calm, take a breath, fix your code. Otherwise you might be victim of a bully.2 -
When you need that one feature from a framework, that it just not have. So you have to use a custom version till your PR has been accepted.
I see a possible problematic future... -
He did the mash, he did the developer mash
The developer mash, it was a segmentation fault crash.
He did the mash, it caught on in a pull request.
He did the mash, he did the developer mash -
I don't get it, why having more than one decorator looks "weird"? that's idiomatic Python AFAIK, that's sounds more like nitpicking on aesthetics :/1
-
Jest/enzym unit testing: My lead developer says using shallowWithStore instead of shallow on one incidence would introduce CPU overhead thus I MUST stop whatever I'm doing and fix the pull request. Is that normal?
-
What to do if the repository maintainer taking a lot of time for accepting pull request of hacktoberfest?5
-
When you open all the bitbucket emails you have to process after you spent just a half day doing your own tickets.
-
Today I submitted to code review the first iteration of a microservice done with Ramda and flow by request of my collegues. This is the first time they look at anything similar to functional code or typed js, and only one of them took the time to actually do a review.
I really like having my code reviewed and reviewing others', but please don't pester me to make a PR for a microservice you'll never look only to bail off as soon as you see something new that scares you. Buckle up and learn new stuff! -
Sumbitting a succesful Pull Request with a couple of commits to a public repo just using GitHub desktop is like playing life in Legend mode1
-
Completely noob question and before you say it, yes I have googled but I'm tired and I just get walls of text.
How do I merge a pull request?
A nice guy has submitted a pull request to my repository on GitHub, how can I merge it??
I tried what I thought was merging but it said that a file is conflicting. I tried deleting the file and it still didn't merge.
4
Top Tags
Weekly Rant
View