Just had the first pull request on my repo! ❤️

Working with a team of interns, pointed out a bunch of unit tests are failing, they said they would take care of it.

10 mins later they opened a pull request to delete the tests that were failing.

fml, fml, fml, fml ... and ... oh yeah fml

I just got my first open source pull request merged for a library I use!

“Git Pull Request is waste of time, commit directly to master!”

When you merge your own pull request....

When you merge 8 pull requests and everything worked without any conflict.

I just made my first pull request to an open source repo on github 😊

Just some tiny improvement but still I'm geeking out right now🤓

A guy who doesn't work on our project anymore, but still checks on us regularly just did this:
- reported a bug
- started explaining what's causing the issue
- realised the problem was in a piece of code written by him before
- fixed his own mistake, committed it and created a pull request

We all had a good laugh.

Found a private api key on a github project. Created a pull request with key changed to “TH1S5HOULDB3SECR3T!iMBECIL5“ comment was “security fix“ i wonder if they accept

that moment when your first pull request to a major deep learning library is merged and you have no friends who understand what that means and to share your happiness!😓
no problem, you've devRant! 😁

Just received my very first pull request on GitHub. Pull request: "Remove jquery as dependency".

* Makes repo private *

Developer creates pull request.

I hold suggesting changes.

Developer creates new branch and new pull request with exactly the same commit.

Another Senior developer approves pull request.

This will be discussed tomorrow morning!

Found this beauty in a pull request(paraphrased):

//Old code:
String externalIdNotFound = "The external ID could not be found.";

Me: The user who'll see this error message won't think of the ID as being external, so please remove that word.

//New code:
String idNotFound = "The external ID could not be found.";

My days of not trusting this guy's competence are certainly coming to a middle...

Ah, ok, I understand!

We use emojis to maintain pull request status in a Slack channel

The other day we found this in our code review tool...

Laravel accepted my pull request! Ego boost, baby!

Happiness is a pull request approved on first try.

wife said she'll accept my pull request once I'm done with the dishes

So my pull request got accepted from a minecraft mod on github, and I made it in to the changelogs.

Am I famous now?

Manager: "Pls deploy the changes ASAP."

Me: "Right away."

Me: *creates pull request*

... 5min later ...

GitHub: "Some checks haven't completed yet."

... 45min later ...

GitHub: "Some checks haven't completed yet."

Me: *looks into delay*

CircleCI: "Partial System Outage"

——

(╯°□°）╯︵ ┻━┻

I sometimes wonder my English is that bad ...

I reviewed a pull request. I commented on this line of code

a = getA() * -1;

saying that

"I think this logic should be in setA method instead."

When the guy asked me for the review again, the change was

- a = getA() * -1;
+ a = setA() * -1;

...

My computer science teacher won't stop developing on the production server 😭 he switches the branch on the production machine to dev all the time and merges broken code into master. Kill me

Yay my first merged pull request on an open source project ^.^

You don't have to fix your pull request if you directly merge it into master.

That moment when u created a project and quite some folks forked it and continued their own versions, but then you realised that you've made a little mistake back then so now your dumb code propagated across humanity.

¯\_( ͡° ͜ʖ ͡°)_/¯

First PR (pull-request) to be accepted by a non-profit!!!!!!

I once reviewed a Pull Request made by a fairly junior developer. They had joined recently, and this was one of the first times they had to touch a bigger part of the code.

Due to a mix of inexperience, new (to them) coding standards and lack of git knowledge, they ended up with a mess of a PR, with a few thousand lines changed, and no way to split it off.
I ended up spending the best part of a day reviewing the whole thing and requesting changes.

Even with the long list of improvements, however, I wasn't sure they would get the magnitude of their fuckup.
So I decided to use a real-world, palpable way to show them what they had done: I went and printed the github diff for that PR. It rendered the glorious amount of 73 pages.

I'll never forget their face, and those of their teammates, when I barged into the room with a thick wad of paper and deposited them on their desk.

At least it worked. I never saw another big, ill-thought pull request from them again.

Just did my first pull request for an open source project ever. And it actually increased test coverage for the whole project 😂

Ahhhhhhhhhhhhh!!!!!!

A pull request I made to an actual open source project got merged. I might actually be a real dev now!

(It was just to remove a snippet config, but still!)

Did you even test the code?

Yes I did.
You found one bug.
Not the 150 I fixed.

Manager told me the new girl's first pull request was waiting for my review, I felt dirty.

A story before the start of another week,

So last Friday, one of the business guy came over and asked a rather peculiar request, the conversation went like this,

"" -> business guy
// -> me/colleague

"Can you export the code from the repo?"

//uhh, sorry, what?

"Yeah, can you export, the code, from the repo? The latest one?"

//as in the code? You're asking for the source code?

"Yep, that's the one"

//oookay..., what is the purpose of that? What are you going to do with it?

"Nothing, just so that we have it"

//well, we do have it, stored securely in the repo

"Yeah but we need the code, as, you know, physically? not the one in the repo, we want to kinda have another copy for ourselves, just put it in a zip or something"

//again, we already have it stored in the repo, what do you need another copy for?

"Ahhh, you know, just that we know that we have some kind of proof of the state of the progress... of the feature (insert hand gesture) that we're working on, so that we know that we have reached... this... far, or something like that"

//that's what the versions are for, we can always rollback to whichever... past... state (insert hand gesture) that we have done and/or doing, everything is there in the repo,

"Uhhh, it's not much about versions or anything really..."

//so?

"You know, we need like a... documentation of some kind, for ourselves"

//so the code you're asking would be obsolete immediately, there're new changes everyday,
//it's better if you request an access for the repo and refer to a specific version from there if you want to document it,
//we can't compare the copy of the code if something went "not as you would have liked it",
//the documentation would be confusing as the code it's referring to is not the correct source of truth

"Hmmm, yeah, requesting repo access would require a some kind of a strong reason to be approved, besides it's gonna take a while, and it's not about comparing really, its just..., so that we have a copy of the code for our own... documentation"

//(I smell bs) well the argument stands, the code is going nowhere, it's there in the repo, if you would like a copy, request an access for the repo, and you can read/copy/document it all you like from there,

*then it goes for 20 more minutes of roundabout pleas about "documentations" and "having a copy of the code" with other colleagues before the guy gave up and went to think about requesting repo access,

In the rules, repo access is restricted for developer only, except for those with good and acceptable reason can have one, and requesting an access requires some strong reasoning and quite a lengthy procedure for non developer,

Until today, I still can't figure out the context/motive behind the request 🙃

Probably some bs they tried to pull, again,

Since it is now the hot topic to talk about, here is my input.

The new python change is a terrible idea.

We should totally start a community python fork that stays 100% up to date with master, but removes that one pull request

My first ever pull request got accepted 😎

FeelsGoodMan

My colleague: *merges my pull request and his like an idiot and removes my changes*

Me: you merged incorrectly. *Shows code*

Him: .... Yeah try to avoid adding comments because clean code best practice is to not have them.

Me (to myself): how about you merge correctly instead of putting blame on something else.

For gods sake, it was a comment explaining why the code exists and not what it does.

He somehow was selected as tech lead because there were no free resources at the time. Hate it when these kinds of devs who can't code try to save their non existent prestige.

The guy can't even make proper rest apis. Give a wrong param value and it returns the whole json with null values. How the fuck do you still think you can talk about best practices when you can't implement them yourselves.

This is the same as the colleague in my previous rant who can't use git correctly and has everyone save their work so the guy can push cuz who pulls stuff, and then proceed on sharing posts about *teamwork* on LinkedIn.

Just got the first pull request to my open source project :D

I have a variable called 'stuff'. It's a test to see if my colleagues really read my pull requests.

triggered af

I tell him to submit a pull request, he just merges his code. I revert it and tell him to submit a pull request, he submits one then merges it himself immediately after...

Emotional roller coaster today.

+ Got first pull request! Hell yeah!

- oh, no, no no no nononono, they pushed all dependencies and temp folders...

fck sake isak, gather yourself

Holy shit balls it works (so far)

-
So I’ve been working on a project... well feature for the past year (yes 12 whole fucking months - anti agile I know)
And today I got to merge that bitch of a pull request into the current working branch and deploy it to UAT - no conflicts 😵I think I need to put the lottery on tonight!
And some how, by some stupid lucky roll of the dice it just works.

I have never felt so afraid and delighted in my life!

Oh no, oooooh nononono
they dont delete the branches after a pull request

232 branches? hhhhhhhhhhhhhhhhhhhno
and look at that naming

im intimidated, i dont want to work in this environment. No. NO!

1. Put headphones
2. Put videogame OST (Chrono Trigger is the best)
3. Start Atom
4. Sacrifice a male virgin to my Code Muse to replenish her mana stock
5. Jerk off seeing a fat granny midget porn
6. Clorophorm and put my coworker to sleep so he doesn't interrupt me to show the FailArm best fails of 2016
7. Atom is still loading, so I curse all the GitHub fuckers
8. Give up and start my emulator to play Chrono Trigger
9. Receive a pull request and realise I need to work and be a productive member of society
10. Goto 1

I jump on an existing scala project.

git pull && sbt compile test

Tests are failing.

Me: "Hey team, the tests are failing."

Team member: "That cannot be. They were passing for the the last run."

Me: "Did you run them locally?"

Team member: "No, on Jenkins. It was fine."

I check Jenkins.

Me: "What do you mean it's fine. The last successful deployment was on the end of May."

Team member: "The Pull Request checker always went through successfully."

I check how our Jenkins tasks are configured. It's true that the Pull Request Checker runs successfully yet due to a "minor misconfiguration" (aka "major fuckup") the Pull Request Checker only tests a tiny subset of the entire test suite.

Team members were were fine if their Pull Request got the "Success" notification on bitbucket's pull request page. And reviewers trusted that icon as well.

They never checked the master run of the Jenkins task. Where the tests were also failing for over a month.

I'm also highely confused how they did TDD. You know, writing a test first, making it green. (I hope they were just one specific test at a time assuming the others were green. The cynic in me assumes they outsourced running the tests to the Jenkins.)

Gnarf!

Team member having run the tests locally finally realizes: "The tests are broken. Gonna fix them."

Wow. Please, dear fellow developers: It does not kill you to run the entire test suite locally. Just do it. Treat the external test runners as a safety net. Yet always run the test suite locally first.

Why would you submit a pull request with the addition of such a comment and expect me to approve? What the hell is wrong with you?

A badass pull request review comment: 'A wise man can learn more from a foolish question than a fool can learn from a wise answer.'

WHY DON'T YOU FUCKING READ THE CHANGES IN YOUR FUCKING PULL REQUEST???

If you did, you would realize that 50% of the stuff is total fucking nonsense. I don't want to see that you changed "var a = 0" to "var a= 0" just because you can't type with your shitty fingers.

Also, if you did read the changes in your PR, you would have realized that you added a bunch of totally unrelated changes in totally unrelated files.

Fuck! Am I the only one who always tries to produce a clean changeset?? Damn

I just submitted my first pull request though it was a minor addition in readme. So happy 😊

I joined a "multi-national" company in middle-east where 90% of the developers are Indian. And since it's a "multi-national" company with 50+ developers I thought they already figured it out. Most of them have 5-10 years of experience. They should know at least how to use git properly, deployment should be done via CI/CD. database changes should be run via migration script. Agile methodology, Code Review - Pull Request. Unit testing. Design Patterns, Clean Code Principle. etc etc

I thought I'm gonna learn new things here. I have never been so wrong in all my life...

Technical Manager doesn't even know what Pull Request is. They started developing the software 4 years ago but used Yii v1 instead which was released almost a decade ago. They combined it with a VueJS where in some files contains around 4000 lines of code. Some PHP functions contain 500+ of code. No proper indentions as well. The web console is bloody red with javascript errors. In short, it's the worst code I've seen so far.

No wonder why they keep receiving complaints from their 30+ clients.

This one time I developed some useful plugins and a command line interface for the platform we built at work.

Then when it was done I thought it had some good value so I created a pull request to donate it to the platform. That same day I got 3 complaints that my pull request did not conform to conventions and that there was no ticket for it and they complained about the fact that it made their jobs harder.

It was in fact the last time I developed something for work in my spare time.

Submitted my first open source pull request 😍

I just got my first accepted pull request! I'm so freaking giddy, you guys...

Contributed to a open source project for the first time what hasn't been updated in 3 years and my pull request was just accepted!

Sex feels good and all but have you ever felt the pride of submitting a bug fix to software you use on GitHub?

That amazing feel...

Real geeks don't send friend requests, they send pull requests.

Today I had my first decent pull request accepted.

It wasn't the biggest problem, but it made a chrome extension not work, and the author and other users couldn't figure it out.

The author seems very chill and called me 'the man' and offered me a drink.
It felt nice.

Submitted my last pull request, said farewell to my team today... *weeping*... haven't realized it would be so hard. Oh, well, best of luck my friends, and keep my code running ;)

Submitted my first pull request to an open source project, the iOS Wikipedia app!

I my first pull request on my repo today from a contributor

Everyone complains that a certain developer's code is not up to standard and when they have to take over his project the lack of code quality is really slowing them down.

I look at code, agree it is poor quality and put together a learning plan for said developer.

Also look at who approved every pull request which allowed bad code into our codebase. Same developers as those complaining it's no good. You had your chance to stop it!

Whoop whoop I just made my first pull request at an open source project :)

Product manager had me spend an hour setting up his machine for rails development. Then walk him through all of our workflow. He then proceeded to make some changes to a header tag content. Made a pull request while I was holding his hand. Then he walks out of his office acting like he just won a national championship and proceeded to talk about how he was basically a developer for the next hour interrupting work.

My biggest mistake in my life.

Boss: So when are you gonna finish this?

Me: I'll finish it today,

Me: Finishes task and submits pull request

- The Next Day-

Team Lead: Oh bro you gotta put this on a separate file, this change this too, and that, don't use that shit use this instead, oh and yeah, you can probally use this 'totally awesome typescript decorator' here for that.

Me: Refactors code intensely

Boss: You said this going to be finished yesterday

Me: FML

!rant

Just sent my first pull request!

Friend gave me his cheap few dollars wifi adapter.
Took it connected to PC. And tried monitor mode. Ofcourse it isnt gonna work. Yup not working.
OK lets search for better driver for this thing. Hmmmmmm
Compiling error. Well thats what i get for getting the latest kernel. Well incompatible pointer type.
Nah fuck that.
-Wno-incompatible-pointer-type Boooom build.
Installed.
Loaded.
Can connect to network (Amazing i know. Who would say that wifi can connect to wifi AP LOOOOL)
And monitor mode works too.
Packet injection works too.
Good stuff.
And best part is that i had an old router with looooong antena on it and it wasnt working since i fried the CPU on that one. (I posted rant about that. USB mod didnt go as planed when somebody scares you when you are soldering)
So i took the antena and well now i have Wifi adapter with monitor working that can get wifi from next fucking street and maybe even the next street after that one since aluminium pointer is good.

And yes ofcourse the pull request is already sent in the second i fixed it.

That feeling when your pull request for a public github repository got merged :$

#prank

New guy on the team, learning WPF.
He forgot to lock his computer when fetching coffee. I added a transform group in the main window and checked it in to Git. Locked the computer.

He comes back, furious at his computer for turning the application upside down.

Next two hours he was rebooting, flipping the screen, stressing, googling until I finally had to confess.

He uttered a strange sound of short burst of laughter concealed in a relief of not going insane.

It was a good day.
His pull request was rejected.

Who works at a company full of shit coders?
Me me me me
Who facepalms at every pull request he see?
Me me me me
Who for following conventions is something he wish?
Me me me me
Who codes about as good as a fish!
My co-work-er!

Sing it kids!
Fuck all my coworkers code
Fuck all my coworkers code
Fuck all my coworkers code

You shouldn't, have been, hired!!!!

Let me make a small change to this file, a one-line pull request will probably be accepted right away

* saves *

Prettier runs...
EsLint runs...
StyleLint runs...

60 changes submitted for review

Client: I want a new feature for my chat bot. It should be able to rap.
Me: ... k
*monologue: wait u w0t m8*
Also me: Can you please go more into the details? It should be able to rap. Ok. But how do you want it to look like? How "strong" should be the discrimination level, for instance?
Client: It should beat ass, yo.
Inner me -> core me: Let us just ignore him. We won't be able to do it, since he isn't really explaining his needs. "It should be able to rap". We are not wizards.
Core me -> inner me: Chill. We will just use some insult apis, combine it with cleverb0t api et voila.
Me: Alright. I got an idea for it. I can do it within this week. And if you don't like it, I will ofc do some changes to it.
Client: Hmmm... that's nice and good. But within 1 week?
Inner me: I can't do magic and pull that feature out of my fucking ass!

Clients... clients... clients...
0. Don't expect us to be done in a few days. We are also humans. And not fucking machines.
1. Do us (all devs on planet earth. -Microaggression in 3, 2, 1..) a favor and (kill yourself) learn how to request a feature.

Today I found an error in how we handle credit on invoices in our software.

This is the first time my boss has ever made a legit pull request for me to review of his.

Damn I feel proud!

Felt so awkward today. Bare in mind I am still a junior. I was on a pull request reviewing session on a repo I use. I was being super super pedantic with variable names, data types etc as the people who wrote it are brand new to the company. I then realise I had just reviewed the companies lead developers PR to a different repo. Every time someone comments on a PR on this repo all developers in the company get an email notification. I sat there litrually sweating, bright red with the words 'oh ****' on an infinite loop in my head, staring at the screen waiting to see what was to happen.

Thankfully he was ok with the comments. But now people keep calling me the lead developer (teasing) fml I hate anxiaty

Friend of mine: so I wonder how do you test your applications in the startup?

Me: testing? *grabs his coffee laughing*

Actually we have a complete build pipeline from commit/pull-request to dev and production environments. No tests. Really. We are in rapid product development / research state.

We change technologies and approaches like our underwear (and yeah, this is frequently). If we settled some day and understood the basic problems of the whole feature palette, we'll talk about tests again.

I started a new project with a backend guy and another frontend like me.
This other FE is 35 years old.
He told me he works as Technical leader before.
This was his first PR ...

How do I even start?
The guy that's supposed to be our extra resource, our go-to person, asked me why node_modules and typescript output files are not committed.
Node.friggin.modules!
And by typescript output files, I mean the compiled .js files. Shoot me now...
All he does all day is waste time! Useless calls scheduled way too early, 'cause IST & why the heck not?

And don't even get me started on his "knowledgeable" colleague who spent 2 friggin' days on figuring out how to find an element in an array.
I mean ok, I get that the language is new and the syntax is different, but boy, how I wish that was the problem! But nooo, her issue was figuring out the damn logic behind it!
Not to mention that I gotta do the code review and she keeps ignoring the changes that I ask of her unless I raise that in our daily meeting and reports stuff as done even before submitting a damn pull request. Also, I gotta shut up and take it, 'cause they are the client's internal resources, which has me ranting about it at 2 a.m. T_T

Ugh...

It's 35 degrees. Reviewing pull requests or finding a beer garden was the easiest decision of my career.

Please, stop being afraid of git rebase.

Please stop merging master branch into feature branch just to fix pull request conflicts.

git pull... FFS! Conflicts?!!

Having to check a 5,000 line PR makes me sad :(

If you're going to request CRITICAL changes to thousands of records in the database, and approve it through testing which is done on an exact replica of production, then tell me it was done incorrectly after the fact it has been implemented and you didn't actually review the changes made to the data or business logic that you requested then you are an idiot. Our staging environment is there to ensure all the changes are accurate you useless human. Its the data you provided, I didn't just magically pull it from thin air to make yours and my job a pain the ass.

I've been neglecting my 150 stars github library for the past month because I don't have time... Feel bad about it (9 open issues 1 nice pull request and one behind example library)

Feels bad when your pull request gets declined ;(

Time to do a little bit of shaming:

I'm specialized in e-commerce applications, mostly based on Shopware, a german out-of-the-box online-shop. They essentially claim to be a better Magento. In December of last year I found a critical issue within the code. Products within the shop can be declared as digital wares. In that case the purchase of a product will unlock the possibility to download a designated file.

As a customer you can access your downloads within the account section. Now here's the problem: The query that fetches the unlocked downloads for a customer is hard-capped at 500 rows. So after your 500th purchase, you won't be able to access any further files you paid for. Essentially their developers thought that this limit would never be exceeded anyway and called it a day.

Personally I think this unacceptable. For the merchant this is a potential law-suit in the making. So I took the time to refactor the code and fix the issue. The corresponding pull-request was flagged as scheduled back in December. Since then there have been numerous releases and the issue is still present. Not only do I ask myself why I should ever put in time and effort to fix their code again, but I also can't believe that they just chose to ignore the issue completely. Also mind that this is not just a small or non-profit open-source project. The responsible company behind the software is a stock corporation that claims to be the market leader in Germany.

The new mobile app codebase i'm working with, was clearly written by someone who just read a book on generics and encapsulation.

I need to pull out 2 screens into a separate library to have it shared around. The 1 networking request used is wrapped up in a 'WebServiceFactory' and `WebServiceObjectMapper`, used by a `NetworkingManager` which exposes a generic `request` method taking in a `TopLevelResponse` type (Which has imported every model) which uses a factory method to get the real response type.

This is needed by the `Router` which takes a generic `Action` which they've subclassed for each and every use case needing server communication.

Then the networking request function is part of a chain of 4 near identical functions spread across 4 different files, each one doing a tiny bit more than the last and casting everything to a new god damn protocol, because fuck concrete types.

Its not even used in that many places, theres like 6 networking calls. Why are people so god damn fucking stupid and insist on over engineering the shit out of their apps. I'm fed the fuck up with these useless skidmarks.

So, I just realised that a contribution I made to an open source project 12 days ago had gotten accepted 3 days ago. I'm so ecstatic over this!
I was basically just in need of type definitions for a javascript library, and seeing as it didn't have any, decided to make them myself. Done that, I made a pull request, but seeing as there was no changes after a few days, I forgot about it.
Now I just remembered about that, and wondered if it got any comments or anything, and it turned out that they had accepted my PR and it had already been put into a release 3 days ago
I can't contain myself right now, it was my first open-source contribution, and it just feels good to know that I somehow helped some people by giving them type definitions :D

Cheers

Hello world!

I wrote my first own contribution, pushed, made a pull request and merged to master today all by myself at my trainee job!

Success!

When your devs comment their pull request "fixed" but fail to push the fix to the remote... For the 5th time in a row. 💩😒

Boss: "So I'm taking the next week off. In the mean time, I added some stuff for you to do on Gitlab, we'd need you to pull this Docker image, run it, setup the minimal requirement and play with it until you understand what it does."

Me: "K boss, sounds fun!" (no irony here)

First day: Unable to login to the remote repository. Also, I was given a dude's name to contact if I had troubles, the dude didn't answer his email.

2nd day: The dude aswered! Also, I realized that I couldn't reach the repository because the ISP for whom I work blocks everything within specific ports, and the url I had to reach was ":5443". Yay. However, I still can't login to the repo nor pull the image, the connection gets closed.

3rd day (today): A colleague suggested that I removed myself off the ISP's network and use my 4G or something. And it worked! Finally!! Now all I need to do is to set that token they gave me, set a first user, a first password and... get a 400 HTTP response. Fuck. FUCK. FUUUUUUUUUUUUUUUUUUUCK!!!

These fuckers display a 401 error, while returning a 400 error in the console log!! And the errors says what? "Request failed with status code 401" YES THANK YOU, THIS IS SO HELPFUL! Like fuck yea, I know exactly how t fix this, except that I don't because y'all fuckers don't give any detail on what could be the problem!

4th day (tomorrow): I'm gonna barbecue these sons of a bitch

(bottom note: the dude that answered is actually really cool, I won't barbecue him)

I have discovered a fresh hell

Some guy I’ve never met or heard of in the office lobbed a comment at one of my *approved and merged* pull requests. He doesn’t say anything specific, only that my REST urls are not in line with naming convention. That’s all he says, and I’ve already walked the URL consumers through the code and given them the URLS.

I’m really annoyed that this guy won’t just say what he has in mind, but fine whatever this is a professional environment and developers are not known for being a diplomatic people. Let it go and get your work done!

I do some googling and find an obvious change that needs to happen- I implement it, open a new pull request and inform my URL consumers of the change.

This rando still isn’t satisfied and still won’t say what needs to change. I am on round 3 of this wonderful cycle and this guy is acting all fuckin HAUGHTY about it. “Here is a list of conventions I found googling, you should read them even if it takes 4 hours because it will benefit your career”

Sure dog you’re probably right on that one but we are in a professional environment and at this point you are holding up production so you can wave your dick around! Just SAY WHAT YOU MEAN SO WE CAN MAKE THE CHANGES AND GET OUR WORK DONE

When you work hard for something and you are sure that you gonna get it, but some ass licking guy who doesn't even know how to code gets it. Yes, it happened to me. I was working for an open source organization called PROBOT. I was working my ass off to get into GSoC with that organization. I created PR(pull request) after PR and solved most of their issues. But later on, I came to know they didn't even saw my single PR. Life surely teaches you some hard lessons but it's you who should not give up I would say. I do not regret working my ass off and writing those code and not getting into GSoC but I cherish those moments where I learnt many new things. And as for that organization, I would say they don't even know how to manage. This was my exact reaction when the result came

"Hey, can you review this for me real quick?"

Looking through our gitlog today and see 3 PR's from our "lead developer". 2 of these were removing a single blank line from a class, and the 3rd was adding one back in. None of these had any title or commit messages on the PR's. This is a guy that talks down to everyone and deliberately makes other devs feel insignificant, saying he's too busy to write documentation and it's not needed because his uncommented code is self documenting. But hang on he's not too busy to waste time with pointless non-functional PR's that only remove a couple of blank lines? Scratching my head in disbelief that some devs think they can get away with shit like this. How about you drop the ego and actually try and work in collaboration with the other devs.

FYI rambox users: My pull request got merged and as of version 0.6.0 devRant is now one of the pre-configured services 🎉

Building a pull request on our Build Server takes 14 hours, it can do about 10 builds at a time and there are already 26 builds in the queue and it isn't even 10am.

I've been waiting for a build since I queued it on Friday - because the queue is actually a stack.

And management / senior developers are like...

Gonna make a pull request for Project!

"How to Project:

npm install
npm test
npm run start"

npm install: warning, warning, deprecation, warning

npm test: 30 tests, 15 failed

npm run start: error, C stack trace

Pull request status: on hold

CAN SOMEONE PLEASE TELL ME HOW TO TRANSLATE PULL REQUEST TO GERMAN?

According to one of my teachers I have to translate this in a coding guideline otherwise other devs might not be able to follow the procedure...

I asked him how he would translate it and he could not give me a proper answer... describe it he said...
How the fuck does it improve my guidelines if I describe PR!!!
And if your not capable of doing it better how should I know I have to do it!

Sorry I looked at an old exam and got triggered when I saw the correction

So I was told why a bash with Git isn't allowed in my company.

The people that built the development kit (IDEs, tools, etc) estimated that Git wasn't necessary since integrated in Visual Studio.

They clearly never tried to do a pull request or a rebase then. Good to know.

(a coworker gave me a way to have a bash anyway, so that made my day \o/ but rant needed anyway)

Code reviewing a pull request directly for production when suddenly...

That's one way to fix it.

Nothing like the feeling of getting you pull request merged on an open source project 😎

Straight to the point.

Co-Worker laughed at me for taking a task on their side project and only them have worked at it. FYI i've never worked as a Dev before and I have a really low knowledge of web developing. Well i finished the task in time and sent the pull request to one of them. Got a 'well done dude, high five'. Feels good man :)

From a life of a junior developer...
Got assigned one task for a 2 week sprint. 'Finished' it in 3 day, not actually sure it's finished as all the other devs are too busy to look at the pull request. So here I am... Ranting away and being bored

I don't know if you are called the same on Github and DevRant, but thanks for giving me my first pull request @Paradoxis. I already learned a lot from it.

I was asked to fix a critical issue which had high visibility among the higher ups and were blocking QA from testing.

My dev lead (who was more like a dev manager) was having one of his insecure moments of “I need to get credit for helping fix this”, probably because he steals the oxygen from those who actually deserve to be alive and he knows he should be fired, slowly...over a BBQ.

For the next few days, I was bombarded with requests for status updates. Idea after idea of what I could do to fix the issue was hurled at me when all I needed was time to make the fix.

Dev Lead: “Dev X says he knows what the problem is and it’s a simple code fix and should be quick.” (Dev X is in the room as well)

Me: “Tell me, have you actually looked into the issue? Then you know that there are several race conditions causing this issue and the error only manifests itself during a Jenkins build and not locally. In order to know if you’ve fixed it, you have to run the Jenkins job each time which is a lengthy process.”

Dev X: “I don’t know how to access Jenkins.”

And so it continued. Just so you know, I’ve worked at controlling my anger over the years, usually triggered by asinine comments and decisions. I trained for many years with Buddhist monks atop remote mountain ranges, meditated for days under waterfalls, contemplated life in solitude as I crossed the desert, and spent many phone calls talking to Microsoft enterprise support while smiling.

But the next day, I lost my shit.

I had been working out quite a bit too so I could have probably flipped around ten large tables before I got tired. And I’m talking long tables you’d need two people to move.

For context, unresolved comments in our pull request process block the ability to merge. My code was ready and I had two other devs review and approve my code already, but my dev lead, who has never seen the code base, gave up trying to learn how to build the app, and hasn’t coded in years, decided to comment on my pull request that upper management has been waiting on and that he himself has been hounding me about.

Two stood out to me. I read them slowly.

“I think you should name this unit test better” (That unit test existed before my PR)

“This function was deleted and moved to this other file, just so people know”

A devil greeted me when I entered hell. He was quite understanding. It turns out he was also a dev.

The company I work at sends their developers out to other companies to help them work on projects and help them in other ways (advice when communicating to customers of on demand software for example).

While not on a project you are working in house training trainees and interns. Part of that is teaching them to show initiative and treating them as full developers. The 30 interns all discussed a git flow and code format.
During the third sprint (two weeks sprints) a team messaged me if I wanted to check their merge request for the sprint.

It took me a glance at the first file to know they didnt do any review themselves. I used my flywheel to check all their changes and without being able to read the code I saw indentation was all over the place, inconsistent bracket placements etc. I let them know I wouldnt check their code until it was according to their own standards.
Two days later I got the message to check it again. At first glance the indentation was fine so I started reading the code. Every single thing was hardcoded, not made to support mobile (or any resolution other than 1920×1080).
A week later they improved it and still not good. Gave them a few pointers like I would for any colleague and off they went to fix things. The code became worse and indentation was all over the place.

I told them the next time it shouldnt be a quick glance to be able to reject it again. By this time other teams came to me asking why it wasnt merged yet and I explained it to them. One of the teams couldnt do anything u til this was merged so I told them to implement it themselves. I was surprised that 4 teams came to me asking about a merge request, that was every team except the team whose pull request it was.

4 weeks after the intitial sprint the other team made a merge request and I had three small comments and then an hour later it was merged.

The other team messaged me why their merge request did went through (still havent seen any of their team in person, Im sitting 10 meters away from them behind a wall)
They also said that it was easier for them because they started from scratch. Thats when I called them in to discuss it all and if they were not interns but full time developers they would have been fired. I told them communication is key and that if you dont understand something you come in person to ask about it. They all knew I like teaching and have the patience to explain a single thing ten times, but the initiative should be theirs.

One of the team members is my current coworker and he learned his lesson by that. The others stopped with their study and started doing something completely else.

TL;DR
Merge request is open for 4 weeks, in the end another team started from scratch and finished it within a week. The original team didnt ask me questions or come to me in person, where other teams did.

DISCLAIMER: some of you might find it harsh, but in our experience it works the best for teaching and we know when people don't dare to ask questions and we help them in that too. It's all about the soft skills at our company.

So, I got a ticket to make a page using a given wireframe that had submit buttons and other buttons to add more items in the wireframe.

So, I pull the html, hook up the abilty to submit the form and add items, and send it out for review.

One comment on the review.

"Remove the functionality, you'll handle it in the next ticket"

So I commented out the javascript. Guess what I'm doing on the next 10 minutes.

Had a five hour long debate with one of our Senior Developers today about pull request etiquette.

His view was reviewers should always email or call him before adding comments to any of his requests and they should never block them as he should be allowed to code in "his own style" and should be able to approve his own pull requests.

I explained that we have code standards and an agreed PR workflow be needs to comply with.

He then started talking about meteors and plane crashes. Literally no helping some people.

Scumbag BroCow

Uses github to store his family photos

Uses github as a media streaming server

Conceals the repository by a random name.

Ignores pull request and issues made by haters

Pull request is like...
Leeeeerooooooy Jenkinssssss

Waiting for Pull Request to be approved.

Like, c'mon team!

WOOO THE NEW YEAR IS GOING SO WELL!

I just published my first pull request to someone else’s repository WOOOO

Me: Is git male or female?
Friend: male.
Me: why?
Friend: it does all the pushing and pulling!
Me: Really? I think we push and pull into git.

When you have 9 pull requests that have been sitting in the queue for the past 2 weeks

When someone merges their own pull request and destroys the master branch

Our project at work goes live in 3 weeks.

The code base has no automated tests, breaks very often, has never had any level of manual testing

will not be releasing with any form of enforced roles or permissions in our first release now due to no time to enforce, however there is a whole admin api where you can literally change anything in our database including roles.

We also have teams in various countries all working separately on the same solution using microservices with shared nuget packages and they aren't using them properly.

Our pull requests are so big - as much as, 75 file changes - in our fe app that I can't keep up with it and I honestly have no idea if it even works or not due to no automated tests and no time to manually test.

We have no testing team, or qa team of any sort.

Every request into the system has to hit a minimum of 3 different databases via 3 different microservices so 1 request = 4 requests with the load on the servers.

We don't use any file streams so everything is just shoved in the buffer on the server.

Most of the people working on the angular apps cba to learn angular, no one across 2 teams cba to learn git. We use git so they constantly face problems. The guy in charge has 0 experience in angular but makes me do things how he wants architecturally so half the patterns make no sense.

No one looks at the pull requests, they just click approve so they may as well push directly to master.

Unfinished work gets put in for pull request so we don't know if the app is in a release state since aall teams are working independently, but on the same code base.

I sat down and tested the app myself for an hour and found 25 fe only issues, and 5 breaking cross browser issues.

Most of our databases are not normalised. Most of our databases make no sense. 99% of our tables have no indexing since there is no expertise with free time to do it.

No one there understands css properly. Or javascript.

Our. Net core microservices all directly use ef in the controller actions so there is no shared code there.

Our customer facing fe app is not dry because no tests so it was decided it was better this way.

Management has no idea on code state, it seems team lead is lieing to them about things like having any level of tests.

Management hire devs that claim to be experts but then it turns out they have basically no knowledge of what they were hired to do, even don't know what json is or the framework or language they are hired for, but we just leave them to get on with it and again make prs too big to review.

Honestly I have no hope that this will go well now but I am morbidly curious to watch. I've never seen anything like the train wreck that we are about to get experience.

New pull request rule:

If there are more comments than actual code... REJECTED

Nobody wants your novel on how you came to the conclusion that "_canHazStuff()" is the best possible name for the method.

Most incompetent coworker of the week made a pull request, title: "Adding secrets.ini needed to run $app."

He just copied it from the server and removed the `*.ini` entry in the .gitignore. Luckily he only had access to the dev instance (to copy passwords from).

So this just happened... This is a PR I just got, fucking lazy developers...

this kind of pull request reviewers.. lol

Another pull request for Ressurection Remix fixing a huge issue with 1 character change.
It helped a lot of people.
I have the good feeling when you help people. Oh i love it.
Also IDK but apparently lot of people with lot of stars started following me for no fucking reason. WTF is going on ?
I didnt touch github in few months and 2 follows.

Submitting a pull request seems a good way to end the week. That's what I love about (some) projects on GitHub; instead of just ranting about bugs or out-of-sync documentation, you can fix the problem and send a pull request upstream. :-)

Code review, intern style:

Intern: Here is my pull request ...
Colleague: I see a problem with x, y, z. Could cause memory leaks.
Intern: Oh yeah you are correct, i'll fix that in the next one.
Intern: *merged*

Freaking love it when devs from other teams work on you code base and implement components you already have ... Don't talk to each other, just submit your awsome code and leave a mess behind. But OK ... Just a simple click on Pull Request -> Denied!

My new co-worker is extremely stressing. I have to give small tasks so he won't forget to do anything. I also have to explain what he has to do in detail, give him the full solution, and show him exactly how he has to do it.

And he has no idea how to use git. He makes a feature branch and pushes all his various, half-finished features into it and makes a pull request.

And then I still have to refactor his crappy code everytime cause he uses variables like $data, $accA, $accB, $accZ and forgets to use the definied color variables in sass.

I literally have to do my work and his as well -_-

Man, contributing to open source projects seems very intimidating to me.

I have never contributed to one of those repos on Github with a shit-ton of stars and a load of watchers. Made up my mind to start sometime around the start of September. Looked up a repo that I was very excited to contribute to. Went through their really large codebase, tried to understand as much as I could (They have a fair amount of documentation, but I just can't understand a lot of design decisions that were taken). Looked up one of the open issues marked for newbies, went through the relevant code to understand where and how I would have to make my changes in the code, and was about to start... when a seasoned contributor submitted a pull request.

This same occurrence has repeated itself 3 times now. If you mark an issue for beginners, maybe let the beginners handle them? Also, if you plan to contribute to an issue, why not announce your intention to do so? Get the issue assigned to you, so no one else ends up wasting their time coming up with a solution.

I would love to recommend this to the contributing team, but I am just way too scared to initiate a conversation with these guys. I mean, they are way more experienced and knowledgeable than me (some of them are even famous!).

I am definitely out of my depth with this project, and maybe should look for an easier one, but I really want to rise up to the challenge. Guess I'll stick around then, just waiting for my chance. :|

Git on Visual Studio is so dumb

I wanted to do a Pull Request, and when I checked the request, a conflict prevented from auto-merging and ask to resolve it in Visual Studio.

"What conflitct ?" I asked.

"You're on your own, fam" Visual Studio answered.

Real sweet.

*working at a project, currently creating commits and pushing to remote

I created an early PR with a title [UNFINISHED] and [NOT YET DONE]. I'm really not finished yet. lots of stuff still need to be committed and pushed to repo

And suddenly, I find out that my team mate - just out of the blue without any prior warning - MERGES THE PULL REQUEST

"oh hey there are conflicts in the pr you made"

YEAH WELL MAYBE TRY GETTING YOUR HEAD OUT OF YOUR ASS WHAT IS WRONG WITH YOU ARE YOU EVEN SANE

So now what happened is half of my commits are merged, he didn't tell me, i pushed more commits, branch recreated, and then he reverts the merge. so now everything is really messed up :)AS)D(F)AEF)SDF)AW)sfdjsigkl;zfghlkkj ghaslkj;gabsd;lkgjabslkfgh GET YOUR HEAD OUT OF YOUR ASS I WANT A PROMOTION

Yesterday I fixed three issues in one pull request. I call it a hack-trick.

A pull request with 6000 lines changed, with mixed fixes and new random uncorrelated features.

>Be me
>Decide to contribute to an open source project for the first time
> Nothing big, just a simple compile error fix
>Make first ever pull request
>Over weekend pull request accepted
>feelsgoodman.jpg
>Take a look at recent commits
>Module I tweaked was finished in a commit 6 hours ago
>Fix no longer relevant

So close.. :(

Recently I've started thinking about how we are always told "No you can't do that" to everything. That feels like a theme in our industry.

I've also been thinking about how often people say well done to each other, or just comment that something is good in a pull request. Everything is always focused on bugs and mistakes - not good bits.

The first point conflicts with the idea that when using languages and frameworks you should follow their philosophy or you're gonna have a bad time - but in all other instances you mostly don't have wrong answers, just answers that can be better so a lot of stuff is opinion based.

I've decided to change my ways and focus just as much on good stuff as bad when I review code and to make sure I'm focusing just as much, if not more, when people do something good.

I think I do a good job, but I don't think I've been told I'm doing a good job or that anything specific is good more than a couple times in the last year - mostly in mandatory reviews. What about you?

Reviewing the code of my then new CTO, who said "I can also code and have experience in Java" - 50 lines of code, I added over 30 comments to his Pull Request. In the end, I rewrote his complete code.

It's the last day of hacktoberfest and I got to know that my repository was listed in digital ocean's list of "top repositories with highest number of pull requests".
Feels good :D

On Tuesday my client states she will get me one more piece of info I need to launch the site.

On Wednesday, nothing.

On Thursday, nothing.

On Friday she berates me that the site is overdue and demands it be launched before Saturday so she can send the announcement email.

I remind her that I was waiting for the information.

She responds, testily, that the info wasn't mission critical after all and to just insert something as a placeholder. Oh, and that there had been a religious holiday and so nobody would have been available to respond to the information request anyways. Like I'm just supposed to know all that without anyone telling me.

I'm now trying to get the attention of our overseas developer, who is the only person who can pull this off, but he's likely clocked out for the weekend.

I'm so mad right now I'm about ready to burn the whole site to the ground, cut my losses, and just walk away. But that would damage my reputation.

Today I had to teach a product manager how to use git. It took about 30 minutes to create a proper pull request. Then another 30 to update it when he fucked the change up.

It was a one line change...needless to say I was internally screaming after the first 10 minutes.

I once made a pull request fully aware that 3 tests were failing. The PR was approved and merged.

In my defense, they were very complicated tests and I fixed them a few days after.

For a long time, I wanted to be a part of open source communities. I've been a dev for 6 years now.

I have the skills needed to help out but usually I'm fairly unexperienced on working with big teams, code reviews, and build-test systems they often use. So I'm scared as hell to even begin with. I feel unsecure to reach out and ask for helping or send a basic fix / pull-request.

What are your suggestions, how did you start working on open source projects?

Teach me senpai.

Had a guy put in a pull request with an empty file diff. He comes by two weeks later and asks when am I going to have time to review it.

If I had to name one of my weaknesses it would definitely be impatience.

When I'm working on a backlog issue I want it to be done, finished, pronto. In the real world that's ofcourse not always the case, I can't disturb my colleagues with every question or ask for feedback every minute. I also hate it to have to wait for someone else to do something for me if it's blocking me, like when I need to fix something on a server but don't have access or when I somehow don't have permission for something and have to wait for someone to come and fix it. Even worse: Slow programs that fuck me up when I _just a second ago_ figured out how to fix a bug or implement something.

I also have to wait for pull request reviews so I usually end up with a bunch of stacked PRs that all feature small changes but are dependent upon each other because I needed a change for a different change, never more than 2-level stacks though!

Obviously it's a bit childish to lack professional patience, but it's definitely something that I wanted to rant about and think I should grow in.

I have a co-worker that reports problems by saying "this is broken" or "your change looks bad" and nothing else. There's no recognition for hard work on my team in general, but this guy is a gadfly minus the Socratic benefits.

Did you improve code quality across the project? He'll complain about a function you wrote because he doesn't like how it looks in the code when called.

Did you go out and meet stakeholders so you can learn what your team is supposed to have in the way of milestones and a timeline? He'll complain that it's all impossible and offer no alternatives, solutions or really any new context.

Did you follow your designer's advice on how to handle a corner case in your software? He'll chastise the fact you committed the code to do it in the next meeting because of how bad it looks.

Did you catch him doing one of the things he complains about? He'll complain about you holding up the pull request when we all have to keep moving.

Are you trying to get a task-related question answered in a meeting? He'll interject a sudden argument about code and how easy it is... when he thinks you'll be the one to do it. Very quiet when no one's name is on it, or his name is on it.

Any advice on how to handle guys like this?

A dev joins the project. I help him set up, and he has everything up and running. I give him a task to fix a CSS issue, I even tell him what needs to be done. Almost 4 hours later I begin to wonder what's taking him so long and what is he up to. He finally sends me a pull request with just one line of code changed, and leaves for the day, over 45 mins earlier than supposed to.

When it comes to nervewrecking situations, what I've encountered so far is a pull request for which the 2 reviewers had opposite opinions.
Something like this:
* opens pull request *
reviewer 1: "update using approach A"
* updates code *
reviewer 2: "this is wrong, change to approach B"
* updates code again *
reviewer 1: "this isn't what i asked for, i'm rejecting your PR"
Oh, also, each of them had their own set of coding standards.

What was your most challenging situation when writing code?

Do not, I repeat... DO NOT approve a pull request that you cannot adequately review. You're more to blame than the person who wrote the code in the first place when it fails.

Achievement of the day: breaking GitHub doing a forced push.
(Apparently I was able to create a kind of ghost commit that randomly appeared and disappeared from a pull request, plus other random errors 🤪)

The moment when your teammate raises a 150+ file pull request on Friday evening and marks it as urgent.

Trying to resolve merge conflicts and you cant remember which changes are the ones you want to keep. Lesson learned, make sure your pull requests dont sit waiting for weeks while master is happily being worked on.

Teacher in college:"Comment EVERYTHING"

Lead dev doing my pull request:"Why is there a comment in your commit!?"

Last week,my friend asked me to fork and pull request on his github repository so that he could review my changes and merge them,I had included some more exciting features in his app but till now he has not merged my request,instead he just copied the changes I made in his repo into his repo manually and updated his project,still he has not merged my pull request!!
That guy is a genius!

Yesterday
Me : Hey, I'd like to do a pull request, but there's something that might not help, you think you can help me solving it before I finish that task ?

Worker : *no response at all*

Today
Worker, by mail : Hey could you do a pull request ?

Me : ... 凸(⊙▂⊙✖ ) thanks for answering my question, edgy bitch

Every fucking day I'm asked some fucking stupid question that could have been easily figured if this fucker took 2 mins to look.

"Hey why isn't the issue closed with your commit message? Is it because the CI fail?"

No you dipshit. It's because it hasn't been merged into the master branch. And no the CI didn't fail. If you took 20 seconds to actually look into the pull request you'll see it passed.

God why?

🐙/* Friendly reminder */ 🐙

Don't forget about Hacktoberfest, a great way of giving back to the open source community 👨‍👩‍👧‍👦. And remember, if you create at least 4 pull request you'll get a t-shirt! 👕👚

!(isRant(thisPost));

Submitted my third pull request today in just a couple months as an intern, got told I'm doing a great job and already being considered to move to a more in depth dev team. Honestly a dream come true. Great company, great people, and I have a solid shot at a REAL full time dev position after college. I'm so happy man all that work finally paying off.

I was thinking maybe I could learn Swift. Then I saw the accepted pull request about deleting i++ and i-- operators...

Seriously wtf, i mean OK setting them as deprecated, but deleting ? Dude no

Working for a company with solid procedures really makes me appreciate how important they are. Knowing someone will be scanning through my pull request made me *really think* about appropriate layout and commenting. Before I could submit any old code and the other programmer wouldn't give a monkeys.

I guess that's a poor reflection on my performance but, I'm working on it

When the intern blocks my pull request to ask another stupid question

GIT COMMMIT LOG VERSION 011
-------------------------
4cc7d0d Derp, asset redirection in dev mode
6b6e213 Lock S-foils in attack position
1e44549 I am even stupider than I thought
2f6bec9 You should have trusted me.
891851a To those I leave behind, good luck!
3367d77 Update .gitignore
46d6b0f Merging the merge
b12f6fe First Blood
0598e4f 8==========D
9151ff4 Finished fondling.
3a0ec1e ...
8358c20 c&p fail
bc1e834 magic, have no clue but it works
31bb17a I don't get paid enough for this shit.
21edb91 :(:(
7a71610 Stephen rebase plx?
2060661 Copy-paste to fix previous copy-paste
21ac5d2 Handled a particular error.
2dedd90 pam anderson is going to love me.
c3d4c83 omg what have I done?
d38bafd Herping the derp derp (silly scoping error)
e461773 Merge pull request #67 from Lazersmoke/fix-andys-shit Fix andys shit
1faf82b Is there an award for this?
1f6e3f3 Feed. You. Stuff. No time.
6f0097d I'm too old for this shit!
133179e I'm just a grunt. Don't blame me for this awful PoS.
d3e5202 harharhar
57d9a7c THE MEM TEST FUNCTION YOU ARE LOOKING FOR, IS HERE. SAY THANKS FOR THIS COMMIT MESSAGE

Today I solved the problem assigned to me by changing one character. Simplest fix ever. Except that this problem is not on my project, and I don't have control over this project, so I can't merge my pull request or deploy the code, and the dev that does hasn't answered email today, and he's not scheduled out, and he's not in his office. Whatever, I'm just gonna say it's fuck it Friday and call it a week.

PR used to mean public relations to me few months back. Now it just means pull requests to me.
The fuck happened. Anyone says we need to improve our PR, I'm like how do you improve a pull request and I end up face palming

We've recently employed a new lead dev that seems to have a problem in that his solution is always the correct solution.

On a typical day, whenever I push code up for review via pull request, every single ticket I work on, he has something that has to change which doubles the amount of time of each ticket.

I'd be fine with this if the other 2 developers also think he's a bit of a headache in terms of his opinion but a lot of the time, there is always.. ALWAYS something that has to change because his method is better than mine.

For example, just now I pushed up some code that literally just adds in the user's email to the view which is already in the store for that action/effect anyway. I added one line of HTML.

He comments saying that I need to change the way it gets the email by doing a different request in the effect, to get the current user id, and from that match it against the email address, and THEN display it in the view.

This ticket took me 5 minutes. He's making me make it 30-60 minutes (to understand his requirement and implement it).

Is this normal? Am I over reacting?

Opinions please!

When working on a pull request for a rapid-moving project...

A collegue did a pull request with: if (isset($i) && $i != null) 😂😭😭

Can I submit a pull request to change some annoying bugs in my colleagues?

The euphoria when your pull request gets merged

So I did a code review for a colleagues pull request and I've noticed that he hasn't written the PHPDocs for a lot of the classes and functions. One minor thing I wrote is to add the author for the class.

About 2 mins after writing that comment he came over to tell me why should he write the author in the comments when people can just go look at the git commit logs. I was like WTF? I asked why would he do that, his answer was that if there's an issue, we can just use git blame to identify the author. To me that makes no sense as git blame isn't supposed to be used like that.

It's guys like these are the ones who don't document anything whether in an online document or even in code. And they just make work harder for the rest of us.

Every time I put in a pull request ☹️

Recently graduated and in a job. Had a pull request merged with no comments or changes asked for by the code reviewer today. It's the little victories.

That feeling of giving birth to a child, when the pull request on which we are working for a week is finally merged into master. 😂😂

-----------Jr Dev Fucked by Sr Dev RANT------

Huge data set (300X) that looks like this :
( Primary_key, group_id,100more columns) .

Dataset to be split in records of X sized files such that all primary_key(s) of same group_id has to go in same file.

Sde2 with MS from Australia, 12 years of 'experience' generates an 'algo'. 70% Test case FAILED.

I write a bin packing algo with 100% test case pass, raises pull request to MASTER in < 1 day. Same sde2 does not approve, blocking same day release.

|-_-| What the fuck |-_-| Incompetent people getting 2x my salary with <.5x my work

Not to burn professional bridges every time I have to review a pull request, not the biggest challenge but the one I face more often.

Issue about adding squash feature for git pull request merges on Bitbucket has been open for years...

Bonus level: you have to use Bitbucket

Just submitted my first pull request ever. Now that's exciting (for me at least)

Just reviewing a critical pull request in one of our production apps.... wait, what?

When someone actually commented on my pull request, rather than just clicking approve without reading it.

Some cheapskate insists on writing a guide to selfhost <software> on Heroku and wants to add it to the official documentation, promising to maintain it (since none of the other devs are using or planning to use Heroku). I volunteer to give them a chance on grounds of it being high quality and maintained by that person in the future which they both promise.
Our docs are written as markdown files on github.

So here we go:
Starts a pull request: uploads their """guide""" as a docx. The content is completely unformatted, basically just an enumerated list.

Tell them to format it as markdown, suggest using github gists.
They go ahead and copy pasta their unformatted list into a gist.txt "allright i made it into gist for ya"

Tell them that they did not format it as markdown.
"sorry updated it in markdown :P"

I look at the file, it is still raw text in a gist.txt. Maybe a bit more spaced out, not that I would care to notice any changes at this point.

Tell them it is still not markdown and link them to a perfect example of another guide that takes advantage of code fragments for commands etc and is properly rendered since it uses .md

"I updated it to the markdown this time XP Can you give me some suggestions on how it looks?"

"How it looks"... "how it LOOKS"... I click the link for the 5th time and IT IS STILL JUST A RAW FUCKING GIST.

Jfc that person has some serious reading/thinking disability. To imagine them to be proactively keeping their guide up to date in the future is absolutely impossible. At that point I pulled out my support for the request since it was already taking more effort to even get a readable version of guide than I estimated for the whole process of adding it.

Oh, and one of the steps originally suggested in the """guide""" was adding the credentials file into the vcs.

The last communication we had was me asking you if you would like a service for that, with no response? And now, ten days later, you’d like an update on when it will be available?

Well I raised a pull request on your side a week ago, your developers have just been ignoring it.

What? No, I don’t know when it will be merged and ready.