Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Get a devDuck
Rubber duck debugging has never been so cute! Get your favorite coding language devDuck
Buy Now
-
Working with a team of interns, pointed out a bunch of unit tests are failing, they said they would take care of it.
10 mins later they opened a pull request to delete the tests that were failing.
fml, fml, fml, fml ... and ... oh yeah fml10 -
I just made my first pull request to an open source repo on github 😊
Just some tiny improvement but still I'm geeking out right now🤓5 -
When you've been getting lots of comments on your pull request and have to keep asking for approval.
7 -
Apparently this guy's pull request claims that his code is "very fast" (Official Linux github repository). I can't stop laughing looking at the file changes xD
File changes: https://github.com/torvalds/linux/...
Conversation: https://github.com/torvalds/linux/...
8 -
A guy who doesn't work on our project anymore, but still checks on us regularly just did this:
- reported a bug
- started explaining what's causing the issue
- realised the problem was in a piece of code written by him before
- fixed his own mistake, committed it and created a pull request
We all had a good laugh.6 -
Found a private api key on a github project. Created a pull request with key changed to “TH1S5HOULDB3SECR3T!iMBECIL5“ comment was “security fix“ i wonder if they accept3
-
that moment when your first pull request to a major deep learning library is merged and you have no friends who understand what that means and to share your happiness!😓
no problem, you've devRant! 😁9 -
Just received my very first pull request on GitHub. Pull request: "Remove jquery as dependency".
* Makes repo private *10 -
Developer creates pull request.
I hold suggesting changes.
Developer creates new branch and new pull request with exactly the same commit.
Another Senior developer approves pull request.
This will be discussed tomorrow morning!29 -
Found this beauty in a pull request(paraphrased):
//Old code:
String externalIdNotFound = "The external ID could not be found.";
Me: The user who'll see this error message won't think of the ID as being external, so please remove that word.
//New code:
String idNotFound = "The external ID could not be found.";
My days of not trusting this guy's competence are certainly coming to a middle...4 -
So my pull request got accepted from a minecraft mod on github, and I made it in to the changelogs.
Am I famous now?
11 -
Manager: "Pls deploy the changes ASAP."
Me: "Right away."
Me: *creates pull request*
... 5min later ...
GitHub: "Some checks haven't completed yet."
... 45min later ...
GitHub: "Some checks haven't completed yet."
Me: *looks into delay*
CircleCI: "Partial System Outage"
——
(╯°□°）╯︵ ┻━┻2 -
I sometimes wonder my English is that bad ...
I reviewed a pull request. I commented on this line of code
a = getA() * -1;
saying that
"I think this logic should be in setA method instead."
When the guy asked me for the review again, the change was
- a = getA() * -1;
+ a = setA() * -1;
...2 -
My computer science teacher won't stop developing on the production server 😭 he switches the branch on the production machine to dev all the time and merges broken code into master. Kill me4
-
That moment when u created a project and quite some folks forked it and continued their own versions, but then you realised that you've made a little mistake back then so now your dumb code propagated across humanity.
¯\_( ͡° ͜ʖ ͡°)_/¯2 -
Just did my first pull request for an open source project ever. And it actually increased test coverage for the whole project 😂2
-
Ahhhhhhhhhhhhh!!!!!!
A pull request I made to an actual open source project got merged. I might actually be a real dev now!
(It was just to remove a snippet config, but still!)7 -
I once reviewed a Pull Request made by a fairly junior developer. They had joined recently, and this was one of the first times they had to touch a bigger part of the code.
Due to a mix of inexperience, new (to them) coding standards and lack of git knowledge, they ended up with a mess of a PR, with a few thousand lines changed, and no way to split it off.
I ended up spending the best part of a day reviewing the whole thing and requesting changes.
Even with the long list of improvements, however, I wasn't sure they would get the magnitude of their fuckup.
So I decided to use a real-world, palpable way to show them what they had done: I went and printed the github diff for that PR. It rendered the glorious amount of 73 pages.
I'll never forget their face, and those of their teammates, when I barged into the room with a thick wad of paper and deposited them on their desk.
At least it worked. I never saw another big, ill-thought pull request from them again.3 -
I have a variable called 'stuff'. It's a test to see if my colleagues really read my pull requests.3
-
I joined a "multi-national" company in middle-east where 90% of the developers are Indian. And since it's a "multi-national" company with 50+ developers I thought they already figured it out. Most of them have 5-10 years of experience. They should know at least how to use git properly, deployment should be done via CI/CD. database changes should be run via migration script. Agile methodology, Code Review - Pull Request. Unit testing. Design Patterns, Clean Code Principle. etc etc
I thought I'm gonna learn new things here. I have never been so wrong in all my life...
Technical Manager doesn't even know what Pull Request is. They started developing the software 4 years ago but used Yii v1 instead which was released almost a decade ago. They combined it with a VueJS where in some files contains around 4000 lines of code. Some PHP functions contain 500+ of code. No proper indentions as well. The web console is bloody red with javascript errors. In short, it's the worst code I've seen so far.
No wonder why they keep receiving complaints from their 30+ clients.11 -
Since it is now the hot topic to talk about, here is my input.
The new python change is a terrible idea.
We should totally start a community python fork that stays 100% up to date with master, but removes that one pull request8 -
Holy shit balls it works (so far)
-
So I’ve been working on a project... well feature for the past year (yes 12 whole fucking months - anti agile I know)
And today I got to merge that bitch of a pull request into the current working branch and deploy it to UAT - no conflicts 😵I think I need to put the lottery on tonight!
And some how, by some stupid lucky roll of the dice it just works.
I have never felt so afraid and delighted in my life!6 -
I tell him to submit a pull request, he just merges his code. I revert it and tell him to submit a pull request, he submits one then merges it himself immediately after...6
-
Emotional roller coaster today.
+ Got first pull request! Hell yeah!
- oh, no, no no no nononono, they pushed all dependencies and temp folders...
fck sake isak, gather yourself
11 -
Oh no, oooooh nononono
they dont delete the branches after a pull request
232 branches? hhhhhhhhhhhhhhhhhhhno
and look at that naming
im intimidated, i dont want to work in this environment. No. NO!
8 -
1. Put headphones
2. Put videogame OST (Chrono Trigger is the best)
3. Start Atom
4. Sacrifice a male virgin to my Code Muse to replenish her mana stock
5. Jerk off seeing a fat granny midget porn
6. Clorophorm and put my coworker to sleep so he doesn't interrupt me to show the FailArm best fails of 2016
7. Atom is still loading, so I curse all the GitHub fuckers
8. Give up and start my emulator to play Chrono Trigger
9. Receive a pull request and realise I need to work and be a productive member of society
10. Goto 110 -
I jump on an existing scala project.
git pull && sbt compile test
Tests are failing.
Me: "Hey team, the tests are failing."
Team member: "That cannot be. They were passing for the the last run."
Me: "Did you run them locally?"
Team member: "No, on Jenkins. It was fine."
I check Jenkins.
Me: "What do you mean it's fine. The last successful deployment was on the end of May."
Team member: "The Pull Request checker always went through successfully."
I check how our Jenkins tasks are configured. It's true that the Pull Request Checker runs successfully yet due to a "minor misconfiguration" (aka "major fuckup") the Pull Request Checker only tests a tiny subset of the entire test suite.
Team members were were fine if their Pull Request got the "Success" notification on bitbucket's pull request page. And reviewers trusted that icon as well.
They never checked the master run of the Jenkins task. Where the tests were also failing for over a month.
I'm also highely confused how they did TDD. You know, writing a test first, making it green. (I hope they were just one specific test at a time assuming the others were green. The cynic in me assumes they outsourced running the tests to the Jenkins.)
Gnarf!
Team member having run the tests locally finally realizes: "The tests are broken. Gonna fix them."
Wow. Please, dear fellow developers: It does not kill you to run the entire test suite locally. Just do it. Treat the external test runners as a safety net. Yet always run the test suite locally first.4 -
Why would you submit a pull request with the addition of such a comment and expect me to approve? What the hell is wrong with you?
-
WHY DON'T YOU FUCKING READ THE CHANGES IN YOUR FUCKING PULL REQUEST???
If you did, you would realize that 50% of the stuff is total fucking nonsense. I don't want to see that you changed "var a = 0" to "var a= 0" just because you can't type with your shitty fingers.
Also, if you did read the changes in your PR, you would have realized that you added a bunch of totally unrelated changes in totally unrelated files.
Fuck! Am I the only one who always tries to produce a clean changeset?? Damn5 -
This one time I developed some useful plugins and a command line interface for the platform we built at work.
Then when it was done I thought it had some good value so I created a pull request to donate it to the platform. That same day I got 3 complaints that my pull request did not conform to conventions and that there was no ticket for it and they complained about the fact that it made their jobs harder.
It was in fact the last time I developed something for work in my spare time.1 -
A badass pull request review comment: 'A wise man can learn more from a foolish question than a fool can learn from a wise answer.'2
-
[ Coworker walks up to my desk at 4:15 PM ]
Coworker: "Hey man. We had to make a few changes to the codebase because one of our unit tests were failing. Can you take a look at a pull request for me?"
Me: "Yeah sure, how many files?"
C: "About 600"
Me: [ thinking it might just be a ton of libraries or gradle shit] "...ooookaayyyy... that's a lot but doable... how many lines?"
C: “128,000 lines"
Me: "Fuck you"11 -
Contributed to a open source project for the first time what hasn't been updated in 3 years and my pull request was just accepted!5
-
Sex feels good and all but have you ever felt the pride of submitting a bug fix to software you use on GitHub?4
-
Today I had my first decent pull request accepted.
It wasn't the biggest problem, but it made a chrome extension not work, and the author and other users couldn't figure it out.
The author seems very chill and called me 'the man' and offered me a drink.
It felt nice.1 -
Submitted my last pull request, said farewell to my team today... *weeping*... haven't realized it would be so hard. Oh, well, best of luck my friends, and keep my code running ;)4
-
My biggest mistake in my life.
Boss: So when are you gonna finish this?
Me: I'll finish it today,
Me: Finishes task and submits pull request
- The Next Day-
Team Lead: Oh bro you gotta put this on a separate file, this change this too, and that, don't use that shit use this instead, oh and yeah, you can probally use this 'totally awesome typescript decorator' here for that.
Me: Refactors code intensely
Boss: You said this going to be finished yesterday
Me: FML13 -
Everyone complains that a certain developer's code is not up to standard and when they have to take over his project the lack of code quality is really slowing them down.
I look at code, agree it is poor quality and put together a learning plan for said developer.
Also look at who approved every pull request which allowed bad code into our codebase. Same developers as those complaining it's no good. You had your chance to stop it!9 -
#prank
New guy on the team, learning WPF.
He forgot to lock his computer when fetching coffee. I added a transform group in the main window and checked it in to Git. Locked the computer.
He comes back, furious at his computer for turning the application upside down.
Next two hours he was rebooting, flipping the screen, stressing, googling until I finally had to confess.
He uttered a strange sound of short burst of laughter concealed in a relief of not going insane.
It was a good day.
His pull request was rejected.2 -
Let me make a small change to this file, a one-line pull request will probably be accepted right away
* saves *
Prettier runs...
EsLint runs...
StyleLint runs...
60 changes submitted for review11 -
I started a new project with a backend guy and another frontend like me.
This other FE is 35 years old.
He told me he works as Technical leader before.
This was his first PR ...
8 -
Felt so awkward today. Bare in mind I am still a junior. I was on a pull request reviewing session on a repo I use. I was being super super pedantic with variable names, data types etc as the people who wrote it are brand new to the company. I then realise I had just reviewed the companies lead developers PR to a different repo. Every time someone comments on a PR on this repo all developers in the company get an email notification. I sat there litrually sweating, bright red with the words 'oh ****' on an infinite loop in my head, staring at the screen waiting to see what was to happen.
Thankfully he was ok with the comments. But now people keep calling me the lead developer (teasing) fml I hate anxiaty2 -
It's 35 degrees. Reviewing pull requests or finding a beer garden was the easiest decision of my career.8
-
Please, stop being afraid of git rebase.
Please stop merging master branch into feature branch just to fix pull request conflicts.2 -
Friend of mine: so I wonder how do you test your applications in the startup?
Me: testing? *grabs his coffee laughing*
Actually we have a complete build pipeline from commit/pull-request to dev and production environments. No tests. Really. We are in rapid product development / research state.
We change technologies and approaches like our underwear (and yeah, this is frequently). If we settled some day and understood the basic problems of the whole feature palette, we'll talk about tests again.4 -
If you're going to request CRITICAL changes to thousands of records in the database, and approve it through testing which is done on an exact replica of production, then tell me it was done incorrectly after the fact it has been implemented and you didn't actually review the changes made to the data or business logic that you requested then you are an idiot. Our staging environment is there to ensure all the changes are accurate you useless human. Its the data you provided, I didn't just magically pull it from thin air to make yours and my job a pain the ass.9
-
The new mobile app codebase i'm working with, was clearly written by someone who just read a book on generics and encapsulation.
I need to pull out 2 screens into a separate library to have it shared around. The 1 networking request used is wrapped up in a 'WebServiceFactory' and `WebServiceObjectMapper`, used by a `NetworkingManager` which exposes a generic `request` method taking in a `TopLevelResponse` type (Which has imported every model) which uses a factory method to get the real response type.
This is needed by the `Router` which takes a generic `Action` which they've subclassed for each and every use case needing server communication.
Then the networking request function is part of a chain of 4 near identical functions spread across 4 different files, each one doing a tiny bit more than the last and casting everything to a new god damn protocol, because fuck concrete types.
Its not even used in that many places, theres like 6 networking calls. Why are people so god damn fucking stupid and insist on over engineering the shit out of their apps. I'm fed the fuck up with these useless skidmarks.3 -
I've been neglecting my 150 stars github library for the past month because I don't have time... Feel bad about it (9 open issues 1 nice pull request and one behind example library)2
-
How the hell does PR containing production secrets and private keys gets 3 approvals and gets merged upstream? 😬 🥴6
-
Time to do a little bit of shaming:
I'm specialized in e-commerce applications, mostly based on Shopware, a german out-of-the-box online-shop. They essentially claim to be a better Magento. In December of last year I found a critical issue within the code. Products within the shop can be declared as digital wares. In that case the purchase of a product will unlock the possibility to download a designated file.
As a customer you can access your downloads within the account section. Now here's the problem: The query that fetches the unlocked downloads for a customer is hard-capped at 500 rows. So after your 500th purchase, you won't be able to access any further files you paid for. Essentially their developers thought that this limit would never be exceeded anyway and called it a day.
Personally I think this unacceptable. For the merchant this is a potential law-suit in the making. So I took the time to refactor the code and fix the issue. The corresponding pull-request was flagged as scheduled back in December. Since then there have been numerous releases and the issue is still present. Not only do I ask myself why I should ever put in time and effort to fix their code again, but I also can't believe that they just chose to ignore the issue completely. Also mind that this is not just a small or non-profit open-source project. The responsible company behind the software is a stock corporation that claims to be the market leader in Germany.
6 -
Hello world!
I wrote my first own contribution, pushed, made a pull request and merged to master today all by myself at my trainee job!
Success!1 -
Today I found an error in how we handle credit on invoices in our software.
This is the first time my boss has ever made a legit pull request for me to review of his.
Damn I feel proud!1 -
So, I just realised that a contribution I made to an open source project 12 days ago had gotten accepted 3 days ago. I'm so ecstatic over this!
I was basically just in need of type definitions for a javascript library, and seeing as it didn't have any, decided to make them myself. Done that, I made a pull request, but seeing as there was no changes after a few days, I forgot about it.
Now I just remembered about that, and wondered if it got any comments or anything, and it turned out that they had accepted my PR and it had already been put into a release 3 days ago
I can't contain myself right now, it was my first open-source contribution, and it just feels good to know that I somehow helped some people by giving them type definitions :D
Cheers1 -
Looking through our gitlog today and see 3 PR's from our "lead developer". 2 of these were removing a single blank line from a class, and the 3rd was adding one back in. None of these had any title or commit messages on the PR's. This is a guy that talks down to everyone and deliberately makes other devs feel insignificant, saying he's too busy to write documentation and it's not needed because his uncommented code is self documenting. But hang on he's not too busy to waste time with pointless non-functional PR's that only remove a couple of blank lines? Scratching my head in disbelief that some devs think they can get away with shit like this. How about you drop the ego and actually try and work in collaboration with the other devs.2
-
When your devs comment their pull request "fixed" but fail to push the fix to the remote... For the 5th time in a row. 💩😒
5 -
When you work hard for something and you are sure that you gonna get it, but some ass licking guy who doesn't even know how to code gets it. Yes, it happened to me. I was working for an open source organization called PROBOT. I was working my ass off to get into GSoC with that organization. I created PR(pull request) after PR and solved most of their issues. But later on, I came to know they didn't even saw my single PR. Life surely teaches you some hard lessons but it's you who should not give up I would say. I do not regret working my ass off and writing those code and not getting into GSoC but I cherish those moments where I learnt many new things. And as for that organization, I would say they don't even know how to manage. This was my exact reaction when the result came
3 -
FYI rambox users: My pull request got merged and as of version 0.6.0 devRant is now one of the pre-configured services 🎉2
-
Gonna make a pull request for Project!
"How to Project:
npm install
npm test
npm run start"
npm install: warning, warning, deprecation, warning
npm test: 30 tests, 15 failed
npm run start: error, C stack trace
Pull request status: on hold4 -
CAN SOMEONE PLEASE TELL ME HOW TO TRANSLATE PULL REQUEST TO GERMAN?
According to one of my teachers I have to translate this in a coding guideline otherwise other devs might not be able to follow the procedure...
I asked him how he would translate it and he could not give me a proper answer... describe it he said...
How the fuck does it improve my guidelines if I describe PR!!!
And if your not capable of doing it better how should I know I have to do it!
Sorry I looked at an old exam and got triggered when I saw the correction21 -
Building a pull request on our Build Server takes 14 hours, it can do about 10 builds at a time and there are already 26 builds in the queue and it isn't even 10am.
I've been waiting for a build since I queued it on Friday - because the queue is actually a stack.
And management / senior developers are like...
7 -
So I was told why a bash with Git isn't allowed in my company.
The people that built the development kit (IDEs, tools, etc) estimated that Git wasn't necessary since integrated in Visual Studio.
They clearly never tried to do a pull request or a rebase then. Good to know.
(a coworker gave me a way to have a bash anyway, so that made my day \o/ but rant needed anyway) -
Co-Worker laughed at me for taking a task on their side project and only them have worked at it. FYI i've never worked as a Dev before and I have a really low knowledge of web developing. Well i finished the task in time and sent the pull request to one of them. Got a 'well done dude, high five'. Feels good man :)
-
So, I got a ticket to make a page using a given wireframe that had submit buttons and other buttons to add more items in the wireframe.
So, I pull the html, hook up the abilty to submit the form and add items, and send it out for review.
One comment on the review.
"Remove the functionality, you'll handle it in the next ticket"
So I commented out the javascript. Guess what I'm doing on the next 10 minutes.1 -
Scumbag BroCow
Uses github to store his family photos
Uses github as a media streaming server
Conceals the repository by a random name.
Ignores pull request and issues made by haters1 -
I don't know if you are called the same on Github and DevRant, but thanks for giving me my first pull request @Paradoxis. I already learned a lot from it.6
-
I was asked to fix a critical issue which had high visibility among the higher ups and were blocking QA from testing.
My dev lead (who was more like a dev manager) was having one of his insecure moments of “I need to get credit for helping fix this”, probably because he steals the oxygen from those who actually deserve to be alive and he knows he should be fired, slowly...over a BBQ.
For the next few days, I was bombarded with requests for status updates. Idea after idea of what I could do to fix the issue was hurled at me when all I needed was time to make the fix.
Dev Lead: “Dev X says he knows what the problem is and it’s a simple code fix and should be quick.” (Dev X is in the room as well)
Me: “Tell me, have you actually looked into the issue? Then you know that there are several race conditions causing this issue and the error only manifests itself during a Jenkins build and not locally. In order to know if you’ve fixed it, you have to run the Jenkins job each time which is a lengthy process.”
Dev X: “I don’t know how to access Jenkins.”
And so it continued. Just so you know, I’ve worked at controlling my anger over the years, usually triggered by asinine comments and decisions. I trained for many years with Buddhist monks atop remote mountain ranges, meditated for days under waterfalls, contemplated life in solitude as I crossed the desert, and spent many phone calls talking to Microsoft enterprise support while smiling.
But the next day, I lost my shit.
I had been working out quite a bit too so I could have probably flipped around ten large tables before I got tired. And I’m talking long tables you’d need two people to move.
For context, unresolved comments in our pull request process block the ability to merge. My code was ready and I had two other devs review and approve my code already, but my dev lead, who has never seen the code base, gave up trying to learn how to build the app, and hasn’t coded in years, decided to comment on my pull request that upper management has been waiting on and that he himself has been hounding me about.
Two stood out to me. I read them slowly.
“I think you should name this unit test better” (That unit test existed before my PR)
“This function was deleted and moved to this other file, just so people know”
A devil greeted me when I entered hell. He was quite understanding. It turns out he was also a dev.3 -
Had a five hour long debate with one of our Senior Developers today about pull request etiquette.
His view was reviewers should always email or call him before adding comments to any of his requests and they should never block them as he should be allowed to code in "his own style" and should be able to approve his own pull requests.
I explained that we have code standards and an agreed PR workflow be needs to comply with.
He then started talking about meteors and plane crashes. Literally no helping some people.18 -
Damn it! today I learnt that GitHub has a tool called Hub - "an extension to command-line git that helps you do everyday GitHub tasks without ever leaving the terminal".
It's been around for 10 years.
And here I was clicking on the link that was sent by the remote after every push to open a pull request 🤦♂️
It even comes with vim syntax support for pull requests.
I'm never leaving the terminal to do things on the GitHub web interface anymore1 -
WOOO THE NEW YEAR IS GOING SO WELL!
I just published my first pull request to someone else’s repository WOOOO5 -
All bugs in Linux kernel removed . for more info check pull request at https://github.com/torvalds/linux/...
4 -
Most incompetent coworker of the week made a pull request, title: "Adding secrets.ini needed to run $app."
He just copied it from the server and removed the `*.ini` entry in the .gitignore. Luckily he only had access to the dev instance (to copy passwords from). -
New pull request rule:
If there are more comments than actual code... REJECTED
Nobody wants your novel on how you came to the conclusion that "_canHazStuff()" is the best possible name for the method.5 -
Submitting a pull request seems a good way to end the week. That's what I love about (some) projects on GitHub; instead of just ranting about bugs or out-of-sync documentation, you can fix the problem and send a pull request upstream. :-)2
-
Another pull request for Ressurection Remix fixing a huge issue with 1 character change.
It helped a lot of people.
I have the good feeling when you help people. Oh i love it.
Also IDK but apparently lot of people with lot of stars started following me for no fucking reason. WTF is going on ?
I didnt touch github in few months and 2 follows.3 -
Me: Is git male or female?
Friend: male.
Me: why?
Friend: it does all the pushing and pulling!
Me: Really? I think we push and pull into git.3 -
My new co-worker is extremely stressing. I have to give small tasks so he won't forget to do anything. I also have to explain what he has to do in detail, give him the full solution, and show him exactly how he has to do it.
And he has no idea how to use git. He makes a feature branch and pushes all his various, half-finished features into it and makes a pull request.
And then I still have to refactor his crappy code everytime cause he uses variables like $data, $accA, $accB, $accZ and forgets to use the definied color variables in sass.
I literally have to do my work and his as well -_-6 -
Code review, intern style:
Intern: Here is my pull request ...
Colleague: I see a problem with x, y, z. Could cause memory leaks.
Intern: Oh yeah you are correct, i'll fix that in the next one.
Intern: *merged* -
I once made a pull request fully aware that 3 tests were failing. The PR was approved and merged.
In my defense, they were very complicated tests and I fixed them a few days after.2 -
Reviewing the code of my then new CTO, who said "I can also code and have experience in Java" - 50 lines of code, I added over 30 comments to his Pull Request. In the end, I rewrote his complete code.2
-
Today I had to teach a product manager how to use git. It took about 30 minutes to create a proper pull request. Then another 30 to update it when he fucked the change up.
It was a one line change...needless to say I was internally screaming after the first 10 minutes.2 -
Git on Visual Studio is so dumb
I wanted to do a Pull Request, and when I checked the request, a conflict prevented from auto-merging and ask to resolve it in Visual Studio.
"What conflitct ?" I asked.
"You're on your own, fam" Visual Studio answered.
Real sweet.3 -
Day 1. Push branch. Make pull request😀
Day 5. Got reply to fix some silly stuff🤡
Day 6. Apply changes. Ask for review again.😊
Day 7. Needed to work for another project for two weeks🤝
Day 25. Came back and pull request and branch were deleted from server 🧐🧐
Day 26. I merge my local branch copy into master and push it to server. So long bitches! 💅💅6 -
For a long time, I wanted to be a part of open source communities. I've been a dev for 6 years now.
I have the skills needed to help out but usually I'm fairly unexperienced on working with big teams, code reviews, and build-test systems they often use. So I'm scared as hell to even begin with. I feel unsecure to reach out and ask for helping or send a basic fix / pull-request.
What are your suggestions, how did you start working on open source projects?
Teach me senpai.3 -
A dev joins the project. I help him set up, and he has everything up and running. I give him a task to fix a CSS issue, I even tell him what needs to be done. Almost 4 hours later I begin to wonder what's taking him so long and what is he up to. He finally sends me a pull request with just one line of code changed, and leaves for the day, over 45 mins earlier than supposed to.12
-
Had a guy put in a pull request with an empty file diff. He comes by two weeks later and asks when am I going to have time to review it.
-
Do not, I repeat... DO NOT approve a pull request that you cannot adequately review. You're more to blame than the person who wrote the code in the first place when it fails.1
-
>Be me
>Decide to contribute to an open source project for the first time
> Nothing big, just a simple compile error fix
>Make first ever pull request
>Over weekend pull request accepted
>feelsgoodman.jpg
>Take a look at recent commits
>Module I tweaked was finished in a commit 6 hours ago
>Fix no longer relevant
So close.. :(3 -
I was thinking maybe I could learn Swift. Then I saw the accepted pull request about deleting i++ and i-- operators...
Seriously wtf, i mean OK setting them as deprecated, but deleting ? Dude no3 -
🐙/* Friendly reminder */ 🐙
Don't forget about Hacktoberfest, a great way of giving back to the open source community 👨👩👧👦. And remember, if you create at least 4 pull request you'll get a t-shirt! 👕👚4 -
Yesterday
Me : Hey, I'd like to do a pull request, but there's something that might not help, you think you can help me solving it before I finish that task ?
Worker : *no response at all*
Today
Worker, by mail : Hey could you do a pull request ?
Me : ... 凸(⊙▂⊙✖ ) thanks for answering my question, edgy bitch1 -
Finally pushed all review changes to that GitHub Pull Request of mine that had been open for months!
Hopefully it will get reviewed soon with possibly very minimal to 0 changes and then merged!!! :D
1 -
When it comes to nervewrecking situations, what I've encountered so far is a pull request for which the 2 reviewers had opposite opinions.
Something like this:
* opens pull request *
reviewer 1: "update using approach A"
* updates code *
reviewer 2: "this is wrong, change to approach B"
* updates code again *
reviewer 1: "this isn't what i asked for, i'm rejecting your PR"
Oh, also, each of them had their own set of coding standards.
What was your most challenging situation when writing code?1 -
Working for a company with solid procedures really makes me appreciate how important they are. Knowing someone will be scanning through my pull request made me *really think* about appropriate layout and commenting. Before I could submit any old code and the other programmer wouldn't give a monkeys.
I guess that's a poor reflection on my performance but, I'm working on it -
Teacher in college:"Comment EVERYTHING"
Lead dev doing my pull request:"Why is there a comment in your commit!?"4 -
Today I solved the problem assigned to me by changing one character. Simplest fix ever. Except that this problem is not on my project, and I don't have control over this project, so I can't merge my pull request or deploy the code, and the dev that does hasn't answered email today, and he's not scheduled out, and he's not in his office. Whatever, I'm just gonna say it's fuck it Friday and call it a week.1
-
!(isRant(thisPost));
Submitted my third pull request today in just a couple months as an intern, got told I'm doing a great job and already being considered to move to a more in depth dev team. Honestly a dream come true. Great company, great people, and I have a solid shot at a REAL full time dev position after college. I'm so happy man all that work finally paying off. -
Every fucking day I'm asked some fucking stupid question that could have been easily figured if this fucker took 2 mins to look.
"Hey why isn't the issue closed with your commit message? Is it because the CI fail?"
No you dipshit. It's because it hasn't been merged into the master branch. And no the CI didn't fail. If you took 20 seconds to actually look into the pull request you'll see it passed.
God why? -
Trying to resolve merge conflicts and you cant remember which changes are the ones you want to keep. Lesson learned, make sure your pull requests dont sit waiting for weeks while master is happily being worked on.2
-
Achievement of the day: breaking GitHub doing a forced push.
(Apparently I was able to create a kind of ghost commit that randomly appeared and disappeared from a pull request, plus other random errors 🤪)
3 -
Not to burn professional bridges every time I have to review a pull request, not the biggest challenge but the one I face more often.
-
-----------Jr Dev Fucked by Sr Dev RANT------
Huge data set (300X) that looks like this :
( Primary_key, group_id,100more columns) .
Dataset to be split in records of X sized files such that all primary_key(s) of same group_id has to go in same file.
Sde2 with MS from Australia, 12 years of 'experience' generates an 'algo'. 70% Test case FAILED.
I write a bin packing algo with 100% test case pass, raises pull request to MASTER in < 1 day. Same sde2 does not approve, blocking same day release.
|-_-| What the fuck |-_-| Incompetent people getting 2x my salary with <.5x my work2 -
That feeling of giving birth to a child, when the pull request on which we are working for a week is finally merged into master. 😂😂
-
PR used to mean public relations to me few months back. Now it just means pull requests to me.
The fuck happened. Anyone says we need to improve our PR, I'm like how do you improve a pull request and I end up face palming -
Recently graduated and in a job. Had a pull request merged with no comments or changes asked for by the code reviewer today. It's the little victories.
-
That feeling when you're finally done with a pretty big PR and ready to go live. You excitedly send it out to a few of your peers, and then... 20 comments! The real work has just begun 😭1
-
Last year, this was in my news feed: https://lkml.org/lkml/2018/6/5/769
Will we ever see this Linus again after the COD bullshit?4 -
Hardest thing for me as Team leader is to teach people in my team, that task is done, when unit tests are written, pull request is created, approved and merged.
Not when their code compiles for a first time.1 -
Hi guys, I’m that good guy MIS who knows a little bit python and got “promoted” to write a warehouse management system in C#, which I have never use it before.
Just now I submit my first pull request to DevOps and got accepted.
Just a small EF core and barcode generators stuff but I’m so glad I made some progress 😬3 -
The last communication we had was me asking you if you would like a service for that, with no response? And now, ten days later, you’d like an update on when it will be available?
Well I raised a pull request on your side a week ago, your developers have just been ignoring it.
What? No, I don’t know when it will be merged and ready. -
I hate how most people here don't have their Github on their account profile. How am I supposed to push request a new file for your repositories saying "Gustash was here!"?3
-
Issue about adding squash feature for git pull request merges on Bitbucket has been open for years...
Bonus level: you have to use Bitbucket
-
When someone actually commented on my pull request, rather than just clicking approve without reading it.
-
When you're trying to climb the commit leaderboard and the lead developeor squishes all the commits in your pull request into one :<4
-
I worked as a freelance for a client and after working for more than a month, he owes me 1500$ and the payment was already due 15 days back
Today he even disconnected me on Skype which was the main source of communication
Now I want to undo my pull request which has already been merged in the master
I still have write access to the main repo, its on bitbucket
Is there any way i can destroy all my commits from the master branch or undo my merged pull so that he doesn't get any of the code
#helpwanted8 -
So I fix a bug and I create a PR, someone reviews it and leaves a couple of comments, I address those comments and push up my updated code thinking “great I should be ok to move onto this big story waiting for me”
Then some Expletive.random(); from a totally different team who has no context of my change comes in and starts leaving petty comments. He literally pointed out 3 different things that could be made private/package-private.
Bugger off and focus on your own team’s work instead of leaving comments about relatively trivial things on my PRs.
Apparently he is well known for this. I can tell we are gonna have some fun encounters...1 -
Created a merge request for a big issue last week. Some dumbass co-workers merged several other stuff for tiny shit issues that lead to many merge conflicts now because they didn't pull before..
Nevermind.. will be merging develop into my branch for the third time now.. Got already 20h of extra work because no one minds to merge my request because it's so big and someone might have to check the commit messages what really happened..
Conflicts suck! Co-Workers suck! -
I finally found something to rant about! So what happened is that I am participating in the Digital Ocean competition (I need to do 5PR's). So I find a report with a lot of scripts. I decide to contribute and write a discord webhook API (send messages through a webhook). The next day, the guy goes "No thanks :)" and closes the PR. Words cannot express how triggered I am. I ask him if I can make anything else out of exasperation (I did not intend to do anything for him anymore, I can't explain why I did that), he tells me no...
;(3 -
"Sweet, I fixed story 1 and can commit! ...but issue 2 is pretty small, let me just work on that first so there's 1 pull request".
4 hours later, issue 2 not done yet, and I can't push push story 1 to QA until I finish it. I really need to stop doing that.4 -
This is not a rant is more like a general question, first of all some background.
Some time ago I found this repo:
https://github.com/jwasham/...
A repo that list and link all the subjects you need to know with awesome resources to learn as a self-taught student. As the description says is a complete computer science study plan to become a software engineer.
I like the idea and I decided to help as I saw the Spanish translation was in progress.
Then I realized that it wasn't useful for real, as the resources still be in English so I made a propose that can be find as a link in the pull request of the project .
https://github.com/jwasham/...
But now the question :
Would it really be useful for some people to translate this?
I would greatly appreciate your opinion.
Meanwhile I'll continue with the missing with more coffee.4 -
One thing I have truly learned from software development is DON'T REINVENT THE WHEEL. Someone out there may have already implemented such functionalities and if the library is missing something a PR is always welcomed! (Obviously taking about open source libraries)7
-
How do you guys deal with reviewing garbage code?
Do you waste a ton of time, trying to understand the code, so you can write constructive feedback?
Today I wasted 4 hours reviewing something like that and I'm still not finished.10 -
Pull Request Message -
Day 1: "Updates to the UI and the load performance of the page."
Day 127: "shdheiahwjak"6 -
Contributing on github projects.
Especially when my pull-requests finally merged to the original master ^^ -
Co-worker put up a pull-request for his work, with no build file, no readme, no gitignore, and shell scripts for running the app (but not compiling it). O_o
The guy has been using atom editor even though we have license for Intellij for everyone, which .. whatever .. if it works for you...
In our daily stand, people offered to help him add the build files and he was like, "No, I know how to do it, I was just trying to avoid using Gradle until I had to."
It just made me think, "Yea I know you have all these nice screw drivers and hammers, but I'm going to keep using my hands and this stick so I can avoid using tools until I have to." -
This is how we managed to crash GitHub a couple of days ago. Get ready for 2 more crashes in the coming days 😂
3 -
After giving up on multiple attempts to contribute to opensource projects, came to know about 'yourfirstpr' on one of the comments here.
Long story short, a week later and I've made my first pull request to libgit which has been merged :)
Thanks DevRant community 😊2 -
when github autocorrects my pull request message that contains the word splunk.
(or when devrant also decides to) -
Remember this : https://devrant.com/rants/1547095/... ?
FINALLY some updates.
Just to say they deleted the branch I was trying to merge on during the month, so I need to redo the pull request and rebase.
(ﾉ｀□´)ﾉ⌒┻━┻5 -
When you keep on refreshing the tab to see if your pull request got merged but it still says
”Pull requests 1”
3 -
dev: ugh we need to set and implement coding standards
same dev: no I don't need to follow what you just said, it's already clean and readable (it's not) -
So I thought I knew source tree, apparently I do not... Lost a week's worth of work, went to history, saw someone removed it with a commit, and now I'm getting blamed for my own work 'disappearing'. The reason I am being told I am to blame is how I control my branches... So how I do it is that I keep a local copy of the master branch, I keep it updated and monitor it for changes regularly (meaning fetch and pull cause double tap..) before I do a merge, I check for any new code on master again, then using the local copy of master, which I just updated, I pull the master changes into my branch, deal with any conflicts, build and done. Then I request my changes into master once I am happy everything is good.
My question is, clearly there is something wrong with the way I do things, so please source tree users, what is the most fool proof way to pull latest from master so that I don't loose code? 😔12 -
GitHub has launched Codespaces : A feature that lets you code directly on the web {as a virtual Integrated Development Environment (IDE) on the cloud}.
According to the Github Blog: Earlier, to contribute to a project you would need to make a pull request and set up the environment on your local machine according to the requirements of a project. With Codespaces, you don't need to do that anymore. As soon as you click on the code button, the website sets up the environment in seconds.
In addition to Codespaces, GitHub is also launching Discussions : A forum-like feature that lives under your project that allows others to engage with you and other contributors.
Code scanning : With code scanning enabled, every git push is scanned for new potential security vulnerabilities, and results are displayed directly in your pull request.19 -
One of my very first PR's didn't even get a comment and I worked hard on it...
Feels bad man, all I need is some kind of yes, thanks for this, or no, this doesn't fit the project goals.
After patiently waiting, went ahead and created my own gem! No response sucks.
Why does this happen?1 -
When you use Git for the first time and your project from 29 commit jump to 62 for continous error with Pull Request.
Of this new 33 commit, only 3 are REAL commit.
Four hour for reset and fix all The master branch.
But finally all is fixed and i've learned more on Git... (?)2 -
So I made a pull request on a PHP public repo fixing line lengths and adding some spacing for readability. All in the hopes of improving it to follow PSR-2 standards which they specifically say they follow.
Pull request got rejected, reason: "No thanks, the code is good enough."
Lol! 😐Time to move on to others who appreciate help. -
So today I was having this discussion with my colleague regarding a messed up pull request.
Me: are you done merging the remaining branches into master?
Colleague: no, I'm still merging the changes manually.
Me: but why?
Colleague: because the changes will overwrite the changes in master.
Me: but how? It will just conflict and you can keep whichever changes YOU WANT. You can even edit before committing the merge.
Colleague: I'm just redoing the changes manually anyway.
Me: -_- -
Just submitted my first ever pull request on GitHub. Here I am frantically waiting for it to get rejected or take my first step towards the Hacktoberfest shirt 😁1
-
That awkward feel when I ran into an issue on one of Azures SDKs and find the pull request is open and not merged for a few months...
The even better feeling when I realise that particular product SME is _literally_ in the room behind me.
Chocolate is an alternative form if bribery right? -
The hardest part in my job these days is thinking commit and PR messages :/
I believe my code and commits and PRs are always self explanatory, the company doesn't agree apparently.2 -
When Monday comes round and all you can think about traveling to work is the giant pull request you were asked to review on Friday 🙈
-
Question about git: What do you do when you have a massive pull request? This guy I work with made a PR with 13k files out of which 11-12k is basically HTML's that should have been added as an initial commit, and remaining ones are actual files that we worked on. Should I ask him to somehow split his work in two parts?8
-
7th approved pull request in a few months as an intern :) I'm not sure if that's actually good but it feels good so fuck yeah
-
Question: I completed a feature on separate branch. Since I'm not allowed to merge things on the master branch (only pm is allowed to) I open a pull request.
However, PM has decided that he will only accept PRs which can be automatically rebased & merged.
So now i opened my PR and PM says that GitHub complains that the branches cannot be automatically merged.
So I rebase the branch - push and tell him to try again. But the same issue - GitHub won't merge the PR. So I try again - rebase the feature branch onto master which runs me through the same rebase steps as on the last try. I successfully complete this one too and push. But still - GitHub won't swallow the PR.
Anybody an idea what could've went wrong here?6 -
I just reviewed a pull request with a test case like (pseudo code):
# Test MyService
const mock = createMock(myService.myMethod)
.whenCalledWith("foo")
.returns("bar");
assert(mock.myMethod("foo") === "bar"));
Why though? Why are we testing the mock? What is happening here? This test has no reason of being there instead of a fuzzy feeling that we now have unit test to lure us into a false sense of security.
I asked why we don't do an integration test. Response was: "They are slow."
Well, duh, but at least they would actually test something.
What do you gain by asserting that the mock is working the way you set it up?3 -
Just thought of a solution to a problem I'm having with an open source library. Now I can't sleep until I have made a pull request! It's 00:17 and I've just found out my Macbook is dead.
-
How my friends work day goes, I worked at the same firm and on the same project, I dont pity him.
70% debugging
25% refactoring - after his pull request was denied a few times, and had to rewrite that code in question a few time. I think most people go mad
3% test writing
2% code writing -
Pull request of the week: (In simplified version)
a = getVariable()
...
getVariable() {
[Some logic]
a = thisValue
.. or ..
a = thatValue
return a
}
🤦♂️🤦♂️
Tried my best to write a polite comment -
Get ready to launch a feature. Just about to make a pull request. Business be like, oh wait. Something came up, we need to wait a week. Fuuuuuuuuuuuck.
-
Wtf looking at a Pull Request today for styling 4 buttons...
750 lines of of CSS and not even able to style an anchor!!
How the hell is that even possible!!!1 -
So my day's going pretty well, successfully managed to create a pull request for broken code that breaks more code and run into errors trying to fix it, then spill tea all over my desk/self spazzing trying to fix one child problem like 3 levels deep
Pretty sure I'm the office dunce at this point1 -
Picked up an issue to contribute to OSS for a community version of a major enterprise software. Did the changes, submitted a pull request. Someone reviewed it, asked for some changes, which i did and pushed the changes.
Then after some discussion with the guys working there, we thought of making some changes to the UI. Step in the company UI guy, he makes some changes, i merge his branch into mine and submit a new pull request.
Now, a new guy comes in to review the code, who has a problem with every change THEIR UI Guy did, and negates everything the first reviewer said, and asks me to do the changes, and boy was I pissed!!
But I did the changes, updated the PR, then the first reviewer comes in again, and suggests some more changes, most of them are for the code, THEIR UI Guydid!! Fucking psychopaths!! Never had i seen such paranoid people in my life!! Educate your fucking team first!!
I one again started with the changes but left mid way!! Now, even if i want to, will not update the PR!! FUCK YOU!!3 -
My first ever pull request on a public repo on github just got merged. The suspense is killing me. Three more to go for the free shirt...4
-
You just have to fucking love it... Trying to get a pull request merged into our master, but because we *must* use fast-forward-only a single change on the master forces a rebase on my side, and an other complete build which takes some 15 minutes.
And of course the entire dev team is in goddamn overdrive and working their ass off, so here I'm sitting hoping to chance on a 'calm' 15 minute slot on the master without any other merges... Let's try attempt number 5 to merge this sucker. -
So to keep me going through the day I sometimes entertain myself by adding funny comments to my pull requests. I sit there giggling to myself like some sort of lunatic and the rest of the office probably think I'm a nutcase.
Todays gem was:
Added timeout to prevent hanging. Bet they wish they'd had this feature in the 16th century
Honestly I think my talents are wasted here...1 -
Dude i asked you to review my pull request because i thought we were cool. The code change is about a simple rename, SO FUCK OFF WITH THE REFACTOR SUGGESTIONS. STOP DOING THAT TO MY CODE REVIEWS
2 -
Hacktoberfest is upon us! Go forth and pull (request) till you're bloody cross-eyed!
(and don't forget to sign up to be eligible for your t-shirt!)
https://hacktoberfest.digitalocean.com/... -
Writing documentation is one of those tasks that most developers don't like doing. Especially when it comes to writing in say a Word/PDF file, an online wiki, or Confluence. It's time consuming and a pain in the ass.
But even if you don't like it, at least write comments in your source code! I hate having to keep writing "Write the PHPDocs for this class/function" in every pull request that I review. It's wasting my time writing such comments when it's such a basic thing to do when writing source code.19 -
@dfox Feature request: could you add the "pull down to refresh" feature to the notifs and rant windows please? xox2
-
Yeeehaw,
i finally get rid off that over-the-top dependency on Zend\Config in upwork/phystrix
The Pull-Request is on it's way:
https://github.com/upwork/phystrix/...
After 4 years of "this will take minutes to refactor" and "yeah. I totally agree. Replace Zend\Config with Array Interfaces", someone (in this case me) took finally care of this easy to solve issue :)
I hope it will be merged soon into the master branch -
*click 'create pull request'*
*satisfied*
*pat on shoulder*
Will get comments surely, but I'm happy that I could make a PR -
first some background. I'm an intern coming in on the end of my internship (tomorrow's my last day). I've been working on a reasonably important project, more specifically a restful API. We have automation set up so that any commits to master on GitHub are pushed out into a live, accessible version. Some guy (let's call him dumbass) joined our team last week, and has had a few ideas
Dumbass: *opens pull request to my repo*
My boss: *requests changes*
Me: *requests different changes*
(All this before even testing his code, mind you)
Dumbass: *makes requested changes*
Me: *approves changes*
A day passes
My boss: *approves changes*
Me (not even 10 seconds after my boss approved changes): *requests more changes*
(Still haven't tested his code, I just ran A PEP8 compliance test)
Dumbass: *MERGES CHANGES TO MASTER*
Literally EVERYTHING breaks because he was importing a module that's not available
We don't notice until later that day (I'm still working on writing the tests for the automation, for now changes get put on live version even if everything breaks -- tool is still in beta, so everyone working on it (a whole 3 people) knows to TEST THEIR SHIT BEFORE MERGING TO MASTER.)
WHY EVEN BOTHER WITH THE PULL REQUEST IF YOU WERE GOING TO MERGE TO MASTER YOURSELF ANYWAY??!??!??
My frustration cannot be properly conveyed through text, but let's just say this guy's been there a week, I already didn't like him, and then he fucking does this. -
I guess this won't be new to any person here, specially this being a community of well-versed devs. But here it goes:
Its hacktoberfest time!! Make 5 contributions to public repositories and stand chance to win awesome swags and t-shirts from digitalocean.com !! 🎉🎊🎉
I have created a simple repo for beginners . Make a pull request now! https://github.com/root-ansh/...
Do share this message with other awesome devs! Let's make this October awesome🔥💯7 -
pull request that made my day - a colleague of mine wants to make the open world subject to some master. of course I rejected this attempt ;)
4 -
Draft Pull Requests : With draft pull requests, you can clearly tag when you’re coding a work in progress. Next to the “Create pull request” button. Toggle the dropdown arrow whenever you want to create a draft instead.1
-
Made a pull request..review tonight... Deployment tomorrow night.. or morning according to new york time... Hope I don't wake up to pissed off comments in the request.
-
Pull request got declined by a peer because crc32 is apparently not "secure enough". It was used for integrity check of a small binary payload designed to be exchanged millions of times per minute between networked services.
Vetoed the living hell out of that.
-
Commented on a hacky pull request that the junior dev called the same method twice for no reason.
Junior dev didn't get it and asked me to explain in person.
I went over and traced the code, finally he understood my comment. Then he said "Yes, I call it twice"in a tone that as if there's nothing wrong in that statement.
🤦♂️2 -
So I'm working on this codebase that has about 50k lines of code and I built a feature in it today. Spent 3hours on the feature + writing tests. Then I raised a pull request and that bastard codeclimate calculated the test coverage had dropped by 0.3%.
For 6hours now I'm still looking for a way to increase the test coverage by 0.2%. FML4 -
This team mate of mine always finds a way to escape my suggestions in his pull requests.
Today he told me that what I'm asking him is just my personal preference and that it's not a thing just because our formatter isn't powerful enough to do it automatically.3 -
Question about git. I worked on dev branch and made 10 commits.
Then I squash merged 10 commits from develop to master and made a release build.
Now problem is if I make a pull request from develop to master bitbucket will still show that master is behind (because develop has fixes in 10 commits while master has all of them squashed in 1 commit).
Now my question is whats the best way to make sure master and develop are synced (basically that master would have everything what develop has) ?
should I just merge master into develop back after the release?9 -
When it's holiday season and your teammates are on leave, so you have to open a pull request and approve it on your own.
-
I'm about to create a pull request for adding devRant as one of the default services in Rambox. Anybody dig it?1
-
Things that annoy me about my current place:
1 - Only 3 people out of a team of 12 developers are allowed to purge akamai, or merge pull requests to master on any of our 200+ websites. Apparently this is because us contractors are not allowed because the permanent employees have to be accountable for the code.
Despite this, no-one actually reads the code. You just throw up a request in the slack channel and boom, instantly 30 seconds later someone approves it, even if its 500+ lines of code.
2 - I've pushed for us to move to agile instead of waterfall, and got declined (which is fine), but the reasoning was that the dev team are not 'mature enough' to work that way. Half the devs here have 5+ years of experience so I don't get the problem here.
3 - There is zero code reviewing process in place. I just watched as a developer's 300 line merge request was approved within 8 seconds of it going live. No-one is allowed to comment on the code review or suggest changes as this would 'slow down development'. Within that 300 line merge request were tons of css being aimlessly commented out, and invalid javascript (introducing both bugs and security issues) that were totally ignored.
What is your thoughts on these above points?
Am I too narrow minded or is the development manager clueless?1 -
I submitted my first pull request 2 days ago and guess what maintainer closed the issue without accepting and merging my request even 1 day ago I have commented on the issue comment box that I have a pull request please accept.
Not feeling good, I was thinking the hardest task is to find an issue we can contribute to, but the hardest task is, which we can't have control in and that is merging the pull request. -
I swear to god I feel like I'm getting paid to just watch my boss code. My job is more debugging and submitting the pull request for whatever the boss throws together over team viewer.2
-
First pull request to an open source project :D
Well, a small project, without contribution guidelines. -
Not really the worst but it happened last week. Our lead Dev reviewed a pull request based on works that have been validated several times.
Suddenly, 5 minutes before leaving to take a plane for the week, he tells me that everything is to be refactored because it has no semantical sense, even if it worked perfectly and could be refactored later.
He told me that the day before the delivery and rewriting and restesting everything that had been done took 2 days, several out of worktime hours and huge stress phases. The delivery had to be delayed twice.
I'm easily stressed and a lot of things went by with bad timing (one other coder who could help me was not present, another had to leave early for his kids etc...)
That refactoring was unnecessary but it gave a bad impression to our client and made feel bad fr something I wasn't responsible for.2 -
So while reviewing a pull request a see that a co-worker named a variable "em" which stands for employee manager. So I asked him to rename it from "em" to "employeeManager" but he replies - Thats how all variables referencing that class are named in the rest of the app so he is being consistent with the app. What do you think should be done? Do I approve his PR?4
-
So, a new coworker started here about two months ago. He's all about talking but the actions aren't very fast.
I looked at my Pull Request and this guy is writing comments for 5. Where the hell did he get the balls from? Seriously!
Please stand next to the designer so i can slap both of you bitches. -
Vague requirement for feature A received from client
Business consultant refines
Example mapping done
Acceptance criteria defined
Scheduled in sprint
Development done
Unit tests passed
Pull request reviewed
Code merged and deployed to system test
Functional testing successful
Deployed to UAT
Client asked to sign off
Client: "Actually I don't want that feature." -
Don't you just hate it when a git pull request assigned to you doesn't have a descriptive title and no description at all? I think I'm having a migraine! #%!%^*#1
-
People that approve pull requests without looking at them!
No tests or so bad they would do more use by not existing, typos, the code follows none of the design practices and the code obviously will not compile and thereby breaks builds in trunk for everyone.
Because of course they only asked one person to review it and then merged it immediately. -
Jest/enzym unit testing: My lead developer says using shallowWithStore instead of shallow on one incidence would introduce CPU overhead thus I MUST stop whatever I'm doing and fix the pull request. Is that normal?
-
Can you imagine this scary moment while resolving conflict after a pull request that might break your code ?
That's the scariest moment1 -
How to use git rebase when working with master and staging branch?
It might be a stupid question, but I really like the idea of creating a feature branch, work on it, if there are multiple commits squash them, rebase in top of master and then create a pull request from that branch to master.
It keeps the gut log pretty clean.
However, how would you do this, when not only working with a master branch but a staging/testing too?
Would you just rebase onto staging, merge to staging and when everything is fine, rebase onto master and merge again? Is there a netter way?6 -
bitbucket you slow fucking sack of shit, we've confirmed with our remote team members that other people on other networks have it slow as shit too
I really wish we could convince our team to migrate to gitlab or github instead
can't tell if it failed to find the pull request associated with certain commits because it's slow a shit, shit (because it's atlassian bitbucket) or both
there is the small chance that maybe it's just the shit telecom industry in this country too on top of it, but things were acceptable before -
I'm at the moment..... after a 100 commits in one single pull request, days of torturous effort and grappling with a stupid bloated piece of crap software, when, I realise, I COULD HAVE JUST TOLD THE CLIENT TO BUZZ OFF!!!
-
Finish the story and all tests pass
*notification another merge request been approved
Pull changes build, all tests faill
-
The cringeworthy moment when you approve a pull request and a teammate starts suggesting a ton of changes :/1
-
For Ramda (functional JavaScript) enthusiasts -
Anybody, who wishes to collaborate on writing Ramda solutions for SQL like queries, I have created the project (SQL queries, SQLite database, json data files) here - Ramda-SQL-Equivalent GitHub project (https://github.com/ajit555/...).
Please post the questions in "Issues" section and hopefully would get some solutions via pull request.
If not sending pull request, please post the solutions as issues referencing the file name.
Thanks. -
I hate Pull request system!
Plot twist: I just put it in place in my organization because I see the benefit.
Just spent 4 hours (Note : delay was because git refuses to write to stdout and writes everything in sdterr. And couple other things) developing a helper “powershell” script for “small tasks”. It sits directly in the project and as of 30 mins ago available to all devs.
Let’s say you need to change a typo.
Normal process:
• Create a branch
• Fix problem
• Commit/push
• Create pull request (This one was NOT easy. I’ll explain why if someone is interested)
• Switch back to master to fix second bug
Script does exactly that now. ./CreatePullRequest.ps1 <tmpbranchname> <Comment>. (The target for pull request will be the original branch, not limited to master)
Now I’m trying to find what I missed. Because I missed something, 100% guarantied.14 -
Any GitHub gurus here? I made some changes to an existing Java library to get it to work well on Android. I don't want to make a pull request, since that would disrupt the future usage of the original project. Should I just maintain a fork and keep updating it when there's new releases? Thanks.3
-
He did the mash, he did the developer mash
The developer mash, it was a segmentation fault crash.
He did the mash, it caught on in a pull request.
He did the mash, he did the developer mash -
Checker checks my pull request in git... says there's an error but in my laptop my codes are working fine... something must have been wrong there...
-
Is this a justified code review comment or a bully?
Code reviews are weakness of this industry which has the potential to attract bullies. Abuse of the comment box in a pull request and bombarding the employee with hundreds of comments can cause stress, frustration, burnout and finally resignation and costs of fulfillment for the organization. While companies should find and stop bullying in the work place, what kind of code review comment is considered a bully and why? Any of below traits can mean you are dealing with a bully:
1. Claims the code needs to be changed but doesn't say how. So no matter how many times you change your code, he can repeat the same comment: "Your code is still bad due to blah blah and it needs to be changed".
2. Provides how the code should be changed, but the change doesn't add up to quality, security, performance, readability, etc. i.e. "Why did you use a for loop here? Use a while loop instead". Or "Why did you write it using three classes A, B and C? Instead write it using 4 classes D, E, F and G which does blah blah". In the later case, not following the review comment, you won't get approval. Following the comment means you need to rewrite your whole code. After which, you might again receive more comments to change other parts of your code!
3. Claims the requested change is due to standards but claimed standard does exist anywhere. Internet, company wiki, university course books, anywhere. In more severe cases of psychopathy, the bullying person refers you to a link which hours later turned out to be written by himself! Have fun describing what has happened to your manager or team leader... .
4. Asks the code to be changed in a way that supposedly is closer to standard or of better quality, security, performance, etc. But the proposed way will not work and is the main reason you didn't do that in the first place. So you start arguing forever in the comment box over why his method won't work!
If you cannot see any of the above traits, then keep calm, take a breath, fix your code. Otherwise you might be victim of a bully.2 -
Me: 'here we go, code working completely as intended, tested and without bugs.'
Senior after reviewing code: 'apart from the formatting errors, I'd also do this piece of coding in a different manners'
*Comments exchange in pull request*
Me: 'well this seems more like a change the whole logic request rather than a small improvement, I'll keep it like this and resolve it like suggested on a future opportunity'
Still in prod. -
When you need that one feature from a framework, that it just not have. So you have to use a custom version till your PR has been accepted.
I see a possible problematic future... -
I don't get it, why having more than one decorator looks "weird"? that's idiomatic Python AFAIK, that's sounds more like nitpicking on aesthetics :/1
-
When you open all the bitbucket emails you have to process after you spent just a half day doing your own tickets.
-
Completely noob question and before you say it, yes I have googled but I'm tired and I just get walls of text.
How do I merge a pull request?
A nice guy has submitted a pull request to my repository on GitHub, how can I merge it??
I tried what I thought was merging but it said that a file is conflicting. I tried deleting the file and it still didn't merge.
4 -
What to do if the repository maintainer taking a lot of time for accepting pull request of hacktoberfest?5
-
Sumbitting a succesful Pull Request with a couple of commits to a public repo just using GitHub desktop is like playing life in Legend mode1
-
Some background:
About 2 months ago, my company wanted to build a micro service that will be used to integrate 3 of our products with external ticketing systems.
So, I was asked to take on this task. Design the service, ensure extendability and universality between our products (all have very different use cases, data models and their own sets of services).
Two weeks of meetings with multiple stakeholders and tech leads. Got the okay by 4-6 people. Built the thing with one other guy in a manner of a week. Stress tested it against one ticketing service that is used in a product my team is developing.
Everyone is happy.
Fast forward to last Thursday night.
“Email from human X”: hey, I extended the shared micro service for ticketing to add support for one of clients ghetto ticketing systems. Review my PR please. P.S. release date is Monday and I am on a personal day on Friday.
I’m thinking. Cool I know this guy. He helped me design this API. He must’ve done good. . . *looks at code* . . . work..... it’s due... Monday? Huh? Personal day? Huh?
So not to shit on the day. He did add much needed support for bear tokens and generalized some of the environment variables. Cleaned up some code. But.... big no no no...
The original code was written with a factory pattern in mind. The solution is supposed to handle communication to multiple 3rd parties, but using the same interfaces.
What did this guy do wrong? Well other than the fact that he basically put me in a spot where if I reject his code, it will look like I’m blocking progress on his code...
His “implementation” is literally copy-paste the entire class. Add 3 be urls to his specific implementation of the API.
Now we have
POST /ticket
PUT /ticket
POST /ticket-scripted
PUT /ticket-scripted
POST /callback
The latter 3 are his additions... only the last one should have been added in reality... why not just add a type to the payload of the post/put? Is he expecting us to write new endpoints for every damn integration? At this rate we might as well not have this component...
But seriously this cheeses me... especially since Monday is my day off! So not only do I have to reject this code. I also have to have a call now with him on my fucking day off!!!!
Arghhhhhh1 -
Today I submitted to code review the first iteration of a microservice done with Ramda and flow by request of my collegues. This is the first time they look at anything similar to functional code or typed js, and only one of them took the time to actually do a review.
I really like having my code reviewed and reviewing others', but please don't pester me to make a PR for a microservice you'll never look only to bail off as soon as you see something new that scares you. Buckle up and learn new stuff!
Top Tags
Weekly Rant
View