Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
It's quite scary how much shit code like this there is out there. Where did these 'developers' come from? How did they fake it this far?
-
@joycestick This doesn't even touch the sides. This code sits in a project that is pretty much a single form consisting of 3k lines.
-
C0D4681466yWhat language is that?
They can set Bools but can’t use them , I don’t understand how people get jobs sometimes.
== is not ‘usually’ case sensitive anyway ๐ -
There's just so much wrong with this. What are you going to do? Tidy up or ignore?
-
@delegate212 That'll be refreshing. Nothing sweeter than an empty project.
Are you guys using ReSharper at all? It's great for teaching language and style if you're going to be using slightly noob developers on the new project. A little pricey but well worth it for the code quality it brings. It won't stop people using magic strings though! -
@joycestick We do use Resharper. However, the lead who wrote this has since left, in fact I don't believe there is anyone who worked under him left.
-
and i thought I'm the only developer
Who writes worse code ๐๐๐
But this one is legend !!! -
Maybe they thought in future they might need more than 2 states, like Yes, No, and Maybe. ๐๐
-
@NuttLoose assuming they will need three, they can use optional bool value, assuming they don't want to go through constants or at least enums
Damn that's the scariest thing I've seen so far, code compared against static values, one typo and hello hours of debugging
Apparently they'd never heard of bools. The best part is the case check given that they define the string.
rant