2

is it really too much to ask coworkers to use a mf code linter? how many times do i have to fix their awfully written code before they acknowledge how bad they are at their job and start using one?

Comments
  • 1
    I've been both the code linting fascist and the code linting village idiot, which has less to do with me and more to do with the cultures of the various places I've been. Annotating code reviews with every single linting issue is annoying af for both the reviewer and the reviewee. Do you have automated linting tools set up and if so, are they set up as effectively as they could be? Can you have linting be done as a git prehook? That way the reviewee can submit code that's a bit wonky but the reviewer will still see properly linted code, yes?

    (This is a bit theoretical since it's something our org hasn't gotten down 100% either. Currently linting is caught in the Jenkins pipeline and you're not supposed to ask for a review until Jenkins is done, but that's not really a perfect solution either.)
  • 2
    @PaoloMangia @HollowKitty this blog teaches you how to automatically run eslint during pre commit so no 💩could get inside your code base

    https://blog.gojekengineering.com/e...
Add Comment