16
LMagnus
72d

Had a five hour long debate with one of our Senior Developers today about pull request etiquette.

His view was reviewers should always email or call him before adding comments to any of his requests and they should never block them as he should be allowed to code in "his own style" and should be able to approve his own pull requests.

I explained that we have code standards and an agreed PR workflow be needs to comply with.

He then started talking about meteors and plane crashes. Literally no helping some people.

Comments
  • 0
    Should’ve walked away after 5 mins.
  • 3
    I’d suggest giving him an hour of nappy time in the afternoon.
  • 0
    This guy is prolly overworked.
  • 0
    @norman70688 no more than anyone else.
  • 0
    Im not sure I understand, so he doesnt really want to address all of the style comments is that it?
  • 0
    Calling the coder before commenting on code is equal to calling your boss before you are gonna piss
  • 0
    @Pyjong he doesn't want to change any of his code. Even if it's not clear, inefficient or wrong.
  • 0
    > he should be allowed to code in "his own style" and should be able to approve his own pull requests.

    "There's no 'I' in 'team'". Holy crap, does this guy's ego still fit in the same room with him or does it need an extra one?
  • 0
    @VaderNT I don't even think it's ego, I think it's just fear of someone criticising him as he thinks it will make him look bad.

    He needs to understand that a pull request is an opportunity for discussion, not a personal attack.
  • 0
    @LMagnus I see.. hmm. Do you think the comments are ever helpful for him as well? Yknow some people consider code review to be fun and really like to pour out their precious opinion. Maybe check out comments in his previous reviews see why he doesnt like it...
  • 0
    How the fuck has he achieved „senior” level at any company?

    We all have been there. Humiliated, destroyed, offended, sleepless, annoyed by some other dev nitpicking or not understanding our precious creation. But we have job experience and we can achieve some mutual agreement without 5 hours discussions.

    If you are not trained to emotionally deal with a review, you are not a senior.

    And seriously? Five hour debate? Are you his boss?
  • 0
    @Pyjong the comments are fine. For example one was, "it is not good practice to leave commented out code in project, consider removal". This one was a particular problem for him.
  • 0
    @matste I'm not his boss. I'm a Lead Developer on another team but was helping that team out. It wasn't five hours continuous. It was five over a series of Slack messages and phonecalls. He just wouldn't let it go.

    He's actually a really good developer but his attitude sometimes is so frustrating.
  • 0
    @LMagnus huh.. that's really weird. Aight he's got some problem.
  • 1
    Just tell him straight that his attitude is the very reason why the process has been set up that way. Specifically to not allow him to do that shit.
  • 0
    Senior developer: slang for developer without imposter syndrome and a large dose of narcisissm.
  • 0
    @rutee07 something about if one site was wiped out by a meteor then there'd be no one to review code from the other site. Didn't make much sense and not really something I want to add to a risk register.
  • 1
    @LMagnus Couldn't you just make an exception WHEN that happens ? :)
  • 0
    @ItsNotMyFault haha yep that's certainly the approach I'm taking.
Your Job Suck?
Get a Better Job
Add Comment