I cannot spell for shit, so my coworker keeps commenting on my pull requests with spelling fixes...

Decided to buy this for him today...

When you merge 8 pull requests and everything worked without any conflict.

Looks like I'm getting fired on Wednesday :)

Long story:

*I add first unit tests to project.

*Boss adds new functionality and breaks all the tests so I can't compile and write more for what I'm working on.

*Boss is very fragile and cannot handle any comment that can possibly be taken as a slight against him.

Me: "I wanted to ask what our policy on unit tests is please? Because we haven't really said how we are treating unit tests, and everyone myself included is not thinking about them. I also haven't added tests when I fixed bugs and this time your changes broke the tests"

Boss 10 minutes later: "I want to speak to you in private".

Boss: "you are too forceful and direct. You said I should have added tests."

Me: "yeah but I didn't mean in a nasty way"

Boss getting louder and more aggressive: "You are too forceful"

Me: "I didn't mean it in a bad way"

Boss: "I didn't want to add tests for that!"

Me: "then why add any tests?"

Boss: "Fine we are not having this conversation now!"

*Boss storms out

I decided I can't speak to the guy about anything without upsetting him spoke to the manager before I quit because I can't work like this.

That resulted in a meeting with my boss, his boss and the head of HR where I ended up savaging him and told them I can't bring up anything as I can never tell if it will offend him and that I spend ages writing emails and trying to document communications because I just can never tell if I will upset him. Also that I cannot bring up any ideas because I can't tell if he will somehow get offended and that I can't even write code because if I change something he wrote at some point he will get angry.

My boss claims that I am extremely forceful and disrespectful and that I am constantly insulting him and his decisions.

We go back over a ton of shit and I refute everything he says. In the end I have to have a meeting with him on Wednesday where we either get things straight, he fires me or I quit.

I think at this point that our relationship is too fucked for him to be my team lead on a 6 man team.

Side note I keep bringing forth ideas because we have one database shared between 6 Devs, no pull requests (apart from mine and another new guy), no test driven development, no backlog, no team driven story pointing, no running tests before merging, no continuous integration setup, no integration tests, no build step on merge, no idea of if we are on track to our deadline other than his gut feeling, no actual unit tests backend - just integration with a test db, no enthusiasm to learn in the team and no hope.

It has to be the community. Just look at devRant - an open community where - unlike on the rest of the internet - people are friendly and warm. Then there's the concept of open source and GitHub, where people post large and complex projects for free and even the smallest of developers can create issues and pull requests (shouldn't they be called push requests though?) - no other profession will help others out in over 15 million different ways.

Me to a lead dev: hey, I noticed that junior guy pushed this bad code to prod that you approved.

Him: oh really that’s wrong? Ok we can fix it.

Me (cursing under my breath): no asshole, that’s not the fucking point. You should know enough to not approve such pull requests.

I once reviewed a Pull Request made by a fairly junior developer. They had joined recently, and this was one of the first times they had to touch a bigger part of the code.

Due to a mix of inexperience, new (to them) coding standards and lack of git knowledge, they ended up with a mess of a PR, with a few thousand lines changed, and no way to split it off.
I ended up spending the best part of a day reviewing the whole thing and requesting changes.

Even with the long list of improvements, however, I wasn't sure they would get the magnitude of their fuckup.
So I decided to use a real-world, palpable way to show them what they had done: I went and printed the github diff for that PR. It rendered the glorious amount of 73 pages.

I'll never forget their face, and those of their teammates, when I barged into the room with a thick wad of paper and deposited them on their desk.

At least it worked. I never saw another big, ill-thought pull request from them again.

I have a variable called 'stuff'. It's a test to see if my colleagues really read my pull requests.

Why would you submit a pull request with the addition of such a comment and expect me to approve? What the hell is wrong with you?

WHY DON'T YOU FUCKING READ THE CHANGES IN YOUR FUCKING PULL REQUEST???

If you did, you would realize that 50% of the stuff is total fucking nonsense. I don't want to see that you changed "var a = 0" to "var a= 0" just because you can't type with your shitty fingers.

Also, if you did read the changes in your PR, you would have realized that you added a bunch of totally unrelated changes in totally unrelated files.

Fuck! Am I the only one who always tries to produce a clean changeset?? Damn

I'm thinking about doing a live coding stream on twitch this saturday, late afternoon or evening (CET).
I've never done a live stream before.

Do you have any suggestions or interests?
I'm thinking about something like a small RESTful API with Angular4/TypeScript (frontend, single page application) and CraftCMS/PHP (backend) with somebasic theory about HTTP requests / response, redirecting, data transfer and interfaces et cetera...

The duration will be around 2-4 hours, maybe longer if I have enough Mate & Beer.

But it's all just an idea at the moment. 😉

I will create an empty project for the stream on my Github and push to it during streaming, so you can pull it live or later.

Contributed to a open source project for the first time what hasn't been updated in 3 years and my pull request was just accepted!

Real geeks don't send friend requests, they send pull requests.

[ Coworker walks up to my desk at 4:15 PM ]

Coworker: "Hey man. We had to make a few changes to the codebase because one of our unit tests were failing. Can you take a look at a pull request for me?"
Me: "Yeah sure, how many files?"
C: "About 600"
Me: [ thinking it might just be a ton of libraries or gradle shit] "...ooookaayyyy... that's a lot but doable... how many lines?"
C: “128,000 lines"
Me: "Fuck you"

Actually the worst fucking developer experience is meeting those all knowing people who think they know everything but actually they even don’t know how the fucking tools they’re using every day are written and how they work.

Those people that think when they installed library it should do everything how they imagined to and don’t fucking bother to debug problems and create pull requests if it’s fucking buggy.

Those fucking ranters who moan about something they don’t understand.

Those fuckers who think if they understood what A*, Dijkstra, graph algorithm is they’re smarter then others.

No you fuckers you’re dumb as fuck cause instead of explaining it to someone you just blame people for not knowing “obvious shit”.

All those fucking ignorants I am fucking writing about you.
You either start support each other or fuck you people.

Boss never branches. Pushes his commits directly to develop. No code review. No pull requests.

“I Pay $900 A Month for student loans.”

Not sure why there’s a video about this but let’s watch it...

*Sad music is playing*

“My name is _____ and I pay $900 a month for student loans..”

Yeah so what?

*Sad music continues*

??

*Woman makes a call and asks about when they’re going to make a student loan reform aggressively*

????

Then I realized my family was eligible for low income and I received Cal and Pell grants to pay for my tuition and living.

Then I realized that the salary for my computer science degree has numbed me to a point where $900 a month doesn’t seem too bad. Or awful. I mean I just leased a new car for my mom! And didn’t hesitate (only when having fun negotiating though).

Back then, I would be shocked. But it’s a surreal feeling to see now that I don’t. I was literally confused at the basis of this video. And now I’m surprised at my disconnect from it.

I also realized that they make videos based on how society should react to it. Am I an outcast to society because of this? Why am I not reacting the same way?

Maybe society (nowadays) would disdain me because I’ve come into high income like we all will because of our passion (and the demand for it).

But fuck society. It’s full of the very same people who use technology each and every day. Protesting for things they found trending on Twitter. The ones who refused to learn even though it’s a huge part of their lives. They’re the ones holding us back for an Engel’s Technological Utopia (idk if I’m even correct about the philosopher but anyways..)

We’re above them. We make things they’ll use and in massive numbers.

Don’t let them dictate what you should like. How you should act. Whether or not you should feel lonely while they’re posting pictures of fun times on Facebook.

We should be the ones doing that. Because we are the ones doing that.

That’s why we’re given the best to perform what we love most.

So devs, continue what you’re doing. Small or big, you’re still driving the world forward. Opening pull requests and contributing to open source projects. Answering questions on Stack Overflow not only for the person intended but for the beginner or even experienced professional who may stumble upon it later in a Google search.

And be highly rewarded for it. How society feels doesn’t matter any more when it comes to your passion. You’re important. Your work helps others in ways you can’t even imagine. We’re like one big fucking hivemind of engineers with the accessibility of the internet.

I love drinking on a Sunday!

Some people think that in the software industry there is no communication and everyone is glued to their screens doing their work. It really fucking pisses me off.

- We write documentation around our code more than actual code so that we can communicate with other developers better.

- We use version control and pull requests to make sure our work is at the required level and it is approved.

- We invented UML to communicate our technical understanding to less technical people.

- We sometimes have more client meetings than doctors have patients. In which we have deal with clients worse than patients.

- We conduct keynotes and conferences and hackathons to bring together communities.

These are just a few things from the top of my head so next time you think of saying that the IT or software professionals don't have "much" communication you better fucking educate yourself as to what the profession actually is.

It's 35 degrees. Reviewing pull requests or finding a beer garden was the easiest decision of my career.

People who don't make pull requests and decide to directly merge code should be fired.

Felt so awkward today. Bare in mind I am still a junior. I was on a pull request reviewing session on a repo I use. I was being super super pedantic with variable names, data types etc as the people who wrote it are brand new to the company. I then realise I had just reviewed the companies lead developers PR to a different repo. Every time someone comments on a PR on this repo all developers in the company get an email notification. I sat there litrually sweating, bright red with the words 'oh ****' on an infinite loop in my head, staring at the screen waiting to see what was to happen.

Thankfully he was ok with the comments. But now people keep calling me the lead developer (teasing) fml I hate anxiaty

Coolest commit history I have seen!

Time tracking. 😡🤮 If I’m salaried and only working on one project for one client, why the hell should I waste my time making weekly reports of how many hours I spent coding, reviewing pull requests, and sitting in (mostly pointless) meetings?

I hate it when people whine about code reviews. You should never take it personally. We're not against you, we just want good solid code.

I really hate it when it's my boss who's bitching about pull requests. When you throw your hands up and start yelling, "Well I'm blocked, I'm blocked," then you're not helping. You're just being a baby.

If you publish them as version 0.0.1 other developers will issue pull requests

1) HTML turing complete
2) Kardashian programming language
3) EU resolution that forbids accepting and merging pull requests without court order.

Because why not.

In pull requests, I point out every spelling mistake, unnecessary whitespace and formatting issue.

It's not really a bad practice, but my teammates don't like it.

I'm a software developer. Last week I spent half a day teaching a "Senior Data Scientist" how to use git branches. I spent the other half a day teaching him how to use Jira. Now I'm being told that the dev team isn't raising enough Pull Requests. FML

*wakes up *
*checks github *
5 pull requests accepted
"dude you're on fire!"
Feelsgoodman

So I need to let off some steam, let me know if you think I need to calm down. Personally I'm just having a hard time understanding my team lead.

So I've been trying to update our codebase for the past two months so we run tests against the latest versions of each respective major browser. I've also been trying to cleanup our code and split it into logical modules.

Need I add, according to Bitbucket, I've written over 80% of our code on our 4 projects with 4 team members including myself.

He's out for a week, so I decide it's fine time to get some work done -- which is ridiculous in itself. I finish, add unit tests for crap I missed because he kept shutting down my PRs for shit he couldn't understand.

He tells me on Friday, when he got back, that he'll be declining my pull requests because my code is too complex -- my team lead -- thinks list comprehension and OOP in Python is too complex. Doesn't understand why we need to have pep8 lint tests, or why we can't just export one giant monolithic client package with over 3k lines of code.

Is it worth arguing or should I just let my department head know I can't work on this team anymore? He won't get talked to or fired, he's been at my company for 6 years and he's in the inner circle.

I made it! 5 pull requests for Hacktoberfest :) .
I'm super happy because until now I really didn't know how to help other projects or even have the motivation, but now I can say I have helped a few get their code right :P

After you make your 1st PR,
Gsoc is not far away! 😂

Ok bit late but bare with me on this one.
Github and microsoft ?
Do you think they can just do bullshit to it ???
Do you realize that its userbase is only developers who like open-source ?
If they did some bullshit half of userbase would switch if they dont do it after they announce it.
And even still we have looooooot of other git hostings.
What i will do ?
Create gitlab and switch all my repos to it as a backup. And if microsoft makes it an bullshit then i will just leave github and be on gitlab.
I will still have github account since not all repos will transfer to gitlab so i will need account to make pull requests to not my projects.
.

I have discovered a fresh hell

Some guy I’ve never met or heard of in the office lobbed a comment at one of my *approved and merged* pull requests. He doesn’t say anything specific, only that my REST urls are not in line with naming convention. That’s all he says, and I’ve already walked the URL consumers through the code and given them the URLS.

I’m really annoyed that this guy won’t just say what he has in mind, but fine whatever this is a professional environment and developers are not known for being a diplomatic people. Let it go and get your work done!

I do some googling and find an obvious change that needs to happen- I implement it, open a new pull request and inform my URL consumers of the change.

This rando still isn’t satisfied and still won’t say what needs to change. I am on round 3 of this wonderful cycle and this guy is acting all fuckin HAUGHTY about it. “Here is a list of conventions I found googling, you should read them even if it takes 4 hours because it will benefit your career”

Sure dog you’re probably right on that one but we are in a professional environment and at this point you are holding up production so you can wave your dick around! Just SAY WHAT YOU MEAN SO WE CAN MAKE THE CHANGES AND GET OUR WORK DONE

Today was a manic-depressive kind of day. Spent the morning helping some developers with getting their code to run a stored procedure to drop old partitions, but it wasn't working on their end. It was a fairly simple proc. But working with partitions is a little like working with an array. I figured out that they were passing the wrong timestamp, and needed to add +1 to delete the right partition. Got that sorted out, and things were good. Lunch time.

After lunch I did some busy work, and then the PO comes up at about 2PM and says he's assigned some requests to me. The first was just attaching some scripts. Easy. The second, the user wants a couple of schemas exported ... at 6PM. I've been in the office since 6:45AM.

While I'm setting up some commands to run for the data export, a BA walks up and asks if I'm filling in for another DBA who is out for a few weeks. Yep. There's a change request that hasn't been assigned, and he normally does the work. I ask when it's due. Well, the pre-implementation was supposed to be done in the morning, but it wasn't, and we're in the implementation window ... half way through. I bring up the change task, and look at. Create new schema and users. That's all it says. The BA laughs. I tell I need more to go on. 10 minutes later he sends an email with the information. There's only two hours left in the window, and I can only use half of it, because the production guys have to their stuff, and we're in their window. Now I'm irritated, because I'm new to Oracle, and it's an unforgiving mistress. Fortunately, another DBA says he'll do it, so that we can get it done in time. But can't work it either, because Dev DBAs don't have access to QA, and the process required access for this task. Gets shelved until the access issue is resolved. It's now after 4:15PM. I'm going to in traffic with that 6PM deadline.

I manage to get home and to the computer by 5:45PM. Log in. Start VPN. Box pops on screen. Java needs to update. I chose skip update. Box pops up again. It won't let me log in until Java is current. Passed.

I finally get logged in, and it's 6:10PM. I'm late getting the job started. I pull up Putty and log into the first box, and paste my pre-prepared command in the command line and hit error. Command not found. I'm tired, so it's a moment to sink in. I don't have time for this.

I log into DBArtisan and pull up the first data base, use the wizard to set the job, and off it goes. Yay. Bring up the second database, and have enter the connect info. Host not found. Wut? Examine host name. Yep, it's correct. Try a different method. Host not found. Go back to Putty. Log in. Past string. Launch. Command not found. Now my brain is quitting on me. Why now? It's after 6:30PM. Fiddle with some settings, reset $Oracle home. Try again. Yay. It works. I'm done. It's after 7PM.

There is nothing like technology to snatch the euphoria of a success away from you. It's a love-hate thing, but I wouldn't trade it for anything else. I'm done. Good night.

I pray September is a time full of blessings and good vibes where all my homies get their pull requests merged and their Stackoverflow questions answered.

I was asked to fix a critical issue which had high visibility among the higher ups and were blocking QA from testing.

My dev lead (who was more like a dev manager) was having one of his insecure moments of “I need to get credit for helping fix this”, probably because he steals the oxygen from those who actually deserve to be alive and he knows he should be fired, slowly...over a BBQ.

For the next few days, I was bombarded with requests for status updates. Idea after idea of what I could do to fix the issue was hurled at me when all I needed was time to make the fix.

Dev Lead: “Dev X says he knows what the problem is and it’s a simple code fix and should be quick.” (Dev X is in the room as well)

Me: “Tell me, have you actually looked into the issue? Then you know that there are several race conditions causing this issue and the error only manifests itself during a Jenkins build and not locally. In order to know if you’ve fixed it, you have to run the Jenkins job each time which is a lengthy process.”

Dev X: “I don’t know how to access Jenkins.”

And so it continued. Just so you know, I’ve worked at controlling my anger over the years, usually triggered by asinine comments and decisions. I trained for many years with Buddhist monks atop remote mountain ranges, meditated for days under waterfalls, contemplated life in solitude as I crossed the desert, and spent many phone calls talking to Microsoft enterprise support while smiling.

But the next day, I lost my shit.

I had been working out quite a bit too so I could have probably flipped around ten large tables before I got tired. And I’m talking long tables you’d need two people to move.

For context, unresolved comments in our pull request process block the ability to merge. My code was ready and I had two other devs review and approve my code already, but my dev lead, who has never seen the code base, gave up trying to learn how to build the app, and hasn’t coded in years, decided to comment on my pull request that upper management has been waiting on and that he himself has been hounding me about.

Two stood out to me. I read them slowly.

“I think you should name this unit test better” (That unit test existed before my PR)

“This function was deleted and moved to this other file, just so people know”

A devil greeted me when I entered hell. He was quite understanding. It turns out he was also a dev.

Product owner/Scrum master: "We don't have any time to review pull requests. We need the development time for features"

So I am conducting an introductory seminar on git and GitHub for juniors and as per my knowledge I've drafted this outline, please add your inputs..

The seminar will be of 1 day only

1. Install and configure Git and Github

2. Digital Signature mapping

3. Git init

4. New Project with HTML

5. Configure remote (git remote add <origin> <url>) ends with .git

6. Git commit (git commit –m “Title” –m “commit message”)

7. Pushing git push (git remote push origin master)

8. Git commit –amend

9. Git pull (git pull origin master)

10. Git checkout (git checkout –b new_branch_name)

11. Do some changes

12. Git push new branch (git remote push origin new_branch_name)

13. Git switch branch (git checkout <name_of_existing_branch>)

14. Pull requests

15. Git log (git log –oneline –graph)

When I open sourced one of my projects on GitHub I thought "I got a small but good user base (70k), I think they are some good developers ready to improve the project and send pull requests".
I only received translations. I'm (a bit) disappointed.

250 errors in 3 applications this morning.

Then I merged two pull requests that I created yesterday and the error graph started decreasing. After 30 minutes the error count is back to 0.

When you have 9 pull requests that have been sitting in the queue for the past 2 weeks

Had a five hour long debate with one of our Senior Developers today about pull request etiquette.

His view was reviewers should always email or call him before adding comments to any of his requests and they should never block them as he should be allowed to code in "his own style" and should be able to approve his own pull requests.

I explained that we have code standards and an agreed PR workflow be needs to comply with.

He then started talking about meteors and plane crashes. Literally no helping some people.

When someone merges their own pull request and destroys the master branch

Me writing the description for my PR:
"Felt cute, might refactor later idk tho 💅"

!rant
How do you tell someone more experienced than yourself, to stop writing shitty code?

That's a serious amount of pull requests...

Yes yes this year i was lazy and also didnt have fucking time. But still made it almost double. Next year im going for 25 pull requests.

Our project at work goes live in 3 weeks.

The code base has no automated tests, breaks very often, has never had any level of manual testing

will not be releasing with any form of enforced roles or permissions in our first release now due to no time to enforce, however there is a whole admin api where you can literally change anything in our database including roles.

We also have teams in various countries all working separately on the same solution using microservices with shared nuget packages and they aren't using them properly.

Our pull requests are so big - as much as, 75 file changes - in our fe app that I can't keep up with it and I honestly have no idea if it even works or not due to no automated tests and no time to manually test.

We have no testing team, or qa team of any sort.

Every request into the system has to hit a minimum of 3 different databases via 3 different microservices so 1 request = 4 requests with the load on the servers.

We don't use any file streams so everything is just shoved in the buffer on the server.

Most of the people working on the angular apps cba to learn angular, no one across 2 teams cba to learn git. We use git so they constantly face problems. The guy in charge has 0 experience in angular but makes me do things how he wants architecturally so half the patterns make no sense.

No one looks at the pull requests, they just click approve so they may as well push directly to master.

Unfinished work gets put in for pull request so we don't know if the app is in a release state since aall teams are working independently, but on the same code base.

I sat down and tested the app myself for an hour and found 25 fe only issues, and 5 breaking cross browser issues.

Most of our databases are not normalised. Most of our databases make no sense. 99% of our tables have no indexing since there is no expertise with free time to do it.

No one there understands css properly. Or javascript.

Our. Net core microservices all directly use ef in the controller actions so there is no shared code there.

Our customer facing fe app is not dry because no tests so it was decided it was better this way.

Management has no idea on code state, it seems team lead is lieing to them about things like having any level of tests.

Management hire devs that claim to be experts but then it turns out they have basically no knowledge of what they were hired to do, even don't know what json is or the framework or language they are hired for, but we just leave them to get on with it and again make prs too big to review.

Honestly I have no hope that this will go well now but I am morbidly curious to watch. I've never seen anything like the train wreck that we are about to get experience.

When u finished 80018939018282983 pull requests on a single day hoping to get extra stickers for Hacktoberfest..

Biggest teamwork fail? This is the general way we do business where I work right now:
My boss didn’t want to be the kind who hovers, always micromanaging. He also hates the idea of taking programmers away from their work for meetings. Sounds great, right? This has resulted in:

• All non-lead devs being excluded from all meetings other than scrum (including sprint planning and review meetings). Nobody ever knows what the hell is going on. They don’t think we “need to know.” This means most of our day is spent trying to figure out what needs to be done, rather than getting anything done.

• Our remote boss making dozens of important decisions about our platform, never telling us, and blaming us for not forcing our lead to be more communicative.

• Pull requests staying open for weeks, sometimes months, because nobody has definitively decided what version we’re actually supposed to be working on. This means our base branch could be any of them, and it means PRs that have been opened too long need to be closed, updated, and re-opened on the false promise of someone actually looking at it.

Just ranting here... but I think our biggest teamwork fail is happening right now, with all of those things ^

!rant

What are people thinking when they are building datepickers (or any type of angular/jQuery plugin for that matter)?

Lets put all of the code in one file, place everything that should be dynamic and optimizable in constants, provide no localization support, finish it all up, publish it to bower and npm (so poor devs won't have to struggle) and last but not least don't accept pull requests with useful features for months!

I was told Friday I had trust issues because I wanted to code review pull requests from outside the team.

It's the last day of hacktoberfest and I got to know that my repository was listed in digital ocean's list of "top repositories with highest number of pull requests".
Feels good :D

I will happily accept any pull requests to finish my bachelors degree.

When it comes to nervewrecking situations, what I've encountered so far is a pull request for which the 2 reviewers had opposite opinions.
Something like this:
* opens pull request *
reviewer 1: "update using approach A"
* updates code *
reviewer 2: "this is wrong, change to approach B"
* updates code again *
reviewer 1: "this isn't what i asked for, i'm rejecting your PR"
Oh, also, each of them had their own set of coding standards.

What was your most challenging situation when writing code?

Created 2 pull requests 🙄
They will get rejected tho 🤔

The people at my new job don't do pull requests. Concern?

So last Tuesday, I started two pull requests, with one branch that should be in production in few time, and warned the validators that they can check the code and validate or add comments. I was in weekend in the Tuesday evening, going to Paris in the weekend.

I come back today, and the pull requests haven't even been checked. Nice.

My life has been pretty rough this week regarding personal life context, but at least my pull requests are being approved and having good comments, which is nice.

I may have convinced my boss to start using Gitea to manage our git repos! 😆

Right now we have a NAS with bare repos, so we have no access rights, no overviews, no forks, no issues, no pull requests, nothing! 🤐

Now it's time to pray to the gods for his decision. 🤞

I'm a junior dev, been on placement a year.

I get tasks done mostly on time, my pull requests are merged, yet I still feel like what I'm writing is seriously under quality.

What point will I stop writing code that isn't good enough to not be stressed about? 😷

goto

Found it lying around. Googled it, and it seems people avoid it, so I started using it all over the place(s). goto b

a:
no other places to goto exit

b:
Yes, it does require some thought to avoid confusion, and some pull requests get declined, but... Helps me alot when I have goto a

:exit

We're all on gradle and we had a new guy who started a project with Maven. He also used atom editor for Java/Scala code (even though we had a license for Intellij), and refused to use anything with code completion (or turned it off if there was an option). My boss had to explain basic git branching to him, his pull requests were missing build files, READMEs and he'd check in tons of scripts to run things instead of using maven/gradle.

I just thought he was weird, but I didn't look at his pull requests close enough to realize how bad his code was, until they fired him earlier this week.

I completed my 4 pull requests for hacktoberfest and guess what all of them got approved. Yayyy!!

So these are the issues which I fixed in hacktoberfest2019.

1. Fixed readme of imba
2. Fixed the script of devTea
3. Added screenshots for the same (2)
4. Helped a friend with a blockchain script.

Thanks a lot!! @devTea, for giving me the chance.

Now the real question is are you even allowed to put React in your cv if you've never worked with redux, don't know the concept of HOC and still make pull requests with componentWillReceiveProps ?

Is there anything worse than maintaining two versions of the same application? Checking out two branches and submitting two pull requests for each and every single thing is killing my productivity. 😔

Trying to resolve merge conflicts and you cant remember which changes are the ones you want to keep. Lesson learned, make sure your pull requests dont sit waiting for weeks while master is happily being worked on.

24 PR
Giving back little gifts of code for Christmas 🎄

24pullrequests.com

Yayy!! Hoping to have a productive PR-full December✨

PR used to mean public relations to me few months back. Now it just means pull requests to me.
The fuck happened. Anyone says we need to improve our PR, I'm like how do you improve a pull request and I end up face palming

For our robotics team we have a college professor (if that's what you even call it) who is teaching our programming subteam how to code the robot in c++. Whenever we mention git he goes on and on about how git is too confusing and we shouldn't use it even if we used pull requests.

What the actual fuck

I need to vent or I'm going to fucking explode like a car filled with bombs in motherfucking Iraq...

A couple of months ago I inherited a project in development from our team leader who was the sole developer on it and he was the one who designed every single thing in it.

I was told the project is clean, follows design patterns, and over all the code is readable and easy.

Those were all fucking lies.

See throughout the period he was working on it, I saw some of the code as it was going through some pull requests. I remember asking the dev why he doesn't comment his code? His response was the most fucking condescending shit I've ever heard: "My code is self-documenting"...

Now that I have full control over the code base I realize that he over engineered the shit out of it. If you can think of a software design pattern, it is fucking there. I'm basically looking at what amounts to a personal space given to that dev to experiment with all kind of shit.

Shit is way too over engineered that I'm not only struggling to understand what the hell is going on or how the data flows from the database to the UI and in reverse, I'm now asked to finish the remaining part and release it in 8 weeks.

Everything is done in the most complicated way possible and with no benefits added at all.

Never in my career have I ever had to drag my sorry ass out of bed to work because I always woke up excited to go to work... well except for the last 2 weeks. This project is now taking a mental toll and is borderline driving me crazy.

Oh, did i tell you that since he was the only dev with no accountability whatsoever, we DO NOT EVEN KNOW WHAT IS LEFT TO BE IMPLEMENTED?

The Project Manager is clueless.. the tickets board is not a source of truth because tickets set to resolved or complete were actually not even close to complete. FUCK THIS SHIT.

For the last week I've been working on 1 single fucking task. JUST 1. The whole code base is a mine field. Everything is done in the most complicated way and it is impossible for me to do anything without either breaking shit ton of other features (Loosely coupled my ass) or getting into fights with all the fucking libraries he decided to use and abuse.

1 whole week and I can't even get the task done. Everyday I have to tell the project manager, face to face, that I'm still struggling with this or that. It's true, but i think the project manager now thinks i am incompetent or just lazy and making excuses.

Maybe I'm not smart enough to understand the what and why behind every decision he made with this code. But I'm sick to my stomach now thinking that I have to deal with this tomorrow again.

I don't know if I'll make the deadline. But I'm really worried that when this is released, I'll be the one maintaining that nightmare of a code base.

From now on, if i hear a fucking developer say their code is "self-documenting" I will shove my dick + a dragon dildo + an entire razor gaming keyboard up their ass while I shoot their fucking knees off.

oh... and there are just a couple of pages of documentation... AND THEY ARE NOT COMPLETE.

That moment when you feel that you are a great developer ready to do some pull requests to the framework you are using and then you check the source code of it and wonder if that's even the same language.

Use your pull requests guys, you don't wanna see this guy in your terminal

Sometimes I feel like when I make comments in pull requests, people pretend to understand what I'm talking about. Anyone else feel that way?

What to do when for a single issue, multiple contributors send out different PRs doing the same stuff?
I feel bad to close a PR without merging when they have spent there time in it.
I never expected that my repo will ever attain such dilemma for PRs.

Contributing on github projects.
Especially when my pull-requests finally merged to the original master ^^

In a team with 7+ Frontenders. Only one is vhecking my Pull requests. *sight*

You're working on a project, your boss has set you tasks to complete. You complete all the tasks and make pull requests of all the work you've done. Your boss is busy and you don't know what to do next? What do you do? Is it unethical to work on personal projects in work hours, because you're not being paid for that? How do you find other stuff to do?

Should i be posting on devRant to hire a fellow devRanter for a project in my company? (temporarily but may become constant if we click well)

More info:
Looking to hire a mostly frontend react dev.

The project is about graph visualisation and traversal.

Our stack is python (flask, appbuilder, SQLalchemy), react, react d3-graph, jest.

Must know how to use git and pull-requests.

(The software is based on Apache superset)

The code is a bit of a mess. But let's be honest, which big project isn't?

Learning programming, networking, robotics, and other technical skills are very important but do not forget that these are future working software developers.

They will need to know a lot more intangibles. Like effective pair programming, performing proper git pull requests and code reviews, estimating work, and general problem-solving skills and more.

These people will be learning technical skills for the rest of their life (if they are smart about it) but what can really get them ahead is the ability to have good foundational skills and then build the technical skills around them over time.

Pull requests. Everyone tears each others apart e.g. a double white space.

If you use "lodash.map()" I will automatically 'request changes on your pull request.

When you keep on refreshing the tab to see if your pull request got merged but it still says
”Pull requests 1”

Best feeling as a programmer: creating a pull request
Worst feeling as a programmer: other people's pull requests

Team leader doesn’t know the difference between merge/rebase nor uses pull requests to propose changes to a humongous repo, just two branches where everyone commits and pushes freely! 💩💩💩

Does anyone here create pull requests when working on projects alone? I am wondering how effective this is in practice.

Pull requests with 900 changes across 27 files and not a single comment. But Ruby is self-explanatory!

So to keep me going through the day I sometimes entertain myself by adding funny comments to my pull requests. I sit there giggling to myself like some sort of lunatic and the rest of the office probably think I'm a nutcase.

Todays gem was:

Added timeout to prevent hanging. Bet they wish they'd had this feature in the 16th century

Honestly I think my talents are wasted here...

Dude i asked you to review my pull request because i thought we were cool. The code change is about a simple rename, SO FUCK OFF WITH THE REFACTOR SUGGESTIONS. STOP DOING THAT TO MY CODE REVIEWS

I hate when someone writes an amazing framework and then they abandon it and don't merge in pull requests so you have to pull it into your own project to maintain it.

Yes, you fucking bitch, make more promises... Funny thing, repo is still active and he accepts pull requests, though last release was on January 9. That’s why I don’t like contributing to open source.

Oh, and these last days, every fucking thing I do with vuejs, makes me hate it more and more, but will make other rant, never been so angry...

The project my company agreed to work with 1 year ago is totally shitty.

We basically use Python 2, Tornado, MySQL and driver for it from 2005, custom made "ORM" where you have to write SQL in strings in Python, custom asynchronous service that runs jobs and all such...

The rest of the team writes code really badly and only after a year of fucking with this shit we made them do pull requests.

I became totally neurotic because of the shit I have to go through daily at work. I do not develop myself, no new things I have learned in the past year or so. What do I do, devrant? What is your advice?

I'm so happy I've just made all the 4 pull requests necessary to get a t-shirt from DigitalOcean! So, how is this anyway, will they send me an email asking for my size?

first some background. I'm an intern coming in on the end of my internship (tomorrow's my last day). I've been working on a reasonably important project, more specifically a restful API. We have automation set up so that any commits to master on GitHub are pushed out into a live, accessible version. Some guy (let's call him dumbass) joined our team last week, and has had a few ideas

Dumbass: *opens pull request to my repo*
My boss: *requests changes*
Me: *requests different changes*
(All this before even testing his code, mind you)
Dumbass: *makes requested changes*
Me: *approves changes*

A day passes

My boss: *approves changes*
Me (not even 10 seconds after my boss approved changes): *requests more changes*
(Still haven't tested his code, I just ran A PEP8 compliance test)
Dumbass: *MERGES CHANGES TO MASTER*

Literally EVERYTHING breaks because he was importing a module that's not available

We don't notice until later that day (I'm still working on writing the tests for the automation, for now changes get put on live version even if everything breaks -- tool is still in beta, so everyone working on it (a whole 3 people) knows to TEST THEIR SHIT BEFORE MERGING TO MASTER.)

WHY EVEN BOTHER WITH THE PULL REQUEST IF YOU WERE GOING TO MERGE TO MASTER YOURSELF ANYWAY??!??!??

My frustration cannot be properly conveyed through text, but let's just say this guy's been there a week, I already didn't like him, and then he fucking does this.

(imagine all of this said in Undoomed's "hey moron" tone)

Hey, moron, fuckin moron! How about if you're a noob with no actual programmer on your side, you just tell me so we can work it out together, instead of sending a moronic 4page "acceptance criteria" that pretend you know what you're talking about, and then bury me under loads of moronic noob questions that reveal you as thenmoron you are, all of that for a fuckin 50 quid?! I thought it's me being an idiot, not being able to do the task within two days timeframe, but now I see you're just too much of a moron to have any idea how much these things take. And now you nonchalantly mention a one-line one point from the four page document full of drivel, which (loads of moronism credit for me here) i didn't notice amongst all of that other mundane drivel, which actually like doubles the whole workload on the task, but your moronic document, which makes 3 parts of the same algorithm into three separate MILESTONES, makes this whole thing that nearly DOUBLES the workload into a shitty SEVENTH SUBPOINT of the completely unrelated first "milestone"?

FUCK YOU, YOU STUPID ROBBERY CHEAPFUCK, and fuck me for letting myself be tricked by all your fancy wordings that pretend you actually know what the fuck you are asking for, so i assumed you did, so I missed THE POINT, WHICH ACCORDING TO THE SEGMENTATION LOGIC OF THE WHOLE REST OF THE DOCUMENT SHOULD BE 3 SEPARATE FULL-SIZED MILESTONES, NOT A SINGLE SUBPOINT, YOU FUCKING FUCK!

... so much for still trying to at least a bit trust people.

FUCKING DISGUSTING MORONIC CHEAPSKATE FUCK.

and I can't even tell him to fuck off through the rectum he came here because he's all nice and polite so I would be the asshole!

"hey, please, can you build me a house?"
*house is basically finished*
"oh, great job, i love it, but i think you might have missed the fineprint in our contract that says that the house is supposed to stand inside an entry hall of a multibillionaire-sized mansion, so could we please sort that out and add it to the building real quick before i pay you the toolshed's worth we agreed on based on the contract? "

FUCK. HIM.
FUCK
FUCKFUCKFUCKSHITFUCKERYFUCKDISGUSTINGIDIOTICFUCKINGFUUUUUUUUCK!!!!!!

i thought i can be a shitty liar and a con man, but this is some next level shit that would be totally beyond my abilities to pull off...

YES I KNOW IT'S MY FAULT I DIDN'T COMB THROUGH THAT BULLSIT "SPECS" OF HIS LETTER BY LETTER TO MAKE SURE THERE'S NO CON BULLSHIT LIKE THIS HIDDEN AMONGST ALL OF THAT MUNDANE SELF-EVIDENT PSEUDO-TECHNICAL DRIVEL, SHUT THE FUCK UP.

fucking disgusting moron, pretending all nice and innocent probably even to himself because he HAS NO FUCKING IDEA WHAT HE EVEN ASKS FOR.

i bet it's one of those pukefucks who get an overpriced contract for 50k without even knowing or caring what programming is, because "i'll just outsource the core functionality of the app for 50 quid to some naiive idiot who lives in the illusion that people are not diarrhorea-worthy pieces of feces, and this other third of the app to some other moron for hundred quid and then i somehow outsource gluing it together to some third poor sod, and that's 49.8k quid of pure profit for me, yay"

and now i'm torn between three options, just cancelling the "contract" with a comment saying "fuck off, you con man", or cancelling it with a lengthy explanation why he's a know-nothing piece of shit who conned me already into having done something worth about 5x more than his shitty "acceptance criteria" requests, or just start conning and bulshitting him back, which won't net me any money, and waste my time, but at least will also waste HIS time, which might be nice because he seems to be on a tight schedule so if i play this right i might have the chance to sink his whole contract which might be mighty nice satisfying...

FUCK THIS, ALL OF THIS, FUCK HIM, FUCK ME, FUCK ALL OF YOU, I SHOULD HAVE STARTED FUCKING OVER EVERYONE RUTHLESSLY A LONG TIME AGO BECAUSE FUCK THE WHOLE WORLD, WHY SHOULD I CARE WHEN NOBODY ELSE DOES, WHY SHOULD I BE DECENT WHEN NOBODY ELSE IS, AND IT ONLY ROYALLY BITES ME IN THE ASS.

stupid fucking lobotomized fuck, IF YOU DON'T KNOW HOW TO DO SOMETHING, DON'T OFFER YOURSELF TO DO IT FOR MONEY AND THEN CON-SOURCE IT TO OTHERS YOU SHITTY BARFPILE!

FUCK.

Merge pull requests with so many changes that half of the files don't load are the best 👍

Ionic be like: Testing? Fuck that lets just bring out ionic 3.0 beta and let our testing example repo die with a few pull requests from one dude who actually tries to keep it updated

My team is split on reviewing pull requests individually vs as a group.

Personally, I don't like being interrupted to come look at a projector for 20 minutes only to go back to work for an hour, and then get pulled into yet another review. Am I the only one that thinks this is incredibly inefficient?

I prefer to go over pull requests on my own time, asking questions/making comments as needed.

I created pull requests for some open source js projects to fix issues with monkey patching Object.Prototype, as I used it heavily in a current project. All of them were accepted and merged.

A couple of weeks later I realised how retarded that was and refactored all monkey patching to separate modules.

Does anyone else get frustrated when your co-worker goes behind you and changes the name of a particular variable? Changing the word "repo" to "repository" does not clarify a fucking thing! You're not going to confuse it with something else. I've never once seen the word and thought "Damn, that guy meant reposition and I just fucked everything up." It would be one thing if our lead Dev told me to not use the word, but he could not care less.
Am I in the wrong?

Draft Pull Requests : With draft pull requests, you can clearly tag when you’re coding a work in progress. Next to the “Create pull request” button. Toggle the dropdown arrow whenever you want to create a draft instead.

I forked an collection/project on TFS so a team could do their own changes on one application and leave me alone. Yay Shadow IT. Now I have to figured out how to do pull requests to merge back into “master” without me doing all the work.

Holy fucking shit I hate using bitbucket, that utter piece of crap. It is so fucking slow to use. Coming from Github, I really hate the pull requests page, with no fucking syntax highlighting or anything.

Things that annoy me about my current place:

1 - Only 3 people out of a team of 12 developers are allowed to purge akamai, or merge pull requests to master on any of our 200+ websites. Apparently this is because us contractors are not allowed because the permanent employees have to be accountable for the code.

Despite this, no-one actually reads the code. You just throw up a request in the slack channel and boom, instantly 30 seconds later someone approves it, even if its 500+ lines of code.

2 - I've pushed for us to move to agile instead of waterfall, and got declined (which is fine), but the reasoning was that the dev team are not 'mature enough' to work that way. Half the devs here have 5+ years of experience so I don't get the problem here.

3 - There is zero code reviewing process in place. I just watched as a developer's 300 line merge request was approved within 8 seconds of it going live. No-one is allowed to comment on the code review or suggest changes as this would 'slow down development'. Within that 300 line merge request were tons of css being aimlessly commented out, and invalid javascript (introducing both bugs and security issues) that were totally ignored.

What is your thoughts on these above points?

Am I too narrow minded or is the development manager clueless?

This team mate of mine always finds a way to escape my suggestions in his pull requests.

Today he told me that what I'm asking him is just my personal preference and that it's not a thing just because our formatter isn't powerful enough to do it automatically.

Our manager is in tons of meetings all the time. He sees himself as our architect, and he has read and approved code reviews. Yet when he does get time to code and submits his own massive weekend coding binge pull requests, they're often entirely different from everything we've written to this point.

Instead of trying to be consistent with the work we've currently done, he continually argues any comments we make in the code review. I want to be like, "If you wanted it this way you should have designed it this way instead of giving us a bunch of empty class files an interfaces with terrible names."

Finally the site is live. Today all stress was gone again. Still a pity that i have 7 pull requests out of 10.

I'm working on my own smarthome project (how rare nowdays...:) ). I'm using microsoft's git repo. I'm not make my project open source, not because I'm a douchebag, but because I'm a very bad coder. My biggest fear is not the fact, that it would be commented as wtf is this code, but receiving pull requests from pros and I wouldn't even understand their code.
This is my "training" project (python, flask, apscheduler, sqlalchemy, bootstrap2, mqtt, micropython)
I'm thinking to make it public without accepting external pulls, just for me to learn more.
I'm just wondering your thoughts on this.
Thoughts?

I hate my Scrum Master. Normally he doesn't even checks pull requests, and when you need his help, 80% of the time he's missing. Now that our boss is the new Product Owner of the application, the SM is bugging us A LOT

So fuck him, go away to do whatever the fuck you did before. Stop pretending you "work"

People that approve pull requests without looking at them!

No tests or so bad they would do more use by not existing, typos, the code follows none of the design practices and the code obviously will not compile and thereby breaks builds in trunk for everyone.
Because of course they only asked one person to review it and then merged it immediately.

Well this morning has been fun with Github's pull requests and issues not working.
status.github.com

Started a new job at the same time as another guy. We are doing pull requests, I leave a comment about a one line improvement.

"This is not part of my task. If you want me to do extra run it past our bosses. You can't tell me what to do."

I despair.

You know code freeze is soon when there are 32 pull requests all on one day

Sick of lazy pull requests. Dot the i's and cross the t's please.

Not the 'most embarrassing' part but not my proud moment either.

My sir have recently put me alongside him as the teacher assistant in this summer's batch. Last week he had to go somewhere so he asked me to take a github session with the class( well not exactly asked, but i just voluntarily commented) . mind you am myself a novice, never done anything beyond pushing data commits and pull requests. (But sir was fine with it , saying he wants the students to atleast enough knowledgeable to submit there homeworks.)

Fast forward to Night before class and i am trying to sleep but couldn't. I had all ppts prepared, hell i even prepared a transcript( hell i uploaded it to pastebin thinking i will look at it and read ).

But worst shit always has to happen when you do a presentation.

When the class started, the wify was not working. Those guys had never had done anything related to it so first thing we did was to make sure every of them gets git installed(with lots of embarrassments and requesting everyone to share their hotspots.not my faluts, tbh).

Then again, am a Windows-linux user with noobie linux and null mac experience. So when this 1 girl with mac got problems installing, i was like, "please search on SO" 🐣 .
So after half an hour, almost everyone had their git/github accounts ready to work, so i started woth explaining open source and github's working. In the middle of session, i wanted to show them meaning of github's stars ("shows how appreciated a repo is"), nd i had thought of showing them the react js repo . And when i tried searching it i couldn't find it (its name is just react, not reactjs ) so ,again :🐥🐥🐣

So somehow this session of 1-1.5 hour got completed in 4 hours with me repeating myself many many many times.
And the most stupid thing: our institute has every session recorded, so my awkward presentation is definitely in their computers 🐣🐣🐥🐥

Hey guys, I want the t-shirt of hactoberfest, please if anyone of you have anything for me to contribute in your repositories, let me know.
Even if it's a small typo, I'm in.

Need some advise from all you clever devs out there.

When I finished uni I worked for a year at a good company but ultimately I was bored by the topic.

I got a new job at a place that was run by a Hitler wannabee that didn't want to do anything properly including writing tests and any time I improved an area or wrote a test would take me aside to have a go so I quit after 3 months.

Getti g a new job was not that hard but being at companies for short stints was a big issue.

My new job I've been here 3 months again but the code base is a shit hole, no standardisation, no one knows anything about industry standards, no tests again, pull requests that are in name only as clearly broken areas that you comment on get ignored so you might as well not bother, fake agile where all user stories are not user stories and we just lie every sprint about what we finished, no estimates and so forth, and a code base that is such a piece of shit that to add a new feature you have to hack every time. The project only started a few months back.

For instance we were implementing permissions and roles. My team lead does the table design. I spent 4 hours trying to convince him it was not fit for purpose and now we have spent a month on this area and we can't even enforce the permissions on the backend so basically they don't exist. This is the tip of the iceberg as this shit happens constantly and the worst thing is even though I say there is a problem we just ignore it so the app will always be insecure.

None of the team knows angular or wants to learn but all our apps use angular..

These are just examples, there is a lot more problems right from agile being run by people that don't understand agile to sending database entities instead of view models to client apps, but not all as some use view models so we just duplicate all the api controllers.

Our angular apps are a huge mess now because I have to keep hacking them since the backend is wrong.

We have a huge architectural problem that will set us back 1 month as we won't be able to actually access functionality and we need to release in 3 months, their solution even understanding my point fully is to ignore it. Legit.

The worst thing is that although my team is not dumb, if you try to explain this stuff to them they either just don't understand what you are saying or don't care.

With all that said I don't think they are even aware of these issues somehow so I dont think it's on purpose, and I do like the people and company, but I have reached the point that I don't give a shit anymore if something is wrong as its just so much easier to stay silent and makes no difference anyway.

I get paid very well, it's close to home and I actually learn a lot since their skill level is so low I have to pick up the slack and do all kinds of things I've never done much of like release management or database optimisation and I like that.

Would you leave and get a new job?

Fuck you, BouncyCastle. I really like you but the way you have documentation. It's annoying. Nice name. Cool project.

Here, I'm write Java Docs for JUnit tests! For every damn test case!

So damn less documentation even SO said mind your own business! It's been more than 15 hrs. Not a single reply! I died a little today. They have examples but they are not really "examples". No passion at all for documentation!

You should watch and learn from AssertJ docs. OMFG @joel-costoglia sets standards for code style and docs before pull requests. The examples are LOTR themed for god's sake. I'm not asking for fluent API. I just want docs. What class does what. A simple program structure required.

Dyn4j, deeplearning4J have wonderful docs. Why not BouncyCastle?!!!!!

Pull request during examinations be like...

I finally got around to working on my new application (after a friendly guy did pull requests)

I feel like I made decent progress.

yay!

I will certainly add more tomorrow :)