44
netikras
15d

No, listen to me. I cannot approve this PR because your code does not comply with our code style. All the imports and annotations must be sorted in ascending order by length. They must all make fir-like blocks of code. Because it looks nice.

Now go and fix your code

I just smiled and walked away to obfuscate my code with firs . I had no idea what to even say to that... I still don't

Comments
  • 8
    Done!
  • 17
    Thats.... totaly random, and makes no sense!
    my team should adopt!
  • 2
    We have similar in regard to sorting imports. As a junior Dev found that so frustrating but then discovered everyone used a plug-in for that, but didn't tell me 🤣
  • 8
    @sebson FYI that is a VERY stupid idea. Not only it does not add anything useful to the code, it also
    a) wastes your time on (re)arranging things
    b) shuffles imports from different packages, hence if you ever need to see how dependent you are on some packages you will have an obfuscated imports' list to unshuffle.

    This approach does only one thing well. Wastes everyone's time
  • 4
    Please explain "fir-like blocks of code". I searched for it, but could not find anything related to coding. Does it literally look like a fir tree?

    Edit:

    Okay, I re-read it. It is about the imports at the beginning of the file. It should look sloping down to the right. Yeah, that is fucking stupid! Imports should be divided up by relevance/function if anything. Not making some picture in code. Okay, you win devrant this week! This is the ultimate.
  • 5
    @Demolishun Not just imports.. Anything that does not care about ordering.

    Methods'/fields' annotations
    Protected variables' declarations (code style did not allow anything private)
    Method variables' declarations
    ..

    anything.

    Hence the fir-like code :) Slope goes down-right, then code happens, then again goes down-right, etc.

    There were other code-style decisions that made me explode inside, but the fir-like code was the cherry on a top
  • 2
    i'd sort every line alphabetically and by length (yes, EVERY LINE) then do a PR just to protest.
  • 3
    Lol what, you have to sort methods by length? Bahaahah

    Thats some next level stupidity
  • 0
    Parse each line to put chars in alphabetical order, it will look more esthetically pleasing 😃
  • 0
    Prettier?
  • 0
    @sebson I'm always stressed about where I should add my import statement in the mess of imports
Add Comment