Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
wonwon013434dWhy do you insult the guy who first wrote the code. Do you expect everyone to have the same knowledge level as you have in you specific domain? The guy didn't even study in your field...
Put yourself in his shoes. Maybe he didn't even want to do that but had to in order to make the project work. Maybe performance or resilience of his code wasn't even a cirteria back when he worte the file.
The bottom line is important...
Does it work: yes.
Is it performant enough: yes
Is it possible for someone to read the thing and understand: yes, you did it.
good enough for me.
fuego5434d@wonwon0 I'm glad it's good enough for you, but it isn't for me. That's the sort of software development practice that leads to systems breaking down the road for the simple reason of not following standards (or even googling how to read/parse a specific file format...).
Also, let me clarify. Yes, this guy has a biology degree. However, at the time he wrote this bit of code he had been working at this company for 4+ years as a software engineer. He was responsible for writing and maintaining numerous pieces of software here. Sure, he was not trained in computer science, software engineering, or related for his education, but he became a software engineer by trade.
Now, if this were some junior that did not know better and had not been responsible for so much development I would understand better. But he wasn't.
Did it work? Sure.
Did he have to do it this way for it to work? Hell no.
Was it a ticking time bomb? 100%
Was he a dumb ass? Fuck yes