Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple APILearn More
Maintaining open source software is a brutal, thankless, unpaid job. Try not to take it personally if you have a bad interaction after submitting a PR. It's like going to the govt office. You didn't do anything wrong, but you understand if the guy behind the desk has a stink eye all the time.
They can't really complain if they merged it already - it's up to them to check contributions for validity before accepting.
I've had to get rid of a fair bit of spam in Hacktoberfest, but there have been some useful contributions too. It's a pain, but in reality it just means I take longer to get around to merging the valid ones.
@justamuslimguy Not necessarily a bad one. What happened was everything went fine, PR merged, thanked each other and moved on.
But then this morning (a few days later) the maintainer messages me asking if i made the contribution because of hacktoberfest. But the thing is, they were the one that requested the changes to begin with so i obliged.
PrivateGER1848933dHuh? No, you still helped out, no issues with that at all.
Unless you create three seperate PRs each to fix a spelling issue. Then I'll bite your head off.
@justamuslimguy So a bit of an update - the maintainer ended up thanking me for the contribution after hours of thinking on it. The thing was the guy felt sucker punched because his repo was not drawing attention in the way he expected and assumed I did it just for a free tshirt.
I explained to him I actually infact started gaining interest because of the event and we worked out a resolution after that. No harm or grudges made.