18

Having to deal with shit code as a new employee so you don't step on any toes...

Who knew developers had such egos. ¯\_(ใƒ„)_/¯

Comments
  • 15
    Meanwhile me just hoping someone would say:

    "Bro mind if I clean this up?"

    Me:

    "OMG PLEASE!"
  • 4
    I’m right here with you. I am working in a codebase where the code is clever AF. That makes it terse and there are no comments. Then functions gets moved out of a class somewhere even if it has no reusability anywhere else. “It makes the file shorter” what kind of rationale is that for having to open sixty files to figure out what one does? Private methods are an option.
  • 6
    ๐ŸŽถrefactor while you work๐ŸŽถ๐ŸŽถ๐ŸŽถ๐ŸŽถ๐ŸŽถ๐ŸŽถ๐ŸŽถ
  • 7
    I'm on the other end here. We have very good code reviews on my new place which made me realize my code style is shit. On the bright side this will probably have a positive outcome in the long run.
  • 5
    @SortOfTested I do, and continually get yelled at for it. ๐Ÿ™„

    It’s always better, but they don’t seem to give a crap. “This change doesn’t seem necessary, and it wipes out commit history for those lines”

    Good to know someone else’s commit message is more important than readability. Such a pity that there’s no git history command that would allow me to do some meaningful freaking work.

    To be abundantly clear: /s
  • 0
    git log -- filename should produce a previous commit
  • 2
    @Root

    "it wipes out commit history for those lines"

    Jebus how important could those be? That seems like a scary / weird way to manage what sounds like pseudo documentation.
  • 1
    If you know you know what you are doing, you should be able to explain why things need to be different. If that is not appreciated, you may need another place of work. I know that may not be easy, but it's taken me a few horrible experiences to realise this.
  • 3
    I knew about the ego.

    I spent years getting over mine and it’s still pretty bad.

    Hard not to feel smart when you’re doing things daily with math and logic that 20 years ago were considered “magic”, while most everybody else struggles logging into their own email client.
  • 2
    @HiFiWiFiSciFi I wish. My brain processes the knowledge gap into an automatic prejudice that other people are dumb not that I'm smart. My ego stays in check for the most part but it colours my views on other people.

    https://youtu.be/vjNZzPZmYTY
Add Comment