Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
@magicMirror I'll update after the meeting.
It would only take me half a day probably, longer for him since he doesn't know the code.
I would have been fine doing the change if he hadn't been so aggressive about saying I'd broken stuff. -
@Voxera when I was first doing this, I talked with my mentor and did the thing that the guy from the other team now wants (implementing the feature on the base class).
The guy from the other team rejected my PR, so I implemented the feature just on one child class.
There's literally a comment from the guy on the PR from 6 months ago of the guy saying not to do the thing he's now suggesting that I do. -
-
@magicMirror he's gonna have to do more than just copy paste unfortunately, because I've made other changes on top of that first change.
I imagine he'll be back.
He was incredibly rude to my boss during the meeting though. Said stuff like "feature X is bad" about several features my boss has worked on or general stuff my boss supports. Nothing personal I suppose but all the examples of bad stuff he chose were coincidentally stuff my boss supported or worked on lol. -
@YADU not very good at office politics then ;)
-
@Voxera I certainly am not. I think my boss is pretty good though
-
@YADU I was referring to the other one ;)
-
@hjk101 the child classes are pretty big, the base class is just an interface basically...
-
@YADU yeah that sounded to me like there are some bad practices at play and the source of these issues.
Time to learn about IoC/DI and design by contract. Than you can build classes that only do one thing and changes that don't break everything instead of an ever expanding Swiss army knife. -
@hjk101 I mean, there's definitely a bunch of nice cleanup to be done here.
I don't want to be the one to do it though, this code is deprecated anywyas...
when your code is a mess but everything work out in the end
When you keep getting +1s on a rant you posted a month ago.
Go big or go home.
So, first a bit of background:
We've got a parent class, owned by another team, and two child classes, owned by my team. One of the children is unused. (Already sounds bullshit right.)
On to the story:
6 months ago, I had to modify one of the children (add new functionality).
I try to modify the base class to add it, the senior dev in charge says "no, just add it on the child". So I do, then merge it in.
Yesterday I wake up to a high priority bug. Turns out the senior guy wants to add another child class, and wants the functionality I put in my class on the base class.
Even commented on my PR from 6 months ago asking why I didn't do that.
The fucker opened up a high priority issue assigned to me, asking ME TO DO THE CHANGE I WANTED TO DO 6 MONTHS AGO THAT HE SAID NO TO.
Fuck this shit. I have a meeting with him and my boss in an hour. My boss is pissed, I hope he tells the other guy to go fuxk himself and do the change himself.
rant
code review
senior developer