11

So why the fuck did you go into code that I've written, change the name from "mode" to "type" throughout the >1500 lines of code that's relevant to the feature, and then move on to change my implementation to something that is arguably not common practice for the language and framework we're using, and in turn create duplicate state? And why the fuck weren't these changes in separate clear commits, but instead scattered over multiple commits? You're supposed to be senior!

Comments
  • 3
    Ssshhh... he’s a senior, he’s allowed to do that.

    Now clean up after himself.
  • 2
    Fill in that PR with 20+ suggestions and normal comments, oh and also request a few changes.
    Then leave a "Looks good, just left a few tiny suggestions" comment and come back the next day
  • 0
    @Ubbe Yes.
Add Comment