Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
Me 6 months ago: "This is fucking genius. Beauutiful. Look at that code. See how I did this? Wow, I love it. Fuck I'm good"
Me Now: " What. the. ffuck? Wtf is this? What was I thinking? Goddamn. "
*reduces 3 methods and 37 lines to 2 methods and 8 lines*
Well at least it shows I'm still learning.3 -
Boss: please refactor this js 2k lines spaghetti code class and use it in our reactive functional app
Me: it will take like 1 week to refactor and plug this
Boss: but it's almost the time I needed to write it!
YOU DON'T SAY? MAYBE FIRST LEARN HOW TO WRITE DECENT CODE. ffs.2 -
I'm converting some old stylesheets to sass and found this gem. How drunk I must have been to write something like this o.0
12 -
Manager: Why are you always refactoring?
Me: Refactoring keeps the codebase's entropy in check :)
Manager: mind blown!!
3 -
"Can you work on this ticket? It's kind of urgent."
-- "OK"
"And could you please not refactor? Just get this done."
-- "Why? What's the issue?"
"The logic is complex. We should not break it."
-- "Erm, that's what the tests are for. So yes, if the need arises, I'll refactor. The tests are my guidelines if the logic breaks or not."
There's a reason we create tests. So let's not hinder code base improvements by some random fear that stuff might break.
If breaks due to refactoring, we'll fix it by adding a valid test case during and then fixing the bug.
If my refactoring does not break the tests, I'll assume the code base is stable.
If your code is untested, then we have a complete different problem.3 -
My day in a nutshell:
Fixed the app.
Broke the app.
Fixed the app.
Broke the app.
Reverted all changes from repo.
Fixed app.
Found new bug.
Ugh....1 -
"Any fool can write code that a computer can understand.
Good programmers write code that humans can understand."
— Martin Fowler,
Refactoring: Improving the Design of Existing Code6 -
!rant
Ah the joy of tweaking one tiny segment of code to reduce your neural network runtime from 3 minutes for 100 generations to 3 seconds!6 -
Refactored a legacy source file and reduced it from 2.8k lines to 300 lines.
Mixed feelings: happy that it is much simpler now and sad that my current project team members never go back to delete unused code.
Testing pending though 😜7 -
Refactoring and writing tests for code that was code written by intern and is on production about one year
-
Looking at code in our workplace.. I realized one thing. Like Devops, legacy code is actually a mindset.
So here goes my thought:
A piece of code is not legacy because it was written ten years ago.
A piece of code is legacy because it looks like a piece of legacy code.
With the legacy code mindset, you end up writing legacy code no matter where you are, when you wrote it.
I was looking at some part of our code which we written in just the last few months, and I can’t help but think that they were legacy, so it really doesn’t matter when it was written!
It is more about how you write your code that determines whether it is legacy :)
Hopefully this was not crazily confusing anyone. Have a good day guys & gals!8 -
Me at 11:00
"Ohh I need to split this component into two since too much has been put into this.. Seems like an easy task.. Will take me an hour max to do this.."
Me at 22:00
"Damnnn.. I think I have broken this code.. I am doomed.."
*Replaces all files with HEAD1 -
When you touch your code that was written 2 years ago. It's like looking on pictures of young yourself, naive and ambitious ;)1
-
tl;dr @Root refactors some spaghetti.
I'm refactoring an api that creates a support message. It's a post route.
When seeing a magic hardcoded message string, this route instead updates the user object, and does not create a support message.
It also returns different results if the user is muted (fine) or if saving the message succeeds or fails (fine).
But if the user is creating a duplicate message, it doesn't save the message (fine) and... redirects to listing their messages instead? Wat?
Also, when refactoring this (migrating to a new message backend), I discovered that not all routes return a response. If the message is a non-duplicate, from a non-muted player, from a non-redacted client, the route doesn't respond at all!
So, I'm having fun cleaning this up. I actually am. Except I'll need to support all of the legacy clients for the next lifetime or two. I mean, really. There are still people with Android v2 devices who are using this thing. not even kidding.9 -
-Look at super hacky code for 30 minutes
-Ask yourself, how did this ever work, guy must have been an idiot
-Check annotations, you committed it
-"Dear God past self, what have you done..."3 -
So, should I refactor this into a .greatGreatGrandParent() method, or should I just go hang myself?
(Thanks former colleague for this gem)
10 -
1. Refactor shitty code because it is hard to maintain
2. Rant about how can someone write a code like that
3. Check commit log to see who is the person to blame
4. Found out that's me1 -
just wanted to look up something in an old project. saw things i could to better.
Ended up refactoring the whole project. Forgot what i was looking for.1 -
You refactor after there's code. You can't have clean code if there isn't code to be cleaned to begin with. Code first. Think of perfection later.5
-
I've found this beauty in our company's legacy code.
The main doubt is: is that possible have the required strength to refactoring this 💩?
23 -
Uncle Bob and Martin Fowler. Their books (“Clean code”, “Clean architecture”, “Refactoring”) and Twitter posts have changed the way I look at software development.5
-
How I spend my days at work working with legacy code:
* Writing tests before I do anything
* Noticing that i cannot write tests because of antipatterns. Lots of them.
* Refactoring to make at least a tiny bit testable.
* Then writing tests.
* More rewriting and refactoring
* Finally adding that one feature my boss asked me for
* Writing tests for that new feature (my do that before implementing)
* Explaining to my boss why it took me so long and agreeing on stopping writing tests.
* 2 days later: explaining why i still broke something.
But in the end my code works just fine.
my colleagues handle things differently. They just ignore problems as long as at least one feature works a bit.13 -
var { name: x } = person
Day 1 : that's some good ES6 code man, I'm so 2017
Day 5 : Oh yeah I think it works, dont really remember
Day 17 : WTF is that ? Is that even Javascript ?10 -
As a few of you possibly read in my last rant, I had to refactor a lot of my current story's code right before the deadline because senior colleague A "requested" it. Now my teamlead, who wasn't present yesterday, isn't happy with A wanting those changes. The discussion tomorrow will not be fun. Ffs people, the end of a sprint is NOT the right moment for that kind of shit. I'm not sure whether to bring popcorn or booze, so I can make my coffee Irish.2
-
After long hours of brainstorming, refactoring and redesigning, I looked at my boss, placed hand on his shoulder, smiled and said "version 2 boss, version 2" 😂1
-
Almost 3 weeks back I joined a company as a React developer. For a week I had nothing to work on as they were already working on few projects.
So my senior asked me to take up a project(not yet live) which was developed by 2 interns, as the frontend guy's internship was about to end in 4 days I have to take over the front-end role.
So I talked to that guy for next 2 days regarding all the project scope, codebase and whatnot. But still not entirely convinced. As i got the repo access, I began to check the codes. God !! It was all spaghetti code. I was damn frustrated. And still I am.
This whole week I am trying to do the refactoring as much as I can, I completely lost interest.
I cannot blame the intern guy, he is smart and tried to do the best he could, as he didn't know about the company standards. Maybe I was too the same kind back then. Now he is gone and I am stuck building components over that code.
Bonus: He used some old react boilerplate.
-_-5 -
When you're asked to extend a functionality on a piece of code and the 2.5k lines in the view are a juicy mix of PHP, HTML, CSS, JavaScript and the functionality relying on jQuery trasversing through the document tree and expecting things to be in their place. Oh did I mention html build with strings in JS? I'm going to love this day! WHY, JUST WHY?! *gasp*
3 -
Every time I look at some code and say "what the hell?!" the code refactors itself before my very eyes.2
-
i am fucking tired of companies that come to me expecting to magically fix their STEAMING PILE OF BULLSHIT AND TRASH CODE. how about when i ask "can i get a project brief", instead of saying "just fix it" or "it just needs to do this", GIVE ME A FUCKING COHERENT AND DESCRIPTIVE WRITEUP OF EXACTLY WHAT YOU NEED. i can't read your minds, let alone read the code the previous cock sucking developer wrote, so guess what? i'm left with no other option but to completely rewrite it. to top it off, instead of giving me god damn excuses as to why you can't get me the api key for your order processing, MAKE A NEW ACCOUNT AND GET IT TO ME. how the fuck do you expect me to test an application when i don't even have access to the fucking api the whole shit pile is based around? i swear to god if these people expect me to have this done by the end of the week but want to be little cunt nuggets they can go eat shit. fuck you, fuck your "contract", fuck your company, FUCK EVERYTHING. greedy, shit faced bastards2
-
I am currently refactoring my code:
1. 200 errors
2. fixed them!!!!
3. build the solution...
4. wait for the build to complete...
5. 300 errors
6. FML5 -
After 20 minutes refactoring code and changing methods, you realize you have been editing the wrong file -.-'1
-
I spent my last 2 months refactoring a crazy panel.
No one understood how that panel was working...I was feeling like the technological version of the chimney sweep.
I could almost breathe frustration.
So... what's your worst experience about refactoring old crazy codes?
4 -
It's only been a few years, might need a little refactoring.... The things you find when cleaning up old directory structures on forgotten hard drives...
1 -
My colleague doesn't give a shit about code quality and while I'm busy refactoring stuff after him, he's making flashy demos. Guess who's gonna be senior first6
-
That moment when you have refactored so much shit, then really broken the project, but can't see yourself doing a git revert because you had invested so much time and know ultimately it *needs* these changes...
Thank god I fixed it! 😌3 -
That moment when you know your code can be much shorter and cleaner but you just keep typing because you're too lazy to restructure.1
-
I spent 4 hours finding a good way to instanciate golang structures. Came up with a function that returned a value or pointer and I just kept reusing the nomenclature for an entire project. Then my buddy looks over and goes, "Ethan, you're a f****** idiot", and shows me the standard nomenclature. Now I have to refactor my entire project. FML.
(Edit: typo)13 -
I think I have a programming disease: Premature refactoring. Sometimes I refactor the refactor that I'm doing.1
-
Hours of refactoring just to get 0.5 seconds increase in performance per document generation.
Sounds small but makes a big difference when generating 100k documents.
Still not happy with it though...2 -
Tired of reading spaghetti code written by your team mates?
Sit right next to them and ask them to write unit tests for that code.
Smash their head on the keyboard everytime they have to think longer than 10 seconds on how to test a specific logic.
Strangle them with any wire you find nearby till they agree to break up that spaghetti code unless they already started within that 10 second time frame.
When the exercise ends, tell them this is what refactoring is and ask them to pass on the knowledge.5 -
Everyone is on their vacation and I am in good mood so time to refactor some 3 year old frontend, angular, javascript code. After 5 minutes of looking, some great quality of code snippet on the image below.
10 -
When your bitch-ass co-worker inserts something that is plain useless in the program in every degree
1 -
Everytime I don't sit in front of my code (and go for a walk or something), I immediately find bugs or things to improve from all the code I've written, IN MY HEAD. If you have a hard time finding bugs, try this, maybe. Might help.3
-
New task - add new field to a form... After few hours I'm ending up committing changes in 80 files..
*Refactoring craze*1 -
Man! I love refactoring! 👨🏻💻😍
Only saved about 20 lines but it went from ugly string manipulation to beautiful JavaScript objects!
9 -
I finished a big refactoring. It makes me feel so good to delete all those lines of code. Even though I have a decided to leave this company in the near future, I am very happy that I leave the code in a better shape. Somebody who is replacing me doesn't have to go through shit anymore.3
-
What a difference three lines of code can make. That's the typical case of "that seemed to be a good idea". I don't know how did I think it would work out on the long run. Next step will be reduceing the enourmous CPU usage as well.
3 -
I guess In software development, there are 11 most difficult tasks:
- Naming variables/functions, because the names should be meaningful but not verbose
- Write an appropriate git commit message, because f*ck u....
- Refactoring, because it involves the first two things and more...
1 -
Those little moments when you finish writing and refactoring the code and the result is elegant and just works
-
When you have the amazing refactoring idea you've been waiting for... but it will be hours before your back at a computer.2
-
I fucking love it!
After a full day of refactoring old shitty code into a glamorously sparkling epicness of bytes, the whole thing worked flawlessly and on speed.
Quite satisfactory. 😊
Templating in TWIG, especially using inheritance and includes, is so much more fun than doing it in raw PHP!
*cough*Fuck WordPress*cough"1 -
So this one day I'm at work and the manager peaks into my office and just says "can you check that platform X is building, pretty much done just a basic bug check" (this bloke had negative 1 technical experience)
I'm not sure what he means, the whole thing is built in Java and I know nothing about that...
I log in the platform on dev server, sure enough it seems to work, charts are drawn, no errors, then I try to log out; this button does nothing...
I don't bother telling the manager, I just go to the dev who's a friend of mine and tell him about it.
A week later, manager jumps in the room all excited "we're launching this product tomorrow, mind checking again?"
Sure, I log in, ... There's no log out button, it's gone... I ask the dev.
"Yeah I fixed it, it's gone now!"2 -
Just cut 2 seconds off the load time after roughly 2 months of refactoring. The code looks beautiful though.1
-
Where do you personally draw the line between "good enough" and "not good enough" code?
I just spent a considerable amount of time refactoring a function into 4 sub functions. The original one was fetching alerts for 4 related entities. All of the alerts are needed together in one dataset. A lot of variables and some of the logic was shared, therefore I originally chose to keep it as one, admittedly very large function. Where do you guys draw the line between refactoring or not refactoring in cases like these? How much weight do you give to separation of concerns vs simplicity? I'm curious.9 -
I'm surprised management allows us to write false positive tests just to have high coverage instead of refactoring it first. Time to abandon ship.
-
Refactoring you said.
Make your code maintainable you said.
Now, I'm in the middle of refactoring my functions. Detecting redundancies, building new general functions etc.
Then come another jobs.
And when I get back to my half-refactored code, I got really confused.
What did I do last time? And why the hell I wrote "finish this later" as my commit message...3 -
Fine don't take my suggestion during refactoring old code. Keep the python code over 100 lines of code...we could have cut it in half, but whatever
-
Worst code I ever had to touch: a React application, createClass era, before redux was a thing, that had everything in one fucking component.
Every fucking thing.
This was a simple video chat application, but still. The component's code included:
- Views (contact list and video call screen) and logic to switch between them;
- All application state;
- API calls;
- Websocket message handling;
- WebRTC logic (getUserMedia and p2p streaming).
This app was built by one person in one month for a demo. That person left the company after the demo and I had to maintain that mess without zero React knowledge (I was doing angular at that time). On his last day he gave me a crash course and an overview of how the app worked.
Around that time I attended a few meetups and a conference with talks about React. That, my curiosity and ability to learn by refactoring helped me a lot when I had to add new features and fix bugs in that app.5 -
When you find out you didn't need that if-else statement in your code if you simply made an additional variable with an expression that works for all cases of that if-else statement
-
I love refactoring :) just finished going through implementing accrued knowledge from the last 6 months into all my client side code and just doing that opened all kinds of doors for new features and niceties.1
-
!rant this is just a shoutout, how fucking happy I am. Clean code valued over fast but hacky push of features!
Backstory. I work for a startup. Long story short a guy with an idea needed a developer. I've worked for about a year without pay but now since we're live I get paid. Recently a new field of bussiness came up. I told tge guy with the idea (a.k.a. my boss) that we either could just "hack" the current code to just make it "fit" well kind of... Or refactor our main code base, as requirements where changing at least monthly and we just built on top of the monolith.
Don't get me wrong. It still isn't perfect. However I was able to refactor the main business logic for the last few days, as he understood, it's an investment into the future.
Good guy!
P.S. On another note: happiness or happyness? :O1 -
I'm rewriting a game from C++ to C just for the purpose of learning and adding more features, however; after I refactored the code, the game broke with a segmentation fault and I have no idea where the memory issue is.
I've been debugging for hours now and I've got nothing. FML5 -
First software refactoring in the company I worked for. No test environnement because "who needs it?", no unit testing, no comments, had to make sql updates and shit, was scared all day long that something would fuck up.
"Fuck fuck fuck, forgot a part of the where !" Had to fix everything quickly so no one would notice, no coffee/smoke pauses. On top of that, got a ton of retarded requests from the PM and other technicians working with me like "hey boi, could you add an icon to every button we made? There's like a thousand, we need it for tonight, our client will come visit us and I want to show him a better interface blablabla"
And since I was an intern, I couldn't refuse, had to work like a prostitute in virgin-land, and for what?
"Oi, you did good, now do other stuff"1 -
Ah good ol' refactoring summer.
*Me starts refactoring spaghetti bolognese*
- Hurrah everything can be generic and so much better. I'll just do this and this and this and this, oh and this also needs to be reworked cuz of this.
8 hours later.
- it wasn't that bad!
$ git status
- oh god
$ dotnet test
- welp.... I need something to do tomorrow.4 -
It's a Friday and buzzing from refactoring absolute shitty CSS code by reducing it by 2200 lines (and still not complete). Who the Fuck wrote this complete piece of shit!4
-
Refactoring a method of a 5 year old system. Probably one of the ugliest code I have ever seen. This is just a little piece of the ugliness
6 -
when u feel that u wrote some godlike code. 2 months later client wants to add new features. then u realize ur code needs major refactoring. "what was i thinking, far from godlike"
-
That moment when, after you've spent days trying to refactor your code to be clean and readable, you look at what you've made and you honestly feel like you actually made things worse than before.1
-
Refactored my current portfolio grid :) Decided to remove margins for a cleaner look and removed slideshow functionality because things became too slow and it really doesn't need it.
7 -
I just spent an hour refactoring and output-beautifying a one-off console script
You can probably understand how bored I was in the train -
The boss wants to improve the QA by introducing GUI tests (partially non-automatic) instead of refactoring the legacy blob of application with unit and integration tests.
THIS WONT MAKE IT ANY BETTER1 -
Yeah so I quickly hacked stuff together. Why make it beautiful before I know whether it will actually do? Hack now, refactor later!
Yeah and then that moment in refactoring where main() gets under 700 lines and I don't know whether what I'm feeling is joy or despair. Gaaaahhhh!
At least I have also written automatic tests so that I can see when something breaks.4 -
Working on a project with tests is so nice.
I love tests. Well, I hate making them, but now refactoring is so easy :] -
I have to create python parser (3.6) using code provided by client (2.7), that they used in their company, and it is full of crap like:
if a==1:
if not b:
c = [1,2,3]
if a==2:
if not b:
c = [1,2,3]
if b:
c = [1,2,4]
Or:
text = ""
for i in something:
text += "real text " + some_string + " \n"
text += "another line " + some_string + " \n"
text += "and another " + some_string + " \n"
text += "and so on " + some_string + " \n"
... (many lines instead of one appended text block)
Of course above variable names are just for shortening code, but there are variables like oo, ooo, var_ or var__... cause you know, PEP8 does not exist.7 -
Spent all day refactoring lots of confusing code down to just a few lines. I am satisfied, frustrated and drained all at the same time.3
-
Today I deleted a lot of stuff
Fields, methods, classes, files, even database tables
And for a change, it was all on purpose 😁
Feels good to refactor stuff and clear out the cruft!3 -
* Start maintaining/upgrading new project at work
* Read book on best practices for the framework
* quickly realise all the "don't do this" parts of the examples in the book is EXACTLY how everything in the project is done
* cry self to sleep -
Because almost all the answers from stackoverflow are still optimum, even if it's 7 year old code, all it needs is some good ol' spit shine refactoring
-
Refactoring is like dating. You have to remember stuff, maybe you're insecure and you may have to overcome yourself to actually do it.
But when it works out, it's great.2 -
One of the best feelings is when you're hip deep in code refactoing and you're delezing old code with your new and shiny code.
-
When refactoring legacy code and your colleague committed this a week ago... As punishment we made him listen to "You're too fat to fly" all day long.
-
Spent the day refactoring a REST app into graphQL, that feeling when all tests are green and everything is committed and merged 😧🤓3
-
Pair programming a major refactoring, colleague tries to change _everything_ simultaneously. Spent hours fixing compiler errors, now it's not linking. ¯\_(ツ)_/¯
-
I don't know what's wrong with me this morning. I started refactoring, and I know I'm overdoing it. I can't stop myself. I'm stuck fiddling over it like a meth head scratching his skin.
Please stop me. I'm hurting the code.2 -
We just found out that refactoring our code -base is no longer optimal for the health of the company because our deadlines are too tight. We'll get back to refactoring in a year.1
-
When you find an awesome, intelligent way to do something after thinking you had already found one and implemented it already.1
-
From the book
Refactoring JavaScript
Turning Bad Code into Good Code
Evan Burchard
HOW CONVERSATIONS ABOUT REFACTORING SHOULD GO UNTIL TESTS ARE WRITTEN
“I refactored login to take email address and username.” “No, you didn’t.”
“I’m refactoring the code to ____”
“No, you aren’t.”
“Before we can add tests, we need to refactor.” “No.”
“Refactoring th–”
“No.”
“Refa–” “No.”7 -
I can't make progress on my private project.
I just started and already refactoring my code.
Yesterday I started to refactor my tests -.-'
I'm sure I will lose the interest in this project because I start a new one I can refactor to death.8 -
Ugh. That may have been a mistake.
I'm deep in a large effort to refactor my project. It's a one man deal and something I've been working on pretty much every day in some fashion for nearly 10 years (five years ago I started a scratch rewrite to move from a fully CGI server rendered application to a browser rendered asynchronous version built around JS) and that took me three years.
I started this refactor about 8 weeks ago. Turns out I've been tackling the largest modules and progress has been decent. So that's good.
But I got to wondering ... Just how much code is there?
So I whipped up a quick script to do some calculations. Read each file and get a line and word count, skipping empty lines.
In JS it turns out I have 83,973 lines and 467,683 words.
On the back end, 86,230 lines and 580,422 words.
Average publishing stats say the are about 250 words/printed page.
That means I'm confronting refactoring 1,870 pages of JS. That's the size of several decent sized novels. (I think I've done the equivalent of Maybe 400 at this point).
Makes me feel like the walls are creeping in to know how much is left to go ... -
So why the fuck did you go into code that I've written, change the name from "mode" to "type" throughout the >1500 lines of code that's relevant to the feature, and then move on to change my implementation to something that is arguably not common practice for the language and framework we're using, and in turn create duplicate state? And why the fuck weren't these changes in separate clear commits, but instead scattered over multiple commits? You're supposed to be senior!5
-
Looked up at the clock... 2 AM... Thought about giving up and going to sleep, but something kept me there...
Rewrote my encoder and decoder for my steganography program, which are used to insert and retrieve data respectively from images. Compiled, ran, and output was as expected!
Tried to write actual data, instead of just headers, to the image, and it broke... Of course it wouldn't work first try, it's me writing the code after all.
But then, after debugging for a while and changing a couple lines, the encoder looked like it had done its work properly. Then I decoded it, and voila, data completely recovered! It almost felt too magical to be true, usually I have to modify a lot more to get it working.
So now I'm in bed, after literally decimating the memory usage of the program, amongst other optimizations, and I know that the code works perfectly 😎 best part is I refactored each class down to 100 lines each, so now it's clean and dense 😇
Just had to share, feeling so good right now 😄2 -
Spent the whole day trying to refactor a program that consumes an API and didn’t work out. Now we have one less day to try to improve the product.
I think the fault was that we were aiming too high by looking at other libraries and we ended up over-complicating it. -
So I've been back to work for 2 weeks after going on a holiday. Getting back into the flow of things was easy, but seeing the status of the project that I am a part of, and seeing the kind of implementation work that my co-workers has done, it's kind of a no surprise.
So the past 2 weeks I've been completing features that I left my co-workers to finish, but didn't. And rewriting other features that they worked on, but does not meet the specifications.
Will I ever be able to work with reliable/competent developers? -
When you work 2h on a feature and you forgot to commit before merging. Fortunately this also opens a new opportunity: refactoring
-
Okay, I realize that it doesn't mean anything, but I've been working on trying to solve this freaking Codility challenge for like a week and while I had a solution that would give me a silver award (the tests that weren't performance-based had me getting the right results, I just timed-out for performance tests), I really wanted to get a gold one. And I FINALLY DID.
https://app.codility.com/cert/view/...
Just in time for having to do a technical phone screen for a company. Maybe I'll go into it feeling like a competent programmer.7 -
Man... I hate refactoring. After I had finished up an issue this morning, I had to refactor old sql queries and the parsing to the views.
I've worked on it all day and I still haven't finished! Still loving my job, tasks like these are unavoidable but they drain the life out of me.3 -
I discovered the Source Making website a couple weeks ago, it's awesome.
It gives you clear tutorials on the essential design patterns and refactoring techniques complete with example situations and code. Love it!3 -
i strongly recommend considering multi language support before starting a project. implementing it afterwards istn't that much fun as anticipated4
-
Just found a crystal subreport with 33 shared variables. For those who don't know what that is (lucky), they're super global variables that exist everywhere.
Please send help. I'm supposed to refactor this...19 -
Transferring our website from (outdated) SAPUI5 to VueJS.
It's so painful to look at 6 years old code... And at least 10 different coding styles.3 -
TMW you want to introduce a big feature that will require you to refactor the existing code, but you don't have to worry about breaking the latter since you have tons of unit tests backing you up.
2 -
I'm a bit cornered. A week into an ambitious refactoring effort that was supposed to take just a couple of days to finish, the end doesn't seem anywhere near. The system went from a messy albeit perfectly functional state to a much better structured non functional bag of bugs. If I leave the branch all the efforts are lost. If I soldier forward I'll be unproductive for good knows how many days to come.
How did I ever fuck myself so hard!1 -
I totally want to refactor my project's code, but I don't have any time for it and now it's a working piece of spaghetti-ish 😭
I'm just praying I'll get to do it once it's actually finished, so I don't have to work with it again in like a year and want to travel back in time and murder myself.13 -
I refactored a bash script written so badly that it had fewer lines of code even after added a few new features
Link: https://github.com/dasgeekchannel/...3 -
got the rest of the boxes out of storage and found this book I bought about 6 years ago. thinking about rereading it for fun.
2 -
Finally started new job this week in programming language and frameworks I never worked with.
I’m already refactoring code 😂4 -
Why do I always have to refactor bad written code ? Is this some kind of karma ?
Undocumented, written by a senior but looks like it was a junior, no unit tests, variables with meaningless names, duplicated code and every possible thing you can find in that kind of code.3 -
Start a task I thought would take 2 days. Start getting into it deep and wouldn't you know the amount of circular dependencies, data being passed by singleton's (not saved though) so you really have to search the codebase to find where that data is being set and get. A ton of classes that are base classes so they don't have the regular CMS getters and setters I'm used to.
I really thought this one was going to stump me.
But it took 4 days instead of 2 to sort through the mess.
It's finally finished. Happy Friday! -
I promised myself that if I didn't start up a new relationship by September that I would plan to start a new lease in life and move in 2019. The online dating subscription I've used for a few years will cancel at the end of this month.
I used to doubt that fate was real, but times like this make me come close to believing in it. Maybe fate is just one large karmic refactoring.4 -
has anyone here done a proper refactoring? i mean, documenting, following some rules, etc.
i need to know the process and guidelines for refactoring, what & how to document, where to start, etc.
i am assigned to a project for a short term and my job is to do refactoring of Reactjs code. and i need to do it in a really good way.
any help would be highly appreciated.
thank you.2 -
Talking to my architect:
- hey, we have a lot of code smell and data is structured usually in a chaotic way, also its hard to understand what is going on with all these code duplications, maybe we can think about refactoring, better structure, maybe even we can extract some domains and make life less painful?
- what is domain?
- *facepalm*4 -
Refactoring code that I've wrote like a year ago, made me realise how much I've grown in the past year, do you guys ever go back to old code that you've wrote?3
-
I was on a call with a colleague and we talked about my next tasks.
He was building some stubs and shared his screen with me so I knew what to do after he pushed these changes.
We talked about refactoring one method and he wrote "throw new NotImplementedException()" in the first line of the method and said: "I'm evil ;)". -
WTF?
Just found this code:
"It is assumed that all 'static final String'-Attributes of this class are a key in the property file (which is validated by reflection)."
SO REFACTORING YOUR FUCKING MAGIC NUMBERS WITH A MEANINGFUL CONSTANT MADE THE APP CRASH. ASSHOLE. -
Having to deal with my own stupidity.
Refactoring sometimes is as hard as remembering the date of birth of a douchebag2 -
Last week I had two days training about how to code modern with the language I use.
Now I wanna refactor every single line of code I ever wrote :D3 -
Sometimes i like to break my code on purpose, to force me to refactor those parts and rewrite them more efficiently.
I find it hard to improve existing, working code, because it limits me and it does not inspire me to come up with something better -
I recently refactored the horrible main.js of one of our clients. I didn't even know you could fit so much shit in "just" 700 lines of code (yes, it's really that big...). After 3 hours full of swearing and grinding teeth about this piece of shit, I was finally done and tested it.
It was so incredibly satisfying to see the page loading twice as fast! -
Writes 4 years worth of CRM code.
Forgets TimeZone Support.
1 Week later, supports TimeZone.
REFACTORING! -
I got frustrated with my code. I decided to open a new file and rewrite everything with better descriptive names to variables, and combined 3 functions that basically did the same thing into one to be called. It cent nice until my shift was up and I had to go home.1
-
Inherited a massive code base today... All JS is still being accessed via global scope... what are modules & modular design even... SOLID and DRY are things that clearly never crossed the devs mind during inception of this beast... and to top it all off all there is a weird BEM / SCSS style going on that somehow manages to confuse the IDE... thus all style helper utilities in the IDE are useless...
2 -
i am so excited learning. now i'll start refactoring my plate of spaghetti into object portions. both are new topics to me.
-
Things could be soo much better if I could just refactor this code to accommodate more than one web service... #soapmessages #devwoes
-
!rant
Just started a side project, helping a friend make his Android app more stable and add a couple more features. We'll release the sources sometime later.
Gotta say, his code is just terrible. And it runs on top of some code written by someone else, and that's even worse.
But I don't know how I got the motivation to spend the whole Saturday cleaning it up, fixing warnings, making abstractions, extracting features to separate classes, converting some stuff to Kotlin, even adding a couple coroutines. It felt good fixing bad code.
Maybe because I have some coding freedom I kinda miss at work.
Maybe because the project is not that big.
Maybe because I know the guy has many skills, coding is just not one of them.
Maybe because that project has some cool in it I can't even describe.
Maybe because that's entirely within my skills but challenging enough to have fun working on it.
Or maybe is just the mood of the moment, and in a week or so I'll lose all the motivation, as it happened too many times.
🤷♂️2 -
Perfectionism... I often refactor my code because I always see something that could be "done better" in my own work, which can slow me down if I'm not paying attention to my main task.
If I could stop time I would perfect my code all day, but that isn't realistic. 😂
Doesn't apply to dev work only, I've had to learn the art of not giving a shit about every single detail in many other disciplines. I just love getting things done really well. -
Just by refactoring to use the correct data types to skip all checking and conversions and also use data bindings, the performance increased several folds.
Why take the time to refactor? It would probably take longer to implement the new features if I did not. -
Not being able to do refactoring on an app that contains 900+ line view controllers because "its not safe to do refactoring before the demo at the end of the month"
F.M.L -
When you have to refactor the whole microservice to fix package structuring so it can be modular...why can't people do it correctly the first time?
-
statics: just because you can, doesn't necessarily mean you should. now I get to spend my day cursing the guy who hired me 4 years ago, and who was fired 2 years ago, for his turrible design choices.1
-
Refactoring code to meet style guide..... 20 bucks says outside of my code reviews no one will look at it for years.
-
Started refactoring our app with Android Architecture Components 1 week ago.
Now Android Oreo is released and I don't have to worry about breaking changes anymore.
Yaaasssss! -
I am starting to think the biggest problem with my current project isn't the business unit changing their minds all the time. It looks like the biggest problem is me continuously refactoring the code.
-
I just finished refactoring the code of a single jupyter notebook into a decent structure with comments. It feels good.
Unfortunately I still have stuff to implement and it's 2:50am :(5 -
Colleague says some of my code sucks, says he's gonna rewrite and improve it.
After he finish his work, I look in his new written code:
F*ckload of unused methods and classes,
some usings of deprecated API calls...
god. It's okay, if you want to help and improve code (my code wasn't the best, I admit)... but when you do, do it the fuck right. -
My project is a cloud based automated testing product. My current story is to extend a module to support multiple of a particular testcase type in one test run instead of just one. This has uncovered a rats nest of complexity because everything is designed with the assumption that there will only ever be one of these testcases.
Refactoring about 5 different classes just to get into a state where i can pass a list of testcases into a service instead of just one. Wrecking my head... -
Today I learned if you ack a message twice, RabbitMQ shits the bed. Dang. Another day wasted on a dumb refactoring regression.2
-
IntelliJ refactoring tools because......because.
Least favourite dev tool: Xcode refactoring tools because they still dont support Apples own language. -
Spent the day refactoring old copy-pasted astronomical code with minimal commentary, cryptic variable names and missing mathematical symbols. Self documenting code my ass.1
-
When people "simplify" their code by refactoring a singular line of code into a completely separate function. The purpose of which is to prepend "https://"3
-
Was going to have some fun refactoring js code on the weekend, gf dragged me to a jazz festival instead </3
I enjoyed it, though -
"Anyways trust code that you wrote before but... never rely on that!"
I wrote some code mounts ago, now when I want to refactor it see a bunch of shit, I delete them all and after hours write exactly the previous code!!! just because i don't put some STUPID comments... 😑1 -
Just to clarify my previous rant:
In this case, refactoring meant changing class, method and variable names -
We're doing refactoring and deciding on which class to go into which module. A colleague said, "garbage put in core, shit put in common".
Me:
-
When you make a massive change to the code base and run the test suite to drive out functionality but nothing fails...
-
I decided to rewrite the cross-window comms lib from the ground up. After all it isn't too big (some 500 lines for the first level, 300 for a little abstraction) and the original is more of an artwork than good code. It somehow works but there are as many explanations as to why as viewers and nobody is allowed to touch it because it would probably break.1
-
Boss showed a not-impressed face when I said I'm refactoring. I thought I'd been doing fantastic job coping lousy written old codes? Wtf boss!6
-
!rant
Just did some really satisfying refactoring. Much happier with my work now. Its a little cli app to poll M-bus devices and write the data to file if the user wants. Can scan the whole range, search for specific devices and VIFE codes, parse an input file for lots of the previous data and one or two other things.
How's everyone's else's weekend? -
I have a changed a project that has many many many bugs because of outdated code that kept it from working. In the process, I changed the structure of some feature implementations in order to get the application to work again. Can this be considered refactoring, or is it just a special kind of bugfixing?
Also, can I call something a rewrite even though I'm not actually writing anything, just using a GUI environment to create the same functionality again?
I need this because I'm writing about what I'm doing for my university and I can't find it on google - I guess it's opinion based.1 -
there is no time in the budget for refactoring the code that is being shipped to live.
the only refactoring i get done is the code going into my portfolio. -
So the product has been labeled "ready for launch" for months, but the client has apparently been procrastinating and weren't ready.
Finally, earlier this week, they claimed they were set for launch, and that I should prepare the final bits.
And now they demand additional functionality which requires refactoring code.
Sigh. Why, oh why?1 -
I'd have the power to lint developer brains so they'd write clean code and I wouldn't spend so much time refactoring crap.2
-
Refactoring is the revelation that the name "foobar" is pretty dumb and you should rename the function to "sine".
-
Sometimes I feel like my PM might as well just say "I don't believe in refactoring, as I don't make any mistakes."
-
when you don't know the timeline of the project you're working on. So you don't know if you should rewrite everything to be more flexible in the future2
-
Have you already met the code that you have no idea how to refactor?
In five years I met those twice and I'm still puzzled with one of them. (I don't mean just a spaghetti or too long code) -
This currently project I'm working on is taking a turn for the worse. I keep finding missing features from the designs, but then also the project manager remembered that there were these other requirements that were needed. She only remembered after I raised an issue about another problem because NOTHING has been written down. A wireframe is NOT a fucking requirements document.
So now I have to refactor 2 major components just to include this sudden new requirement. I really hope I don't work with this project manager ever again on any future projects. -
I was planning on migrating my Mastodon instance to a new node, but then I looked carefully at my deployment scripts. I had built in support for multiple servers, but not everything supports it, and the configuration is messy now that I think about it.
Now I need to write a bunch of tests, and then refactor a bunch of my code. Hopefully I can get this done before I run out of space on my Mastodon instance. It's gonna be a fun day. :-P -
Ahhh, this kindda makes me sick...
Wrote something.
Wrote documentation - 2 weeks.
Changed few things and refactored - 3 days.
Refactoring and updating documentation - week and counting.3 -
WTF ! Spent the whole day yesterday refactoring an old code and today a new requirement came, which adds a new functionality changing the entire code again.
-
I love and hate javascript. I set out to do a fully ajax/state driven form interface that operates with multiple interdependent data objects which all extend a base class.
React/Angular may have been a better call but I just didn't have time so I needed to rapid prototype in jquery /vanilla JS.
I'm in the midst of learning and refactoring all the ajax calls to promises and then to async/await, so it's a huge learning experience...
Meanwhile I've got to build objects to represent the data on the backend which is all legacy OScommerce/PHP
Hell of a ride. -
[GIF] This code looks pretty old, I wonder if I can delete th.... what the... https://twitter.com/iammerrick/...
(Sorry, I was not able to download the GIF from Twitter's app) -
That thing where you stay up way too late and end up dereleasing and refactoring a huge chunk of The Monolith....
-
TFW your collegues rename and refactor everything, don't comment on their commits and then break EVERYTHING when you merge their changes into your branch. FFS.
-
When you are asked to show a minimal working demo of what you have been working on past 2 days but you realise you are in the middle of refactoring those 7 files. Now you don't want to undo nor have time to finish remaining work.
-
Got a new user story for code refactoring of my previous stories.To motivate myself i am trying to think like
" it's much better to clean my own shit then others."
Top Tags
Weekly Rant
View