Get the app to ++, post and comment
  • 13

    I was told Friday I had trust issues because I wanted to code review pull requests from outside the team.

  • 1
    It's difficult to understand why this would be an issue. Surely just good governance. Very odd reaction. I guess if you can provide some examples of why you feel this oversight is necessary, it might be more convincing.
  • 0
    Sounds like a good plan to me. Maybe they just don't like the idea of outsiders peeking around at the code?
  • 0
    I gave specific examples, known good practices, details of what we review for, expected outcomes for stability if we didn't, etc. The Dev lead and management arguing against me claimed that process didn't scale and we didn't have time to review because of the timelines. Face palm.
    The Dev lead also told me that Agile kills Conway's Law. ROTFL.
  • 0
    @Jase it's actually another internal team that would contribute, and I'm a huge advocate for looking at my code. I'm not, however, a fan of allowing an outside developer access to Master when I'm executing Continuous Delivery and my team is responsible for keeping the delivery pipelines clean at all times.
  • 1
    @yamatoman As soon as someone says "We don't have time to do reviews" your project is doomed. So naive. Hope you have time afterwards to fix all the bugs that come from not having the right processes at this point.
  • 0
    @samk oh, I'm senior enough to push back. If overridden, I can do what the other devs on the team will do, find another internal position. We aren't signing up for chaos. :)
Add Comment