Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
that's rough.
But it's also kinda understandable. Nobody gave you that exact task. But on the other hand sooner or later someone should've done it anyway.
So it's out of question if it has to be done, but when. And my guess is the sooner the better.
You could ask him, if he wants to do it instead, when nothing works out of the sudden, the there's a deadline or something in view. -
@thebiochemic we have a 50 day deadline for the routes work, this definitely should of been done way sooner so thought it best to get ahead of the curb and start the cleanup early while I’m going through the app anyways especially if we have some time left before the deadline which we will.
No-one gave me the task for the extra clean up site but there’s no harm in showing some initiative, well that’s what I thought anyways haha. -
@HolyTeabags yeah sadly most of the time it's that way.
If you do too little, it isn't right.
If you do too much, it isn't right either.
Just do what's on the list.
So working for a company and the dev team I’m apart of works on a legacy rails app. Technical debt is high, no automated tests, no proper routing and also running unsupported versions of the language.
I joined seven months ago and got the current team doing automated testing so that’s a plus, they bought this app four years ago and there’s been no language updates, testing, cleanup, security updates, nothing, just adding to bad code.
Now we’re looking to actually upgrade language versions, the language and the framework now this will cause a lot of stuff to break naturally due to how outdated it is.
So I started putting proper routes into place how things should of been when things were being built as we have some spare time I decided to go out of my way to clear up some of the technical debt to get ahead of the curb. Re-done an entire section of the app, massive speed improvements, better views, controller, model, comment clean up and everything exactly how it should be.
I push the PR,
*other dev* - “why are we doing all of these other changes”
*me* - “well to implement routes properly, we have to use the new routes I just did some extra cleanup along the way”
*today, me* - “can you lend me a hand with one of the routes the ID isn’t getting passed”
*today, other dev* - “this wouldn’t of happened if you didn’t redo all these files, let’s just scrap the changes”
…
Sooo, I’ve spend three weeks improving one section in the app, because I’m having issues with one route according to this dev I should scrap it? Wait come again, am I the only one in this team who cares about making this app better all round?
Frustrating…
rant