Comment on a code review:
How does this relate to the task?
Most of the changes have nothing to do with the task, but half of the code & build system was either wrong, broken or not following best practices. This particular change is because something was broken.

  • 4
    Do things like that in a separate PR and everyone is happy.
  • 4
    @Lensflare too busy fighting fires and fixing other people's fuck ups and incompetence. I got dumped on this project when it was already 2 months behind and nagged about how it was "high priority", like that's going to make me work faster.
  • 1
    @Lensflare Of course it can be a separate ticket+request. But that is just extra admin work.
    As long as it's a separate commit I'm happy. The PR/MR will not deploy properly otherwise so doing it here is fine by my standards.
Add Comment