> some other team leader reviewing some code I wrote
> "NOOOO NOOOO YOU CAN'T USE ALL UPPERCASE IDENTIFIERS, IT'S BAD PRACTICE, NOBODY DOES THIS"

Today on: people rejecting PRs because they dislike a perfectly valid style for writing enums

Uppercase enum keys are a convention, but don't do the same to the enum name itself wtf

JavaScript. Bleh.

Make the entire team Use an agreed upon fucking same fucking linter.

INB4: MY GRANDMA USED TO DO ENUMS LIKE THIS AND LIKE THAT AND SHE LOVED ME SO MUCH OF COURSE SHE WAS RIGHT

Nobody cares. There's not a single style for writing enums in JS, as they're not an official feature so everyone kind of come up with their own ideas about how you're supposed to implement them.

Google uses all caps for the internal fields and camelcase for the container, Airbnb does the exact opposite and uses all caps for the container and camelcase for the internal fields.

Main take here: you think your way is "the truth", you're wrong. There are several schools of thought and the team had no rule about this at all.

If you reject a PR which took some 40 working days just because you happen to dislike a style you're a moron and should be kicked in your fucking teeth.

Ever wondered why corps don't want devs that also are rebels at heart? This is why. Rebels don't fit into corpo hierarchies and can't deal with the obligatory red tape. You where probably already annoyed that you even have to make a pull request instead of just pushing it on staging like a free dev.

If you can't stand red tape and coding standards dictated by higher up, go somewhere where there is no ladder. Small companies with only one or a few devs exist (they are harder to find though). You can be the rockstar if you want to - just not in a setting which is incompatible to rockstars.

@Oktokolo except -as stated- there was no style agreed upon for enums, since nobody used them at all. This is literally some random guy rejecting PRs because he decided out of the blue his style was the standard.

Ah, yes… js "enums"

@IHateForALiving Actually, i would advice against enums in JavaScript too.

@Oktokolo again, every rule is fair, and that goes for your "no enums" rule too. I may disagree with it, but I'll respect it. Someone needs to write it down somewhere BEFORE I write the code, tho.