Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
![](/static/devrant/img/pipeless-devrant-banner-white.png)
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
retoor9304106dI would focus on the wrong parts touched in review, the rest doesn't matter anymore in that case. Maybe just a bad day?
-
devJs1303106dI would ask if everything is ok, do they need vacation or if they are maybe under the stress. That is if they never had nonsense like this pushed to repo before.
If its the first time, then it's a good teaching moment about how we do things here and why. But also an opportunity to ask what they were thinking they're doing with that code - good for double checking skills. -
gitstashio284105dDoes it solve the problem?
Is it readable?
Can I discard the bad parts and keep the good ones and also have the code running? -
Crost4110104dTalk to them about it.
If no improvement talk to my boss.
Ultimately accept that they will not be sacked or moved to another team working on low priority tasks because that would involve a manager having to do something difficult
Take matters into my own hands so that they never get to work alone on a task or work on anything that matters ensuring the company pays someone for doing nothing which is preferable to the company paying someone to fuck everything up
As a team lead, what would you do if one of your direct reports sent obscenely bad code for review? Like absolutely nonsensical, non-working, touching wrong parts of the project, doing wrong things… Terrible even by your company's standards.
Would you consider it an instance of stupidity? Tiredness? A resignation letter? An insult? A cry for help? A combination of those things?
question