11
kiki
24d

As a team lead, what would you do if one of your direct reports sent obscenely bad code for review? Like absolutely nonsensical, non-working, touching wrong parts of the project, doing wrong things… Terrible even by your company's standards.

Would you consider it an instance of stupidity? Tiredness? A resignation letter? An insult? A cry for help? A combination of those things?

Comments
  • 5
    I'd ask them about it
  • 2
    I would focus on the wrong parts touched in review, the rest doesn't matter anymore in that case. Maybe just a bad day?
  • 3
    maybe they got brain worms
  • 2
    @jestdotty Robert F. Kennedy Jr?
  • 2
    @galena I SAID THIS BEFORE IT GOT FAMOUS
  • 2
    I would ask if everything is ok, do they need vacation or if they are maybe under the stress. That is if they never had nonsense like this pushed to repo before.

    If its the first time, then it's a good teaching moment about how we do things here and why. But also an opportunity to ask what they were thinking they're doing with that code - good for double checking skills.
  • 0
    Does it solve the problem?
    Is it readable?
    Can I discard the bad parts and keep the good ones and also have the code running?
  • 2
    Talk to them about it.

    If no improvement talk to my boss.

    Ultimately accept that they will not be sacked or moved to another team working on low priority tasks because that would involve a manager having to do something difficult

    Take matters into my own hands so that they never get to work alone on a task or work on anything that matters ensuring the company pays someone for doing nothing which is preferable to the company paying someone to fuck everything up
  • 1
    @gitstashio no, no and no
  • 0
    @kiki Then erase that POS code and let it be forgotten.
Add Comment