9
BordedDev
79d

PM tells me to merge (large feature) work that's heavily under WIP.

In that is a performance optimisation he instructed (with an aggressive DM) me to stop looking at even though it's a concern for larger clients that I had to fix before as it's "unnecessary" - thought whatever I'll leave the code as is then

I tell him him the PR is not ready yet, there is still a lot of clean up to and tests to write

Just do it

A ~week later "wow you write really selfish code like look at this"

Shows a wrapper class from the optimisation with 2 properties and getters and setters (and override some of super's properties). I explain to him why it's there, "that should have been a comment". I tell him I write detailed comments as part of my refinment process which he wanted me to stop.

This is after he tried to merge a release branch into main while sneaking in some "corrections" and I pointed out it breaks Dev.

Comments
Add Comment