4

Ok, im hired here as a frontender. Formally the designer did a bit of it. The site is shit. I want to fix everything about it basically. But, the thing is that we are working according to gitflow so someone has to check my code. But backend is like: thats frontend. And the designer is too busy and just wants to see the pixels. So who is checking my PR’s now? Guess i’ll do it eventually... it’s going to test first anyway

Comments
  • 0
    If there's no-one else suitable, surely your manager (assuming he's technical) should?
  • 0
    Tell backend to stop being a little bitch, Review for code style, run the tests and give feedback.

    Code review is not about testing if the solution works, it is about peer communication, identify un-tested scenarios(maybe) and code style

    The designer probably can't help you with any of that anyway
Your Job Suck?
Get a Better Job
Add Comment