Functions should not be 374 lines.

Does that go along the lines of database queries should not be 1000 lines long?

Coz man do I do things wrong 😅

Mind you it's quicker then collecting the data separately in different queries and doing the calculations 🤷‍♂️

@C0D4 ya know, at least that's a legitimate reason. I'm dealing with a case of the previous dev on this project never having heard the term "Object Oriented" in their life.

@OmgItBurns oh one of those.
Yea those projects can be "fun" especially when the dev barely graduated to reusable code let alone OOP.

I write my entire application in one file in the main function. Fuck you!

Ok I'll remove all the line breaks

374 lines isn't bad provided that the control structures including if/else don't stretch out that much.

My functions often have that length, but including comments , { and } on lines of their own, line break after variable declaration also within blocks, and line breaks between small blocks that are a bit like a paragraph.

Yeah... Wish my teammates read this someday...

at least split it into 10 functions that each one specialices in doing one thing right.

And here I am reading a class with more than 2k lines

Had debug a vb legacy function with +2k lines the other day
If condition Then
'1k+ lines
Else
' the very freaking 1k+ lines with 1 extra line somewhere in the middle
End If

Ffs!