Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
Wow. This is seriously bad.
A possible reason: He does not know better?
Take him aside, and tell him something like this:
"Thank you you did this. While your code works, we cannot ship that. Here is my suggestion about what can be improved: ... (obviously with reasons)"
As he did not know better (I assume this), you give him both: acknowledgment of his work (maybe even this garbage was hard work for him) but also critique. -
@sbiewald Yeah about that I knew, he didn't have worked with oops before, that's why I gave him a class example code and other resources to study even after that he wrote this shit.
-
@shoop oh it's you again. Just don't start language war again
-
I mean.. it's always easy to bash someone's code, but this is among the worst I've seen.
This is something that must be sent right back after code review. In all honesty, if this dev thinks their modification makes this code object oriented and they are unwilling or unable to learn - then they are possibly not fit to do the job they are hired for.
I'm dreaming to send homework to my C++ programing lecturer full of strange #defines and make the code compila...
I told a guy to implement an algorithm in cpp. He wrote this weird 600+ lines of code which contains only global variables and void functions then I told him to make it object oriented and he just put all those garbage in the class and gave me back and on top of that class name is Template and file name is template.cpp. I don't have words to describe his code. May be this picture can help you understand my state. Oh, if you think this matchOn_r1, r2,r3 are different then you are mistaken they are just different with one argument (one global argument). This is just part of the code. He has this shit all over the place. Why the fuck this kind of people exists?
rant
cpp
shitty person
garbage code