8

The reviewer said one of the code lines was indented wrong and move four spaces to the left so rather than arguing I did, then his response was..."Sorry, I meant three."

He was wrong both times and it should have been to the right...an if else the previous dev hadn't indented.

That seems like a lot of drama for some spacing.

Comments
  • 0
    Theres no *rigth* ondentation. Everypne indents like he wants. 4 e. G. K indent with double tab
  • 1
    We follow the PHP Standard Recommendations (PSR) at work (yes we use php) and these also include coding guidelines so I often attend my collegues to follow them even though code might be perfectly readable without. I don't go crazy about them though, just as something to keep in mind.
Add Comment