Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
Looks fine to me (sans not having Rx ;) )
Only things I would probably do differently would be:
- Endpoint strings in configuration
- type unions as enums should probably just be enums. Referential integrity, save a few string instances -
@SortOfTested I’ve used enums in order to lessen confusion of certain use cases in the hopes the key is more descriptive if you go all-typescript
-
@010001111
Type unions as enum meaning these guys:
https://github.com/dr010001111/...
Edit note: typescript has heterogeneous enums. You can assign a string|number|date etc to the value. -
@010001111
Submitted a PR. Has some auto-format dust. Propose adding a .editorconfig.
Related Rants
Probably no news about the PWA today, but this:
https://github.com/dr010001111/...
Tell me what you think.
random
api
devrant