Code review with some people is emotionally draining. How do you keep encouraging someone to get better without being a dick when the improvement isn't there?

  • 1
    Subscribing, will be interesting to see what people have to say about this.

    It's a tough one, I'm in this situation now, it's hard not to be over critical. I just keep reminding myself we all have to start somewhere.
  • 1
    I usually work with questioning why they wrote this particular piece of code this way and not the other. Makes them think about it...
  • 0
    What are they doing wrong? What are the problems with their code?
  • 1
    Write with them/pair program more. If your suggestions aren't sticking, that's probably an underlying reason. See if you can work through that.
Add Comment