Details
- 
						Skillsphp, rails, js
- 
						LocationAustin, TX
Joined devRant on 12/14/2016
			Join devRant
Do all the things like
				++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
				Sign Up
			Pipeless API
 
				From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
				Learn More
			- 
				    
				    Playing The Secret of Monkey Island on my uncle's computer in 1991. I asked my parents for a computer that year instead of a Super Nintendo... for school of course.
- 
				    
				    Had a guy put in a pull request with an empty file diff. He comes by two weeks later and asks when am I going to have time to review it.
- 
				    
				    Staying in my previous position as long as I did. I was underpaid, underutilized, and stuck using an aging subset of technologies.
- 
				    
				    So I'm tasked with creating a single sign on link using documentation from the third party we are logging into. So far so good.
 
 Well they don't support some of the fields our users will need--that we don't want to support (otherwise why use a third-party?).
 
 Their solution is to make us the system of record so that when a user goes through the single sign on we pass this info as well. But it needs to be editable on their side well--because they won't give us an API for our system of record to update their side.
 
 That's right only a user signing on from our system will update their side. Tough luck admins on our side. You get double duty due to the poor business decision to work with a company with lazy devs.
- 
				    
				    Code review day 1:
 
 Me: Where are these three templates being used? I don't see any class that uses them.
 
 Him: Oh, yeah. My bad. I'll remove them.
 
 (Time passes)
 
 Him: I don't know what's going on with my branch. Please ignore the PR for now.
 
 (Time passes)
 
 Him: Is there any way for me to get the files from staging. I don't know what I did to my branch.
 
 Me: Hang on. I'll push a copy of the one I have in a new branch.
 
 He declines his PR and stops by to say he's going home but he'll open a new PR tomorrow and remove the unused files.
 
 Code review day 2:
 
 Him: Hey, do you know what happened to my PR? It looks like it disappeared.
 
 Me: You declined it yesterday. Said you'd make a new one today without those extra files.
 
 Him: Ooooh!1
- 
				    
				    Code review with some people is emotionally draining. How do you keep encouraging someone to get better without being a dick when the improvement isn't there?4

