13

We receive an email from Splunk when errors go above a certain threshold, and a particular service has been especially problematic this week (throwing hundreds of exceptions). Email response from the team mgr responsible for the service.

"We are working to address these errors. We don’t currently have a way to prevent a user who’s account is locked from logging into the service and performing work."

The exception? NullReferenceException: Object reference not set to an instance of an object.

The code? (paraphrasing)

var user = GetUser(request.Login);
if (user.CanPerformWork) ...

<facepalm>

I'm doing my best not to reply .."Really? No way? You do realize we can read code, right?"

Comments
  • 0
    Thats looks complicated to fix!
    Login is complicated! Who trust the logs anyways! We are really busy!

    Just escalate, until someone high enough tells them to get thier shit in a box, and leave.
  • 2
    you should have just replied with a fix and attached an invoice for "Feature added: ability to prevent a locked account from making changes"
  • 1
    A single fucking if-clause.
  • 0
    hey!

    Try this for lockouts:

    (sourcetype="WinEventLog:Security" EventCode=4740 src_ip!="127.0.0.1")

    | stats count by src_ip,user, user_email, dest, subject
Add Comment