27
Root
64d

001 REM Code review

010 PRINT "Nitpick nitpick nitpick nitpick nitpick"
011 GOSUB REFACTOR

020 PRINT "This function is too complicated, break it up"
021 GOSUB REFACTOR

030 PRINT "Why do you have three methods for this? Put all the logic in one method."
031 GOSUB REFACTOR

040 GOTO 020
041 REM ARGH

998 PRINT "Looks good."
999 STOP

Comments
  • 19
    I'm starting at a new company next month. During the interview, the senior asked me how I respond to requests for changes, and what I do if I'm asked to review a really ugly PR. I followed with a 10 minute presentation on why criticism is worthless without argumentation, and they seemed very happy. Part of the reason I did that was your rants. Thank you for mapping out the bottomless pit of egocentrism and sheer ignorance.
  • 11
    @lorentz Haha. I'm so glad someone can benefit from my suffering.

    Seriously though, I do try to reason/debate with these imbeciles. It only ever makes them angry.
  • 6
    @lorentz "criticism is worthless without argumentation" you mean it is worthless when not providing a reason right?
  • 2
    @Root trying to reason with imbeciles can take ages and a toll on one's mental health though. Tried and true.
  • 1
    @rantsauce Yeah, is there another interpretation to that sentence?
  • 4
    @lorentz No, I think you're on point. It's just the argumentation part can also be worthless with some people
  • 2
    How my code gets reviewed usually:

    DIM commits(1 TO nrOfCommits)

    FOR i = 1 TO UBOUND(commits)

    PRINT "You have a typo in your commit message"

    NEXT

    END
  • 4
    I think PR reviews are the ultimate test of whether the reviewer is an egocentric idiot. Not providing any reasons for necessary changes or not being open to discuss possible changes is a red flag to me.
  • 4
    @PonySlaystation Agreed. I’m running into that with my current code review.

    The reviewer didn’t read for context first and made a lot of wrong assumptions, and is now insisting I rewrite things in ways that don’t make sense — and isn’t listening. 🚩
Add Comment