Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
They're asking you for help on an issue, not a code review. Why are you spending time fixing his code? They should do that themselves
-
@sam94 I get ya, but I don't think WIP code should be judged as harshly as code that has been submitted for review. Sure massive design flaws must be caught asap, but style issues and WIP code might be for debugging, and I don't think it's fair to the dev to tell them how to debug
-
sam941162yI think it's upto the junior dev to decide , some guys don't mind a intrusive senior guy meddling their code while some stand their ground and push back
Its a matter of preference and boils down to how close of a bond the senior and junior guy have
I don't think subjective opinions and practices like such should be generalised @alexbrooklyn -
NodaiWTF1312y@alexbrooklyn that's right, I don't get mad at the guy for that stuff (because I kinda do the same when heated by debugging), I just can't get ahold of the code with all that padding, so I first need to remove that extra stuff. I guess it's more like a "ritual" for clearing my mind and getting into someone else's code.
Related Rants
Junior Colleague: can you help me fix this small issue in my code? I believe it's located in this file...
Me: *spends half an hour deleting console.log, inline comments and blank lines*
rant
js
developer
bugfix
cleancode