Any android native devs here? I need a code review, any feedback appreciated https://github.com/l2dev/...

I'n not a Kotlin dev, but I now have an api key, thanks 😎

Like most languages doesn't Kotlin allow for environment variables so such things as keys are not in the code base?

@C0D4 of course it does. It’s not even language thing. Every language can read something from a file or the environment.

Kotlin 1.4....
JDK 1.8...
JUnit 4...

2000 called, claims you have to pay fees for being retro.

@IntrusionCM

kotlin_version = '1.8.10'

regarding junit4 dependencies that's just nitpicking since there are no tests.

jdk 1.8? are you an android dev? because that's literally where android is right now unless I don't know something? can you give me a reference to android project that uses a higher version?

@IntrusionCM seems like u dont know what u are talking about. Go download latest android studio, create a new project, then come back to me. Or open google shared official latest examples, because right now u are just ignorant.

@topsecret230 @AnxiousADHDGuy

I was pretty sure that newer Android versions support JDK 11… But it was JDK 9 API support, JDK 11 only comes with Android 13 - which doesn't fit the min version of the project.

If you don't use JUnit 4, don't enable it.
I always hated template generations which still include it. It's dead.
Really really really dead.

:)

The lawsuit of Google vs Oracle really did a number on Android Java it seems.

Which is a bit dangerous as the JDK 8 ecosystem is really dying quickly. No one wants to deal with the burden and wants especially to move on from things like the security deprecations.

@IntrusionCM speaking out of your ass again my man

Nobody gives a damn about jdk since you dont code with java anymore. U code with kotlin, jdk is there just for jvm to run bytecode on.

Yeah. Maybe thats the reason it might be wise to not run on an ancient JDK.

Keep an eye out for nasty surprises - cause it's unlikely that you have a 100 % kotlin only project.

The "but android studio generated that template" mantra is a dangerous one... Google has developer capacities most companies dream of.

Even more dangerous that Kotlin "just" runs on the JVM. We're close to JDK 21 LTS. JVM 11 is EOL next year. Maybe one should keep an eye out what happens next and what is possible vs what is done today...

Even just toying with JDK 17 plus and release parameter set to 11 to force API compatibility might be a wise idea, cause the JVM changes in JDK 8 plus are *enormous*.

The JDK 8 ecosystem is dying rapidly - for good reasons.

So not really talking out my ass, just poking the bear to give a reminder that it's never dumb to be ahead of the time.

Cause Google does give crap about wether you can keep up or not.