8
github
7y

What to do when for a single issue, multiple contributors send out different PRs doing the same stuff?
I feel bad to close a PR without merging when they have spent there time in it.
I never expected that my repo will ever attain such dilemma for PRs.

Comments
  • 0
    I've never faced this, but I guess the first PR that matches your requirements would be the easiest pick. Explain said requirements to the rejected PRs and that the one you picked was the first to match them.
  • 1
    @CptFox yup. I am doing that. Just feels bad that someone's contribution is not going to be added
  • 1
    @github Yeah, it's a bit sad, but you can't just pile up everyone's PR. As long as the choice is fair, I think they'd understand. And anyway, you can at least rest knowing that most people susceptible to create PRs have relatively low upper body strength and a tendency to dislike confrontation 😁
  • 3
    Put both of them into a fighting pit, naked, with just a pool noodle. Last man standing gets his PR merged!
  • 2
    @corjaantje I like how this guy thinks, forget my solution.

    As a bonus, that way you make sure never to piss off the PR creators that may hit you 😁
  • 1
    @corjaantje @CptFox haha.. if such thing happens, the PR accepted and merged will be the toughest ever PR which involved physical and mental strength.. 😂😂
Add Comment